[Pharo 8.0] Build #827: 2442-Commander-should-not-use-Smalltalk-ui-icons-but-self-iconNamed
There is a new Pharo build available! The status of the build #827 was: SUCCESS. The Pull Request #4821 was integrated: "2442-Commander-should-not-use-Smalltalk-ui-icons-but-self-iconNamed" Pull request url: https://github.com/pharo-project/pharo/pull/4821 Issue Url: https://github.com/pharo-project/pharo/issues/2442 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20...
ci-pharo-ci-jenkins2 wrote
"2442-Commander-should-not-use-Smalltalk-ui-icons-but-self-iconNamed"
I was surprised to see `Object>>#iconNamed:`. While it certainly reduces the duplication of `Smalltalk ui icons`, we have seemed extremely reluctant in the past to add to Object's inevitable bloat. I'm curious what made this one in particular worth it? ----- Cheers, Sean -- Sent from: http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html
We know. It was not my intention. I was slowly trying to identify what object (and not models) need it. Denis pushed it and now we will remove it. The idea is to - place it in Model - I introduced DisplayableObject as a superclass of the objects that still do icon: named and others. Now you cannot imagine how many plain objects (yes this is terrible to me) are receiver of it. Stef
On 4 Oct 2019, at 15:36, Sean P. DeNigris <sean@clipperadams.com> wrote:
ci-pharo-ci-jenkins2 wrote
"2442-Commander-should-not-use-Smalltalk-ui-icons-but-self-iconNamed"
I was surprised to see `Object>>#iconNamed:`. While it certainly reduces the duplication of `Smalltalk ui icons`, we have seemed extremely reluctant in the past to add to Object's inevitable bloat. I'm curious what made this one in particular worth it?
----- Cheers, Sean -- Sent from: http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html
ducasse wrote
The idea is to...
Thanks for the explanation :) ----- Cheers, Sean -- Sent from: http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html
participants (3)
-
ci-pharo-ci-jenkins2＠inria.fr -
ducasse -
Sean P. DeNigris