[Pharo-project] Fix for issue 981 Author class in pharo
http://code.google.com/p/pharo/issues/detail?id=981 Name: SLICE-ChangeAuthorInitialsAndNameToFullName-MiguelCoba.3 Author: MiguelCoba Time: 25 July 2009, 3:53:41 am UUID: 27a1accc-4f41-4d11-94f5-9bdbb4166bd7 Ancestors: SLICE-ChangeAuthorInitialsAndNameToFullName-MiguelCoba.2 Dependencies: Monticello-MiguelCoba.372, Morphic-MiguelCoba.347, ScriptLoader-MiguelCoba.972, System-Changes-MiguelCoba.11, System-Support-MiguelCoba.62, Tools-MiguelCoba.179 Removes all the code from initials and name on Author class. It is replaced by a new fullName inst var and corresponding methods. The old code it is deprecated and the image contains no more calls to the old code. All the new code should call only the fullName methods in Author This is my first intent to rewrite the Author class to unify the instance variables. Please, check it on a 10392 core image and post your comments/critics. Also, I didn't modify the following methods of Utilities. Tell me what would you like to do with them, please: Utilities fixStamp: Utilities methodsWithInitials: Utilities doesMethod:forClass:bearInitials Cheers, Miguel Cobá
2009/7/25 Miguel Enrique Cobá Martinez <miguel.coba@gmail.com>:
http://code.google.com/p/pharo/issues/detail?id=981
Name: SLICE-ChangeAuthorInitialsAndNameToFullName-MiguelCoba.3 Author: MiguelCoba Time: 25 July 2009, 3:53:41 am UUID: 27a1accc-4f41-4d11-94f5-9bdbb4166bd7 Ancestors: SLICE-ChangeAuthorInitialsAndNameToFullName-MiguelCoba.2 Dependencies: Monticello-MiguelCoba.372, Morphic-MiguelCoba.347, ScriptLoader-MiguelCoba.972, System-Changes-MiguelCoba.11, System-Support-MiguelCoba.62, Tools-MiguelCoba.179
Removes all the code from initials and name on Author class. It is replaced by a new fullName inst var and corresponding methods. The old code it is deprecated and the image contains no more calls to the old code. All the new code should call only the fullName methods in Author
This is my first intent to rewrite the Author class to unify the instance variables. Please, check it on a 10392 core image and post your comments/critics.
Also, I didn't modify the following methods of Utilities. Tell me what would you like to do with them, please:
Utilities fixStamp: Utilities methodsWithInitials: Utilities doesMethod:forClass:bearInitials
Also, it should fix also http://code.google.com/p/pharo/issues/detail?id=142 http://code.google.com/p/pharo/issues/detail?id=344 I changed the status of 981 to fixed as directed by the HowToContribute wiki page. Miguel Cobá
Cheers, Miguel Cobá
I have tested the SLICE of issue 981 on a new Pharo 10401 beta image and an updated 10402 image and it loads without problems. Should I mark this as milestone 1.0 or isn't elegible for this first release? I know that my opinion is biased, but I think that the 1.0 version of pharo should have the initials problem solved in order to base all the subsecuent code not to depende on initials. Comments? Has anyone confirmed that the functionality is correct? What about the format of the name and the message prompt? Cheers, Miguel Cobá On Mon, Jul 27, 2009 at 11:40 AM, Miguel Cobá<miguel.coba@gmail.com> wrote:
2009/7/25 Miguel Enrique Cobá Martinez <miguel.coba@gmail.com>:
http://code.google.com/p/pharo/issues/detail?id=981
Name: SLICE-ChangeAuthorInitialsAndNameToFullName-MiguelCoba.3 Author: MiguelCoba Time: 25 July 2009, 3:53:41 am UUID: 27a1accc-4f41-4d11-94f5-9bdbb4166bd7 Ancestors: SLICE-ChangeAuthorInitialsAndNameToFullName-MiguelCoba.2 Dependencies: Monticello-MiguelCoba.372, Morphic-MiguelCoba.347, ScriptLoader-MiguelCoba.972, System-Changes-MiguelCoba.11, System-Support-MiguelCoba.62, Tools-MiguelCoba.179
Removes all the code from initials and name on Author class. It is replaced by a new fullName inst var and corresponding methods. The old code it is deprecated and the image contains no more calls to the old code. All the new code should call only the fullName methods in Author
This is my first intent to rewrite the Author class to unify the instance variables. Please, check it on a 10392 core image and post your comments/critics.
Also, I didn't modify the following methods of Utilities. Tell me what would you like to do with them, please:
Utilities fixStamp: Utilities methodsWithInitials: Utilities doesMethod:forClass:bearInitials
Also, it should fix also
http://code.google.com/p/pharo/issues/detail?id=142 http://code.google.com/p/pharo/issues/detail?id=344
I changed the status of 981 to fixed as directed by the HowToContribute wiki page.
Miguel Cobá
Cheers, Miguel Cobá
Thanks miguel this is the right way to do it (ask for feedback) I'm sporadic internet connection so I do not even dare to do an update. Next week will be better. Stef On Aug 1, 2009, at 1:05 AM, Miguel Cobá wrote:
I have tested the SLICE of issue 981 on a new Pharo 10401 beta image and an updated 10402 image and it loads without problems.
Should I mark this as milestone 1.0 or isn't elegible for this first release? I know that my opinion is biased, but I think that the 1.0 version of pharo should have the initials problem solved in order to base all the subsecuent code not to depende on initials.
Comments? Has anyone confirmed that the functionality is correct? What about the format of the name and the message prompt?
Cheers, Miguel Cobá
On Mon, Jul 27, 2009 at 11:40 AM, Miguel Cobá<miguel.coba@gmail.com> wrote:
2009/7/25 Miguel Enrique Cobá Martinez <miguel.coba@gmail.com>:
http://code.google.com/p/pharo/issues/detail?id=981
Name: SLICE-ChangeAuthorInitialsAndNameToFullName-MiguelCoba.3 Author: MiguelCoba Time: 25 July 2009, 3:53:41 am UUID: 27a1accc-4f41-4d11-94f5-9bdbb4166bd7 Ancestors: SLICE-ChangeAuthorInitialsAndNameToFullName-MiguelCoba.2 Dependencies: Monticello-MiguelCoba.372, Morphic-MiguelCoba.347, ScriptLoader-MiguelCoba.972, System-Changes-MiguelCoba.11, System-Support-MiguelCoba.62, Tools-MiguelCoba.179
Removes all the code from initials and name on Author class. It is replaced by a new fullName inst var and corresponding methods. The old code it is deprecated and the image contains no more calls to the old code. All the new code should call only the fullName methods in Author
This is my first intent to rewrite the Author class to unify the instance variables. Please, check it on a 10392 core image and post your comments/ critics.
Also, I didn't modify the following methods of Utilities. Tell me what would you like to do with them, please:
Utilities fixStamp: Utilities methodsWithInitials: Utilities doesMethod:forClass:bearInitials
Also, it should fix also
http://code.google.com/p/pharo/issues/detail?id=142 http://code.google.com/p/pharo/issues/detail?id=344
I changed the status of 981 to fixed as directed by the HowToContribute wiki page.
Miguel Cobá
Cheers, Miguel Cobá
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
On Sat, Aug 1, 2009 at 6:05 AM, Miguel Cobá<miguel.coba@gmail.com> wrote:
I have tested the SLICE of issue 981 on a new Pharo 10401 beta image and an updated 10402 image and it loads without problems.
Should I mark this as milestone 1.0 or isn't elegible for this first release? I know that my opinion is biased, but I think that the 1.0 version of pharo should have the initials problem solved in order to base all the subsecuent code not to depende on initials.
Comments? Has anyone confirmed that the functionality is correct? What about the format of the name and the message prompt?
Normaly, during in beta phase, no new functionality should be commit, only bug patches. But maybe you can consider this one as a patch ;-) -- Serge Stinckwich UMI UMMISCO 209 (IRD/UPMC), Hanoi, Vietnam Smalltalkers do: [:it | All with: Class, (And love: it)] http://doesnotunderstand.org/
participants (4)
-
Miguel Cobá -
Miguel Enrique Cobá Martinez
-
Serge Stinckwich -
Stéphane Ducasse