[Pharo-project] _ into := changes based on RB
lukas we would like to clean the image using your _ -> := rewrite rules. How can do that? Stef
I first need to fix the parser, before you will be able to do that. Lukas 2009/10/17 Stéphane Ducasse <stephane.ducasse@inria.fr>:
lukas
we would like to clean the image using your _ -> := rewrite rules. How can do that?
Stef
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Lukas Renggli http://www.lukas-renggli.ch
-=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=- rule := RBUnderscoreAssignmentRule new. SmalllintChecker runRule: rule onEnvironment: BrowserEnvironment new. rule open -=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=- The second expression takes a few minutes, because it parses the complete image. Note, that the resulting browser won't show a diff of the changes, because it pretty prints the AST using ':=' in both cases. Apply the changes and use the Monticello changes to see the real difference. Lukas -- Lukas Renggli http://www.lukas-renggli.ch
Shouldn't my incredible ThothCompiler allow that? http://smalltalkthoughts.blogspot.com/2009/09/introducing-thothcompiler.html niko On Sat, Oct 17, 2009 at 1:31 PM, Lukas Renggli <renggli@gmail.com> wrote:
-=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=-
rule := RBUnderscoreAssignmentRule new. SmalllintChecker runRule: rule onEnvironment: BrowserEnvironment new. rule open
-=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=-
The second expression takes a few minutes, because it parses the complete image. Note, that the resulting browser won't show a diff of the changes, because it pretty prints the AST using ':=' in both cases. Apply the changes and use the Monticello changes to see the real difference.
Lukas
-- Lukas Renggli http://www.lukas-renggli.ch
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
I get a DNU rule does not know open. On Oct 17, 2009, at 1:31 PM, Lukas Renggli wrote:
-=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=-
rule := RBUnderscoreAssignmentRule new. SmalllintChecker runRule: rule onEnvironment: BrowserEnvironment new. rule open
-=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=-
The second expression takes a few minutes, because it parses the complete image. Note, that the resulting browser won't show a diff of the changes, because it pretty prints the AST using ':=' in both cases. Apply the changes and use the Monticello changes to see the real difference.
Lukas
-- Lukas Renggli http://www.lukas-renggli.ch
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
That's because you're using the latest Pharo. YOU changed the old AST, and removed a method called "null" that I'm calling. I'll update ThothCompiler tonight. cheers, niko On Sat, Oct 17, 2009 at 3:38 PM, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
I get a DNU rule does not know open.
On Oct 17, 2009, at 1:31 PM, Lukas Renggli wrote:
-=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=-
rule := RBUnderscoreAssignmentRule new. SmalllintChecker runRule: rule onEnvironment: BrowserEnvironment new. rule open
-=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=-
The second expression takes a few minutes, because it parses the complete image. Note, that the resulting browser won't show a diff of the changes, because it pretty prints the AST using ':=' in both cases. Apply the changes and use the Monticello changes to see the real difference.
Lukas
-- Lukas Renggli http://www.lukas-renggli.ch
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
who changed what? I did not change the AST. Stef On Oct 17, 2009, at 3:40 PM, Niko Schwarz wrote:
That's because you're using the latest Pharo. YOU changed the old AST, and removed a method called "null" that I'm calling. I'll update ThothCompiler tonight.
cheers,
niko
On Sat, Oct 17, 2009 at 3:38 PM, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
I get a DNU rule does not know open.
On Oct 17, 2009, at 1:31 PM, Lukas Renggli wrote:
-=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=-
rule := RBUnderscoreAssignmentRule new. SmalllintChecker runRule: rule onEnvironment: BrowserEnvironment new. rule open
-=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=-
The second expression takes a few minutes, because it parses the complete image. Note, that the resulting browser won't show a diff of the changes, because it pretty prints the AST using ':=' in both cases. Apply the changes and use the Monticello changes to see the real difference.
Lukas
-- Lukas Renggli http://www.lukas-renggli.ch
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
lukas I loaded AST like that and I get open DNU. Stef |instClass installWebTools font codeFont titleFont| instClass := Smalltalk at: #Installer ifAbsent: [ScriptLoader loadLatestPackage: 'Installer-Core' fromSqueaksource: 'Installer'. Smalltalk at: #Installer]. instClass ss project: 'AST'; install: 'AST-lr'. instClass ss project: 'RefactoringEngine'; install: 'Refactoring-Core'.
That looks correct. I will try in the latests Pharo and try to get rid of these dependencies in the AST package. Lukas 2009/10/17 Stéphane Ducasse <stephane.ducasse@inria.fr>:
lukas I loaded  AST like that and I get open DNU.
Stef
|instClass installWebTools font codeFont titleFont|
instClass := Smalltalk at: #Installer ifAbsent: [ScriptLoader loadLatestPackage: 'Installer-Core' fromSqueaksource: 'Installer'. Smalltalk at: #Installer].
instClass ss     project: 'AST';     install: 'AST-lr'.
instClass ss     project: 'RefactoringEngine';     install: 'Refactoring-Core'.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Lukas Renggli http://www.lukas-renggli.ch
ok thanks. let us know after I will run and produce a batch of packages that get := Stef On Oct 17, 2009, at 4:46 PM, Lukas Renggli wrote:
That looks correct. I will try in the latests Pharo and try to get rid of these dependencies in the AST package.
Lukas
2009/10/17 Stéphane Ducasse <stephane.ducasse@inria.fr>:
lukas I loaded AST like that and I get open DNU.
Stef
|instClass installWebTools font codeFont titleFont|
instClass := Smalltalk at: #Installer ifAbsent: [ScriptLoader loadLatestPackage: 'Installer-Core' fromSqueaksource: 'Installer'. Smalltalk at: #Installer].
instClass ss project: 'AST'; install: 'AST-lr'.
instClass ss project: 'RefactoringEngine'; install: 'Refactoring-Core'.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Lukas Renggli http://www.lukas-renggli.ch
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
It works for me in the latest Pharo with AST-lr.176 and Refactoring-Core-lr.59. With the following snippet you don't need the OB UI: rule := RBUnderscoreAssignmentRule new. SmalllintChecker runRule: rule onEnvironment: BrowserEnvironment new. rule changes do: [ :each | each execute ] Lukas 2009/10/17 Stéphane Ducasse <stephane.ducasse@inria.fr>:
ok thanks. let us know after I will run and produce a batch of packages that get := Stef
On Oct 17, 2009, at 4:46 PM, Lukas Renggli wrote:
That looks correct. I will try in the latests Pharo and try to get rid of these dependencies in the AST package.
Lukas
2009/10/17 Stéphane Ducasse <stephane.ducasse@inria.fr>:
lukas I loaded  AST like that and I get open DNU.
Stef
|instClass installWebTools font codeFont titleFont|
instClass := Smalltalk at: #Installer ifAbsent: [ScriptLoader loadLatestPackage: 'Installer-Core' fromSqueaksource: 'Installer'. Smalltalk at: #Installer].
instClass ss     project: 'AST';     install: 'AST-lr'.
instClass ss     project: 'RefactoringEngine';     install: 'Refactoring-Core'.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Lukas Renggli http://www.lukas-renggli.ch
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Lukas Renggli http://www.lukas-renggli.ch
In fact the following script does everything in a pharo core image. In my case it finds changes in Graphics and System-Hashing: ScriptLoader loadLatestPackage: 'Gofer' from: 'http://source.lukas-renggli.ch/flair'. Gofer new squeaksource: 'AST'; addPackage: 'AST' constraint: [ :v | v authorName = 'lr' ]; load. Gofer new squeaksource: 'RefactoringEngine'; addPackage: 'Refactoring-Core'; load. rule := RBUnderscoreAssignmentRule new. SmalllintChecker runRule: rule onEnvironment: BrowserEnvironment new. rule changes do: [ :each | each execute ] Lukas 2009/10/17 Lukas Renggli <renggli@gmail.com>:
It works for me in the latest Pharo with AST-lr.176 and Refactoring-Core-lr.59.
With the following snippet you don't need the OB UI:
 rule := RBUnderscoreAssignmentRule new.  SmalllintChecker runRule: rule onEnvironment: BrowserEnvironment new.  rule changes do: [ :each | each execute ]
Lukas
2009/10/17 Stéphane Ducasse <stephane.ducasse@inria.fr>:
ok thanks. let us know after I will run and produce a batch of packages that get := Stef
On Oct 17, 2009, at 4:46 PM, Lukas Renggli wrote:
That looks correct. I will try in the latests Pharo and try to get rid of these dependencies in the AST package.
Lukas
2009/10/17 Stéphane Ducasse <stephane.ducasse@inria.fr>:
lukas I loaded  AST like that and I get open DNU.
Stef
|instClass installWebTools font codeFont titleFont|
instClass := Smalltalk at: #Installer ifAbsent: [ScriptLoader loadLatestPackage: 'Installer-Core' fromSqueaksource: 'Installer'. Smalltalk at: #Installer].
instClass ss     project: 'AST';     install: 'AST-lr'.
instClass ss     project: 'RefactoringEngine';     install: 'Refactoring-Core'.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Lukas Renggli http://www.lukas-renggli.ch
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Lukas Renggli http://www.lukas-renggli.ch
-- Lukas Renggli http://www.lukas-renggli.ch
On Oct 17, 2009, at 5:12 PM, Lukas Renggli wrote:
In fact the following script does everything in a pharo core image. In my case it finds changes in Graphics and System-Hashing:
ScriptLoader loadLatestPackage: 'Gofer' from: 'http://source.lukas-renggli.ch/ flair'. Gofer new squeaksource: 'AST'; addPackage: 'AST' constraint: [ :v | v authorName = 'lr' ]; load. Gofer new squeaksource: 'RefactoringEngine'; addPackage: 'Refactoring-Core'; load. rule := RBUnderscoreAssignmentRule new. SmalllintChecker runRule: rule onEnvironment: BrowserEnvironment new. rule changes do: [ :each | each execute ]
yes me too :) Stef
Lukas
2009/10/17 Lukas Renggli <renggli@gmail.com>:
It works for me in the latest Pharo with AST-lr.176 and Refactoring- Core-lr.59.
With the following snippet you don't need the OB UI:
rule := RBUnderscoreAssignmentRule new. SmalllintChecker runRule: rule onEnvironment: BrowserEnvironment new. rule changes do: [ :each | each execute ]
Lukas
2009/10/17 Stéphane Ducasse <stephane.ducasse@inria.fr>:
ok thanks. let us know after I will run and produce a batch of packages that get := Stef
On Oct 17, 2009, at 4:46 PM, Lukas Renggli wrote:
That looks correct. I will try in the latests Pharo and try to get rid of these dependencies in the AST package.
Lukas
2009/10/17 Stéphane Ducasse <stephane.ducasse@inria.fr>:
lukas I loaded AST like that and I get open DNU.
Stef
|instClass installWebTools font codeFont titleFont|
instClass := Smalltalk at: #Installer ifAbsent: [ScriptLoader loadLatestPackage: 'Installer-Core' fromSqueaksource: 'Installer'. Smalltalk at: #Installer].
instClass ss project: 'AST'; install: 'AST-lr'.
instClass ss project: 'RefactoringEngine'; install: 'Refactoring-Core'.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo- project
-- Lukas Renggli http://www.lukas-renggli.ch
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Lukas Renggli http://www.lukas-renggli.ch
-- Lukas Renggli http://www.lukas-renggli.ch
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Thanks!!!!!!!!!!!!!!!!!!!!!! Stef
It works for me in the latest Pharo with AST-lr.176 and Refactoring- Core-lr.59.
With the following snippet you don't need the OB UI:
rule := RBUnderscoreAssignmentRule new. SmalllintChecker runRule: rule onEnvironment: BrowserEnvironment new. rule changes do: [ :each | each execute ]
participants (3)
-
Lukas Renggli -
Niko Schwarz -
Stéphane Ducasse