[Review] Issue 14080: Nuke remaining subStringXyz's
https://pharo.fogbugz.com/default.asp?14080 This was a real PITA! The monkey finally passed it. All [s|S]ubStr[ing].* methods and users have been changed to e.g. substring. I'd like to get it integrated ASAP because this is another that touches many packages and will be hard to keep up to date. Thanks. I notified the maintainers of affected external packages, except Metacello which I included in the slice. Is that correct? ----- Cheers, Sean -- View this message in context: http://forum.world.st/Review-Issue-14080-Nuke-remaining-subStringXyz-s-tp482... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
Congrats Sean for this one! It impacts on a lot of external packages... #Luc 2015-04-28 20:58 GMT+02:00 Sean P. DeNigris <sean@clipperadams.com>:
https://pharo.fogbugz.com/default.asp?14080
This was a real PITA! The monkey finally passed it. All [s|S]ubStr[ing].* methods and users have been changed to e.g. substring. I'd like to get it integrated ASAP because this is another that touches many packages and will be hard to keep up to date. Thanks.
I notified the maintainers of affected external packages, except Metacello which I included in the slice. Is that correct?
----- Cheers, Sean -- View this message in context: http://forum.world.st/Review-Issue-14080-Nuke-remaining-subStringXyz-s-tp482... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
Luc Fabresse wrote
Congrats Sean for this one! It impacts on a lot of external packages...
Thanks, Luc! The whole time I was working on this, I was thinking "there is not enough value in a simple rename to be worth all this work". But now, I'm really glad I finished it for one reason - now I know it can be done! What I mean is that IIRC it would have been way more complicated and scary to do that change a few years ago without Jenkins, Penelope, slices, a group of immediately available reviewers/integrators, etc. I clearly experienced the compounded value of all of the infrastructure we have built. Now that I know we have the structures necessary to support broad changes to the system, I am dreaming about what to do next... ----- Cheers, Sean -- View this message in context: http://forum.world.st/Review-Issue-14080-Nuke-remaining-subStringXyz-s-tp482... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
Le 29/4/15 13:46, Sean P. DeNigris a écrit :
Luc Fabresse wrote
Congrats Sean for this one! It impacts on a lot of external packages... Thanks, Luc! The whole time I was working on this, I was thinking "there is not enough value in a simple rename to be worth all this work".
No there is :)
But now, I'm really glad I finished it for one reason - now I know it can be done! What I mean is that IIRC it would have been way more complicated and scary to do that change a few years ago without Jenkins, Penelope, slices, a group of immediately available reviewers/integrators, etc. I clearly experienced the compounded value of all of the infrastructure we have built. Now that I know we have the structures necessary to support broad changes to the system, I am dreaming about what to do next...
----- Cheers, Sean -- View this message in context: http://forum.world.st/Review-Issue-14080-Nuke-remaining-subStringXyz-s-tp482... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
On 28 Apr 2015, at 20:58, Sean P. DeNigris <sean@clipperadams.com> wrote:
https://pharo.fogbugz.com/default.asp?14080
This was a real PITA! The monkey finally passed it. All [s|S]ubStr[ing].* methods and users have been changed to e.g. substring. I'd like to get it integrated ASAP because this is another that touches many packages and will be hard to keep up to date. Thanks.
I notified the maintainers of affected external packages, except Metacello which I included in the slice. Is that correct?
Metacello is a problem⦠it is supposed to stay compatible to Squeak, Pharo1.1 and strange things like that⦠The version in the image is very old and needs to be updated, too. So for now I would just change it and then we see what to do⦠Marcus
participants (4)
-
Luc Fabresse -
Marcus Denker -
Sean P. DeNigris -
stepharo