[Pharo-project] About Network-YM.44.mcz
Hi list, I figured I'd explain my commit here, since I don't know how you handle your issue tracker. While I was loading some code in my image (Universes iirc), I got a lot of warnings pop up, about Url>>#toText being deprecated. After taking a look at it, I saw that the deprecation comment recommended using instead Url>>#asText. Which I tried, but it broke most of the SUnits and also the expected behaviour. Looking at the code, I saw that Url>>#toText simply did ^self asString, when Url>>#asText does ^self asString asText. The semantic leap between Text and String is too big (imo) to force that change on users. I thought it would be better to replace the deprecation comment to recommend replacing the obsolote Url>>#toText by Url>>#asString (which is what this method actually does). I would rather have removed the method, since it has been marked for obsolete for more than 3 years now! But I don't know what the approach is to deleting methods, and how to communicate to people that this isn't a missing method but an intentional removal. I hope this helps understand this version. Cheers, Yann
But what did you get from the senders of Url>>#toText? Because indeed Url>>#toText will be removed. Ok I will check what you did and wait for your agreement :) Stef On Sep 28, 2008, at 9:09 PM, Yann Monclair wrote:
Hi list,
I figured I'd explain my commit here, since I don't know how you handle your issue tracker.
While I was loading some code in my image (Universes iirc), I got a lot of warnings pop up, about Url>>#toText being deprecated. After taking a look at it, I saw that the deprecation comment recommended using instead Url>>#asText. Which I tried, but it broke most of the SUnits and also the expected behaviour. Looking at the code, I saw that Url>>#toText simply did ^self asString, when Url>>#asText does ^self asString asText. The semantic leap between Text and String is too big (imo) to force that change on users. I thought it would be better to replace the deprecation comment to recommend replacing the obsolote Url>>#toText by Url>>#asString (which is what this method actually does).
I would rather have removed the method, since it has been marked for obsolete for more than 3 years now! But I don't know what the approach is to deleting methods, and how to communicate to people that this isn't a missing method but an intentional removal.
I hope this helps understand this version.
Cheers,
Yann _______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
I replaced the only sender I found in the base Pharo image (HttpUrl>>#askNamePassword). I found a few senders in Universe, but I couldn't publish the changes, the project is ReadOnly and I haven't time to chase up the admins about it yet. I'll send my agreement next week. Cheers, Yann On Sun, Sep 28, 2008 at 8:34 PM, Stéphane Ducasse <stephane.ducasse@inria.fr
wrote:
But what did you get from the senders of Url>>#toText? Because indeed Url>>#toText will be removed.
Ok I will check what you did and wait for your agreement :)
Stef
On Sep 28, 2008, at 9:09 PM, Yann Monclair wrote:
Hi list,
I figured I'd explain my commit here, since I don't know how you handle your issue tracker.
While I was loading some code in my image (Universes iirc), I got a lot of warnings pop up, about Url>>#toText being deprecated. After taking a look at it, I saw that the deprecation comment recommended using instead Url>>#asText. Which I tried, but it broke most of the SUnits and also the expected behaviour. Looking at the code, I saw that Url>>#toText simply did ^self asString, when Url>>#asText does ^self asString asText. The semantic leap between Text and String is too big (imo) to force that change on users. I thought it would be better to replace the deprecation comment to recommend replacing the obsolote Url>>#toText by Url>>#asString (which is what this method actually does).
I would rather have removed the method, since it has been marked for obsolete for more than 3 years now! But I don't know what the approach is to deleting methods, and how to communicate to people that this isn't a missing method but an intentional removal.
I hope this helps understand this version.
Cheers,
Yann _______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
thanks. Stef On Sep 28, 2008, at 9:44 PM, Yann Monclair wrote:
I replaced the only sender I found in the base Pharo image (HttpUrl>>#askNamePassword).
I found a few senders in Universe, but I couldn't publish the changes, the project is ReadOnly and I haven't time to chase up the admins about it yet.
I'll send my agreement next week.
Cheers,
Yann
On Sun, Sep 28, 2008 at 8:34 PM, Stéphane Ducasse <stephane.ducasse@inria.fr
wrote: But what did you get from the senders of Url>>#toText? Because indeed Url>>#toText will be removed.
Ok I will check what you did and wait for your agreement :)
Stef
On Sep 28, 2008, at 9:09 PM, Yann Monclair wrote:
Hi list,
I figured I'd explain my commit here, since I don't know how you handle your issue tracker.
While I was loading some code in my image (Universes iirc), I got a lot of warnings pop up, about Url>>#toText being deprecated. After taking a look at it, I saw that the deprecation comment recommended using instead Url>>#asText. Which I tried, but it broke most of the SUnits and also the expected behaviour. Looking at the code, I saw that Url>>#toText simply did ^self asString, when Url>>#asText does ^self asString asText. The semantic leap between Text and String is too big (imo) to force that change on users. I thought it would be better to replace the deprecation comment to recommend replacing the obsolote Url>>#toText by Url>>#asString (which is what this method actually does).
I would rather have removed the method, since it has been marked for obsolete for more than 3 years now! But I don't know what the approach is to deleting methods, and how to communicate to people that this isn't a missing method but an intentional removal.
I hope this helps understand this version.
Cheers,
Yann _______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
On Sun, Sep 28, 2008 at 9:44 PM, Yann Monclair <yann.monclair@smalltalk.fr> wrote:
I found a few senders in Universe, but I couldn't publish the changes, the project is ReadOnly and I haven't time to chase up the admins about it yet.
Philippe and I fixed them. Thanks -- Damien Cassou Peter von der Ahé: «I'm beginning to see why Gilad wished us good luck». (http://blogs.sun.com/ahe/entry/override_snafu)
participants (3)
-
Damien Cassou -
Stéphane Ducasse -
Yann Monclair