[Pharo-project] Issue 3692 in pharo: Default line-end convention fix
Status: Accepted Owner: siguc...@gmail.com New issue 3692 by siguc...@gmail.com: Default line-end convention fix http://code.google.com/p/pharo/issues/detail?id=3692 Multibyte filestream guess about line endings was apparently wrong. Should use CR for MacOS and LF for rest unixes, not vise verse. Attachments: fix-line-ends.1.cs 678 bytes
Updates: Status: Fixed Labels: Milestone-1.3 Difficulty-Easy Type-ReportDefect Comment #1 on issue 3692 by siguc...@gmail.com: Default line-end convention fix http://code.google.com/p/pharo/issues/detail?id=3692 (No comment was entered for this change.)
Comment #2 on issue 3692 by ryd...@gmail.com: Default line-end convention fix http://code.google.com/p/pharo/issues/detail?id=3692 Eeeeh... Pretty sure the check should be for isMacOS9, OSX uses LF. Would need to check with John which vm's actually return an osVersion starting with darwin though (which the original code checked against) If that is correct, per the comment in isMacOS9, it should be safe to simply drop the check and always use LF :)
Comment #3 on issue 3692 by stephane...@gmail.com: Default line-end convention fix http://code.google.com/p/pharo/issues/detail?id=3692 so guys what is the conclusion of that?
Updates: Status: FixProposed Comment #4 on issue 3692 by marcus.d...@gmail.com: Default line-end convention fix http://code.google.com/p/pharo/issues/detail?id=3692 (No comment was entered for this change.)
Updates: Status: Started Comment #5 on issue 3692 by marcus.d...@gmail.com: Default line-end convention fix http://code.google.com/p/pharo/issues/detail?id=3692 As there is no conclusion, I move from FixProposed to status Started
Updates: Labels: -Milestone-1.3 Comment #6 on issue 3692 by marcus.d...@gmail.com: Default line-end convention fix http://code.google.com/p/pharo/issues/detail?id=3692 (No comment was entered for this change.)
Comment #7 on issue 3692 by elpochod...@gmail.com: Default line-end convention fix http://code.google.com/p/pharo/issues/detail?id=3692 from http://en.wikipedia.org/wiki/Newline CR+LF: DEC TOPS-10, RT-11 and most other early non-Unix, non-IBM OSes, CP/M, MP/M, DOS (MS-DOS, PC-DOS, etc.), Atari TOS, OS/2, Microsoft Windows, Symbian OS, Palm OS LF+CR: Acorn BBC spooled text output. CR: Commodore 8-bit machines, Acorn BBC, TRS-80, Apple II family, Mac OS up to version 9 and OS-9 LF: Multics, Unix and Unix-like systems (GNU/Linux, AIX, Xenix, Mac OS X, FreeBSD, etc.), BeOS, Amiga, RISC OS, and others. However, in tty 'raw mode', CR+LF is used for output and CR is used for input. so on linux and MacOSX should be LF (I'm wrongly getting CR with Pharo1.2 and Pharo1.3 on Ubuntu). On MacOS9 should be CR.
participants (1)
-
pharo＠googlecode.com