[Pharo-project] SUnit: history support and OB icons
Hi all Just to notify a new enhancement to review in the PharoInbox. SLICE-Issue338-SUnitHistoryAndIcons-simon_denier.2 Short doc: Add: - support history for test runs as well as progression filter to show test in progression, regression - support icons in OB to show the current state of a test: passed, failed, progressed, regressed... History support: - whenever some test cases run from the TestRunner, their results are stored in a class side variable TestResult class>>History - contextual menu for history in TestRunner>>error pane: 1) History: access submenu to TestRunner instance history: can save and show progress between results ran in the same TestRunner; lost when this particular instance of TestRunner is closed 2) Store results as progress reference: create/update a lastStoredRun method on the class side of each TestCase which have just been run, containing the results 3) Show progress: make a diff between the last run and the lastStoredRun, showing progress or regress in tests (new passed, new failures, new errors) The idea is that whenever you are satisfied with the current results of some of your tests, you can save this state as a reference point with the 'Store results...' action. This reference point can be compared with subsequent test results to show your progression or regression. Test results are stored in a class side variable some are kept local to your image. Reference results are stored in a special method for each TestCase, so that they are saved with their package and can be used as a common reference for package developers. So a good practice is to store the latest test results as reference before committing your changes. Icons support: OB Package browser now has icons for test methods in TestCase subclasses: - green circle: test has passed in the last run - red circle: test has failed - half green/half red circle: state unknown, test has no history or test has changed since last run - (no icon): test has raised an error - upside green arrow: test has progressed since last reference run - downside blue triangle: test has regressed since last reference run A test is in progression if it goes from error or failure to passed state. A test is in regression if it goes from passed to error or failure state. The last two icons have other meanings with methods not related to test, so we should change them whenever someone has better icons. Authors: Alexandre Bergel, Simon Denier, David Röthlisberger -- Simon
cool I want to test that. Stef On Nov 19, 2008, at 10:02 PM, Simon Denier wrote:
Hi all
Just to notify a new enhancement to review in the PharoInbox.
SLICE-Issue338-SUnitHistoryAndIcons-simon_denier.2
Short doc:
Add: - support history for test runs as well as progression filter to show test in progression, regression - support icons in OB to show the current state of a test: passed, failed, progressed, regressed...
History support: - whenever some test cases run from the TestRunner, their results are stored in a class side variable TestResult class>>History - contextual menu for history in TestRunner>>error pane: 1) History: access submenu to TestRunner instance history: can save and show progress between results ran in the same TestRunner; lost when this particular instance of TestRunner is closed 2) Store results as progress reference: create/update a lastStoredRun method on the class side of each TestCase which have just been run, containing the results 3) Show progress: make a diff between the last run and the lastStoredRun, showing progress or regress in tests (new passed, new failures, new errors)
The idea is that whenever you are satisfied with the current results of some of your tests, you can save this state as a reference point with the 'Store results...' action. This reference point can be compared with subsequent test results to show your progression or regression.
Test results are stored in a class side variable some are kept local to your image. Reference results are stored in a special method for each TestCase, so that they are saved with their package and can be used as a common reference for package developers. So a good practice is to store the latest test results as reference before committing your changes.
Icons support: OB Package browser now has icons for test methods in TestCase subclasses: - green circle: test has passed in the last run - red circle: test has failed - half green/half red circle: state unknown, test has no history or test has changed since last run - (no icon): test has raised an error - upside green arrow: test has progressed since last reference run - downside blue triangle: test has regressed since last reference run
A test is in progression if it goes from error or failure to passed state. A test is in regression if it goes from passed to error or failure state.
The last two icons have other meanings with methods not related to test, so we should change them whenever someone has better icons.
Authors: Alexandre Bergel, Simon Denier, David Röthlisberger
-- Simon
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
which version of OB should I load to get that? Stef On Nov 19, 2008, at 10:02 PM, Simon Denier wrote:
Hi all
Just to notify a new enhancement to review in the PharoInbox.
SLICE-Issue338-SUnitHistoryAndIcons-simon_denier.2
Short doc:
Add: - support history for test runs as well as progression filter to show test in progression, regression - support icons in OB to show the current state of a test: passed, failed, progressed, regressed...
History support: - whenever some test cases run from the TestRunner, their results are stored in a class side variable TestResult class>>History - contextual menu for history in TestRunner>>error pane: 1) History: access submenu to TestRunner instance history: can save and show progress between results ran in the same TestRunner; lost when this particular instance of TestRunner is closed 2) Store results as progress reference: create/update a lastStoredRun method on the class side of each TestCase which have just been run, containing the results 3) Show progress: make a diff between the last run and the lastStoredRun, showing progress or regress in tests (new passed, new failures, new errors)
The idea is that whenever you are satisfied with the current results of some of your tests, you can save this state as a reference point with the 'Store results...' action. This reference point can be compared with subsequent test results to show your progression or regression.
Test results are stored in a class side variable some are kept local to your image. Reference results are stored in a special method for each TestCase, so that they are saved with their package and can be used as a common reference for package developers. So a good practice is to store the latest test results as reference before committing your changes.
Icons support: OB Package browser now has icons for test methods in TestCase subclasses: - green circle: test has passed in the last run - red circle: test has failed - half green/half red circle: state unknown, test has no history or test has changed since last run - (no icon): test has raised an error - upside green arrow: test has progressed since last reference run - downside blue triangle: test has regressed since last reference run
A test is in progression if it goes from error or failure to passed state. A test is in regression if it goes from passed to error or failure state.
The last two icons have other meanings with methods not related to test, so we should change them whenever someone has better icons.
Authors: Alexandre Bergel, Simon Denier, David Röthlisberger
-- Simon
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
On 20 nov. 08, at 11:55, Stéphane Ducasse wrote:
which version of OB should I load to get that?
Actually, it should work with any OB loaded by the latest version, the icon support was already there.
Stef
On Nov 19, 2008, at 10:02 PM, Simon Denier wrote:
Hi all
Just to notify a new enhancement to review in the PharoInbox.
SLICE-Issue338-SUnitHistoryAndIcons-simon_denier.2
Short doc:
Add: - support history for test runs as well as progression filter to show test in progression, regression - support icons in OB to show the current state of a test: passed, failed, progressed, regressed...
History support: - whenever some test cases run from the TestRunner, their results are stored in a class side variable TestResult class>>History - contextual menu for history in TestRunner>>error pane: 1) History: access submenu to TestRunner instance history: can save and show progress between results ran in the same TestRunner; lost when this particular instance of TestRunner is closed 2) Store results as progress reference: create/update a lastStoredRun method on the class side of each TestCase which have just been run, containing the results 3) Show progress: make a diff between the last run and the lastStoredRun, showing progress or regress in tests (new passed, new failures, new errors)
The idea is that whenever you are satisfied with the current results of some of your tests, you can save this state as a reference point with the 'Store results...' action. This reference point can be compared with subsequent test results to show your progression or regression.
Test results are stored in a class side variable some are kept local to your image. Reference results are stored in a special method for each TestCase, so that they are saved with their package and can be used as a common reference for package developers. So a good practice is to store the latest test results as reference before committing your changes.
Icons support: OB Package browser now has icons for test methods in TestCase subclasses: - green circle: test has passed in the last run - red circle: test has failed - half green/half red circle: state unknown, test has no history or test has changed since last run - (no icon): test has raised an error - upside green arrow: test has progressed since last reference run - downside blue triangle: test has regressed since last reference run
A test is in progression if it goes from error or failure to passed state. A test is in regression if it goes from passed to error or failure state.
The last two icons have other meanings with methods not related to test, so we should change them whenever someone has better icons.
Authors: Alexandre Bergel, Simon Denier, David Röthlisberger
-- Simon
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Simon
which version of OB should I load to get that?
Actually, it should work with any OB loaded by the latest version, the icon support was already there.
yep, any version you can load with methods provided by ScriptLoader contain this change. David
On Nov 19, 2008, at 10:02 PM, Simon Denier wrote:
Hi all
Just to notify a new enhancement to review in the PharoInbox.
SLICE-Issue338-SUnitHistoryAndIcons-simon_denier.2
Short doc:
Add: - support history for test runs as well as progression filter to show test in progression, regression - support icons in OB to show the current state of a test: passed, failed, progressed, regressed...
History support: - whenever some test cases run from the TestRunner, their results are stored in a class side variable TestResult class>>History - contextual menu for history in TestRunner>>error pane: 1) History: access submenu to TestRunner instance history: can save and show progress between results ran in the same TestRunner; lost when this particular instance of TestRunner is closed 2) Store results as progress reference: create/update a lastStoredRun method on the class side of each TestCase which have just been run, containing the results 3) Show progress: make a diff between the last run and the lastStoredRun, showing progress or regress in tests (new passed, new failures, new errors)
The idea is that whenever you are satisfied with the current results of some of your tests, you can save this state as a reference point with the 'Store results...' action. This reference point can be compared with subsequent test results to show your progression or regression.
Test results are stored in a class side variable some are kept local to your image. Reference results are stored in a special method for each TestCase, so that they are saved with their package and can be used as a common reference for package developers. So a good practice is to store the latest test results as reference before committing your changes.
Icons support: OB Package browser now has icons for test methods in TestCase subclasses: - green circle: test has passed in the last run - red circle: test has failed - half green/half red circle: state unknown, test has no history or test has changed since last run - (no icon): test has raised an error - upside green arrow: test has progressed since last reference run - downside blue triangle: test has regressed since last reference run
A test is in progression if it goes from error or failure to passed state. A test is in regression if it goes from passed to error or failure state.
The last two icons have other meanings with methods not related to test, so we should change them whenever someone has better icons.
Authors: Alexandre Bergel, Simon Denier, David Röthlisberger
-- Simon
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Simon
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
THIS IS REALLY COOL! Now we should really have a button to execute them :) I was thinking that clicking on the icons should run the tests :) But it could be cool once we have an icon for the class tests (as discussed with samuel) to be able to trigger the tests from there. Stef On Nov 20, 2008, at 2:45 PM, David Röthlisberger wrote:
which version of OB should I load to get that? Actually, it should work with any OB loaded by the latest version, the icon support was already there.
yep, any version you can load with methods provided by ScriptLoader contain this change.
David
On Nov 19, 2008, at 10:02 PM, Simon Denier wrote:
Hi all
Just to notify a new enhancement to review in the PharoInbox.
SLICE-Issue338-SUnitHistoryAndIcons-simon_denier.2
Short doc:
Add: - support history for test runs as well as progression filter to show test in progression, regression - support icons in OB to show the current state of a test: passed, failed, progressed, regressed...
History support: - whenever some test cases run from the TestRunner, their results are stored in a class side variable TestResult class>>History - contextual menu for history in TestRunner>>error pane: 1) History: access submenu to TestRunner instance history: can save and show progress between results ran in the same TestRunner; lost when this particular instance of TestRunner is closed 2) Store results as progress reference: create/update a lastStoredRun method on the class side of each TestCase which have just been run, containing the results 3) Show progress: make a diff between the last run and the lastStoredRun, showing progress or regress in tests (new passed, new failures, new errors)
The idea is that whenever you are satisfied with the current results of some of your tests, you can save this state as a reference point with the 'Store results...' action. This reference point can be compared with subsequent test results to show your progression or regression.
Test results are stored in a class side variable some are kept local to your image. Reference results are stored in a special method for each TestCase, so that they are saved with their package and can be used as a common reference for package developers. So a good practice is to store the latest test results as reference before committing your changes.
Icons support: OB Package browser now has icons for test methods in TestCase subclasses: - green circle: test has passed in the last run - red circle: test has failed - half green/half red circle: state unknown, test has no history or test has changed since last run - (no icon): test has raised an error - upside green arrow: test has progressed since last reference run - downside blue triangle: test has regressed since last reference run
A test is in progression if it goes from error or failure to passed state. A test is in regression if it goes from passed to error or failure state.
The last two icons have other meanings with methods not related to test, so we should change them whenever someone has better icons.
Authors: Alexandre Bergel, Simon Denier, David Röthlisberger
-- Simon
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Simon _______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Now we should really have a button to execute them :) I was thinking that clicking on the icons should run the tests :)
ok, this is no problem to do. I will work on this. David
On Nov 19, 2008, at 10:02 PM, Simon Denier wrote:
Hi all
Just to notify a new enhancement to review in the PharoInbox.
SLICE-Issue338-SUnitHistoryAndIcons-simon_denier.2
Short doc:
Add: - support history for test runs as well as progression filter to show test in progression, regression - support icons in OB to show the current state of a test: passed, failed, progressed, regressed...
History support: - whenever some test cases run from the TestRunner, their results are stored in a class side variable TestResult class>>History - contextual menu for history in TestRunner>>error pane: 1) History: access submenu to TestRunner instance history: can save and show progress between results ran in the same TestRunner; lost when this particular instance of TestRunner is closed 2) Store results as progress reference: create/update a lastStoredRun method on the class side of each TestCase which have just been run, containing the results 3) Show progress: make a diff between the last run and the lastStoredRun, showing progress or regress in tests (new passed, new failures, new errors)
The idea is that whenever you are satisfied with the current results of some of your tests, you can save this state as a reference point with the 'Store results...' action. This reference point can be compared with subsequent test results to show your progression or regression.
Test results are stored in a class side variable some are kept local to your image. Reference results are stored in a special method for each TestCase, so that they are saved with their package and can be used as a common reference for package developers. So a good practice is to store the latest test results as reference before committing your changes.
Icons support: OB Package browser now has icons for test methods in TestCase subclasses: - green circle: test has passed in the last run - red circle: test has failed - half green/half red circle: state unknown, test has no history or test has changed since last run - (no icon): test has raised an error - upside green arrow: test has progressed since last reference run - downside blue triangle: test has regressed since last reference run
A test is in progression if it goes from error or failure to passed state. A test is in regression if it goes from passed to error or failure state.
The last two icons have other meanings with methods not related to test, so we should change them whenever someone has better icons.
Authors: Alexandre Bergel, Simon Denier, David Röthlisberger
--
I loaded the fix of John for the menu and the changes for SUnit icons and my image freshes when I open the Package browser and run the tests in 10162 Stef
Apparently my tests were wrong. Now I do not understand since when I run the tests the icons do not change. Stef On Nov 20, 2008, at 8:17 PM, David Röthlisberger wrote:
I loaded the fix of John for the menu and the changes for SUnit icons and my image freshes when I open the Package browser and run the tests in 10162
which tests? All tests?
David
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
this is strange that the system is asking me twice to enter my password. stef On Nov 20, 2008, at 8:45 PM, Stéphane Ducasse wrote:
Apparently my tests were wrong. Now I do not understand since when I run the tests the icons do not change.
Stef
On Nov 20, 2008, at 8:17 PM, David Röthlisberger wrote:
I loaded the fix of John for the menu and the changes for SUnit icons and my image freshes when I open the Package browser and run the tests in 10162
which tests? All tests?
David
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Now I do not understand since when I run the tests the icons do not change. Strange. So you always get the not run icon (circle with green and red)? For me this is not the case, the icons do change. Can you check whether it saved a history in the class variable of TestCase?
david
Stef
On Nov 20, 2008, at 8:17 PM, David Röthlisberger wrote:
I loaded the fix of John for the menu and the changes for SUnit icons and my image freshes when I open the Package browser and run the tests in 10162
which tests? All tests?
David
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
this is strange that the system is asking me twice to enter my password. indeed. I will check this. David
stef
On Nov 20, 2008, at 8:45 PM, Stéphane Ducasse wrote:
Apparently my tests were wrong. Now I do not understand since when I run the tests the icons do not change.
Stef
On Nov 20, 2008, at 8:17 PM, David Röthlisberger wrote:
I loaded the fix of John for the menu and the changes for SUnit icons and my image freshes when I open the Package browser and run the tests in 10162
which tests? All tests?
David
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
I have the not run green/red icons but not the green ones when the tests are run. Even if once it worked because I saw it. Stef On Nov 20, 2008, at 11:00 PM, David Röthlisberger wrote:
Now I do not understand since when I run the tests the icons do not change. Strange. So you always get the not run icon (circle with green and red)? For me this is not the case, the icons do change. Can you check whether it saved a history in the class variable of TestCase?
david
Stef
On Nov 20, 2008, at 8:17 PM, David Röthlisberger wrote:
I loaded the fix of John for the menu and the changes for SUnit icons and my image freshes when I open the Package browser and run the tests in 10162
which tests? All tests?
David
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
On 21 nov. 08, at 10:17, Stéphane Ducasse wrote:
I have the not run green/red icons but not the green ones when the tests are run. Even if once it worked because I saw it. Stef
What Stef is talking about is the ability to run tests in the browser with the cmd-t shortcut. Indeed, test status is not updated in this case. Test status are only updated when ran through the *TestRunner*. But, it makes perfect sense that running tests through the browser should update the status. I can work out something. Any hint about how it works in OB? PS: I have been bothered by the password box being asked twice too. Worse, when I load both Polymorph and my slice, if I try to move the cursor to type in my name, it produces a new box, see screenshot. Be aware.
On Nov 20, 2008, at 11:00 PM, David Röthlisberger wrote:
Now I do not understand since when I run the tests the icons do not change. Strange. So you always get the not run icon (circle with green and red)? For me this is not the case, the icons do change. Can you check whether it saved a history in the class variable of TestCase?
david
Stef
On Nov 20, 2008, at 8:17 PM, David Röthlisberger wrote:
I loaded the fix of John for the menu and the changes for SUnit icons and my image freshes when I open the Package browser and run the tests in 10162
which tests? All tests?
David
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Simon
Simon I have the impression that there is a problem related to SUnit icons improvement (since now I'm asked without defining a method to enter my name). Can you check? But may be this is not that. Tx Stef On Nov 21, 2008, at 1:24 PM, Simon Denier wrote:
On 21 nov. 08, at 10:17, Stéphane Ducasse wrote:
I have the not run green/red icons but not the green ones when the tests are run. Even if once it worked because I saw it. Stef
What Stef is talking about is the ability to run tests in the browser with the cmd-t shortcut. Indeed, test status is not updated in this case. Test status are only updated when ran through the *TestRunner*. But, it makes perfect sense that running tests through the browser should update the status.
I can work out something. Any hint about how it works in OB?
PS: I have been bothered by the password box being asked twice too. Worse, when I load both Polymorph and my slice, if I try to move the cursor to type in my name, it produces a new box, see screenshot. Be aware.
<Picture 1.png>
On Nov 20, 2008, at 11:00 PM, David Röthlisberger wrote:
Now I do not understand since when I run the tests the icons do not change. Strange. So you always get the not run icon (circle with green and red)? For me this is not the case, the icons do change. Can you check whether it saved a history in the class variable of TestCase?
david
Stef
On Nov 20, 2008, at 8:17 PM, David Röthlisberger wrote:
I loaded the fix of John for the menu and the changes for SUnit icons and my image freshes when I open the Package browser and run the tests in 10162
which tests? All tests?
David
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo- project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Simon
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
On 21 nov. 08, at 13:24, Simon Denier wrote:
On 21 nov. 08, at 10:17, Stéphane Ducasse wrote:
I have the not run green/red icons but not the green ones when the tests are run. Even if once it worked because I saw it. Stef
What Stef is talking about is the ability to run tests in the browser with the cmd-t shortcut. Indeed, test status is not updated in this case. Test status are only updated when ran through the *TestRunner*. But, it makes perfect sense that running tests through the browser should update the status.
I have a very simple small patch to run tests with history from the browser (one method send!). It works when running tests on a package, a class or category. The running behavior when a single test method runs is different, so there is a different patch, however I am not sure we want it: running only one method will erase the previous test result for the class, so you will have to run all tests again to see their result (well the same is true if you only run a protocol and there are tests in different protocols anyway, but this is a rarity) I will try to check why test classes ask for your name.
I can work out something. Any hint about how it works in OB?
PS: I have been bothered by the password box being asked twice too. Worse, when I load both Polymorph and my slice, if I try to move the cursor to type in my name, it produces a new box, see screenshot. Be aware.
<Picture 1.png>
On Nov 20, 2008, at 11:00 PM, David Röthlisberger wrote:
Now I do not understand since when I run the tests the icons do not change. Strange. So you always get the not run icon (circle with green and red)? For me this is not the case, the icons do change. Can you check whether it saved a history in the class variable of TestCase?
david
Stef
On Nov 20, 2008, at 8:17 PM, David Röthlisberger wrote:
I loaded the fix of John for the menu and the changes for SUnit icons and my image freshes when I open the Package browser and run the tests in 10162
which tests? All tests?
David
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo- project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Simon
-- Simon
thanks I will let david integrate them. On Nov 21, 2008, at 11:59 PM, Simon Denier wrote:
On 21 nov. 08, at 13:24, Simon Denier wrote:
On 21 nov. 08, at 10:17, Stéphane Ducasse wrote:
I have the not run green/red icons but not the green ones when the tests are run. Even if once it worked because I saw it. Stef
What Stef is talking about is the ability to run tests in the browser with the cmd-t shortcut. Indeed, test status is not updated in this case. Test status are only updated when ran through the *TestRunner*. But, it makes perfect sense that running tests through the browser should update the status.
I have a very simple small patch to run tests with history from the browser (one method send!). It works when running tests on a package, a class or category.
<OB-Enhancements-simon_denier.254.1.cs>
The running behavior when a single test method runs is different, so there is a different patch, however I am not sure we want it: running only one method will erase the previous test result for the class, so you will have to run all tests again to see their result (well the same is true if you only run a protocol and there are tests in different protocols anyway, but this is a rarity)
<OBCmdTestMethod.simon.denier.1.cs>
I will try to check why test classes ask for your name.
I can work out something. Any hint about how it works in OB?
PS: I have been bothered by the password box being asked twice too. Worse, when I load both Polymorph and my slice, if I try to move the cursor to type in my name, it produces a new box, see screenshot. Be aware.
<Picture 1.png>
On Nov 20, 2008, at 11:00 PM, David Röthlisberger wrote:
Now I do not understand since when I run the tests the icons do not change. Strange. So you always get the not run icon (circle with green and red)? For me this is not the case, the icons do change. Can you check whether it saved a history in the class variable of TestCase?
david
Stef
On Nov 20, 2008, at 8:17 PM, David Röthlisberger wrote:
I loaded the fix of John for the menu and the changes for SUnit icons and my image freshes when I open the Package browser and run the tests in 10162
which tests? All tests?
David
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo- project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Simon
-- Simon
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
simon, alex and others can you check why the author name is asked while it should not? This is annoying and I would like to see that fixed. Stef On Nov 19, 2008, at 10:02 PM, Simon Denier wrote:
Hi all
Just to notify a new enhancement to review in the PharoInbox.
SLICE-Issue338-SUnitHistoryAndIcons-simon_denier.2
Short doc:
Add: - support history for test runs as well as progression filter to show test in progression, regression - support icons in OB to show the current state of a test: passed, failed, progressed, regressed...
History support: - whenever some test cases run from the TestRunner, their results are stored in a class side variable TestResult class>>History - contextual menu for history in TestRunner>>error pane: 1) History: access submenu to TestRunner instance history: can save and show progress between results ran in the same TestRunner; lost when this particular instance of TestRunner is closed 2) Store results as progress reference: create/update a lastStoredRun method on the class side of each TestCase which have just been run, containing the results 3) Show progress: make a diff between the last run and the lastStoredRun, showing progress or regress in tests (new passed, new failures, new errors)
The idea is that whenever you are satisfied with the current results of some of your tests, you can save this state as a reference point with the 'Store results...' action. This reference point can be compared with subsequent test results to show your progression or regression.
Test results are stored in a class side variable some are kept local to your image. Reference results are stored in a special method for each TestCase, so that they are saved with their package and can be used as a common reference for package developers. So a good practice is to store the latest test results as reference before committing your changes.
Icons support: OB Package browser now has icons for test methods in TestCase subclasses: - green circle: test has passed in the last run - red circle: test has failed - half green/half red circle: state unknown, test has no history or test has changed since last run - (no icon): test has raised an error - upside green arrow: test has progressed since last reference run - downside blue triangle: test has regressed since last reference run
A test is in progression if it goes from error or failure to passed state. A test is in regression if it goes from passed to error or failure state.
The last two icons have other meanings with methods not related to test, so we should change them whenever someone has better icons.
Authors: Alexandre Bergel, Simon Denier, David Röthlisberger
-- Simon
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
The reason is that TestCase class >> #methodChanged: is executed each time a method is modified or compiled and it then creates for each test case class a new dictionary that stores the author name (and if not set, this will trigger the popup). This dictionary is then stored in another dictionary in a class variable... Adrian On Nov 22, 2008, at 12:43 , Stéphane Ducasse wrote:
simon, alex and others can you check why the author name is asked while it should not? This is annoying and I would like to see that fixed.
Stef
On Nov 19, 2008, at 10:02 PM, Simon Denier wrote:
Hi all
Just to notify a new enhancement to review in the PharoInbox.
SLICE-Issue338-SUnitHistoryAndIcons-simon_denier.2
Short doc:
Add: - support history for test runs as well as progression filter to show test in progression, regression - support icons in OB to show the current state of a test: passed, failed, progressed, regressed...
History support: - whenever some test cases run from the TestRunner, their results are stored in a class side variable TestResult class>>History - contextual menu for history in TestRunner>>error pane: 1) History: access submenu to TestRunner instance history: can save and show progress between results ran in the same TestRunner; lost when this particular instance of TestRunner is closed 2) Store results as progress reference: create/update a lastStoredRun method on the class side of each TestCase which have just been run, containing the results 3) Show progress: make a diff between the last run and the lastStoredRun, showing progress or regress in tests (new passed, new failures, new errors)
The idea is that whenever you are satisfied with the current results of some of your tests, you can save this state as a reference point with the 'Store results...' action. This reference point can be compared with subsequent test results to show your progression or regression.
Test results are stored in a class side variable some are kept local to your image. Reference results are stored in a special method for each TestCase, so that they are saved with their package and can be used as a common reference for package developers. So a good practice is to store the latest test results as reference before committing your changes.
Icons support: OB Package browser now has icons for test methods in TestCase subclasses: - green circle: test has passed in the last run - red circle: test has failed - half green/half red circle: state unknown, test has no history or test has changed since last run - (no icon): test has raised an error - upside green arrow: test has progressed since last reference run - downside blue triangle: test has regressed since last reference run
A test is in progression if it goes from error or failure to passed state. A test is in regression if it goes from passed to error or failure state.
The last two icons have other meanings with methods not related to test, so we should change them whenever someone has better icons.
Authors: Alexandre Bergel, Simon Denier, David Röthlisberger
-- Simon
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
ok so hat what would be the solution? Stef On Nov 22, 2008, at 1:08 PM, Adrian Lienhard wrote:
The reason is that TestCase class >> #methodChanged: is executed each time a method is modified or compiled and it then creates for each test case class a new dictionary that stores the author name (and if not set, this will trigger the popup). This dictionary is then stored in another dictionary in a class variable...
Adrian
On Nov 22, 2008, at 12:43 , Stéphane Ducasse wrote:
simon, alex and others can you check why the author name is asked while it should not? This is annoying and I would like to see that fixed.
Stef
On Nov 19, 2008, at 10:02 PM, Simon Denier wrote:
Hi all
Just to notify a new enhancement to review in the PharoInbox.
SLICE-Issue338-SUnitHistoryAndIcons-simon_denier.2
Short doc:
Add: - support history for test runs as well as progression filter to show test in progression, regression - support icons in OB to show the current state of a test: passed, failed, progressed, regressed...
History support: - whenever some test cases run from the TestRunner, their results are stored in a class side variable TestResult class>>History - contextual menu for history in TestRunner>>error pane: 1) History: access submenu to TestRunner instance history: can save and show progress between results ran in the same TestRunner; lost when this particular instance of TestRunner is closed 2) Store results as progress reference: create/update a lastStoredRun method on the class side of each TestCase which have just been run, containing the results 3) Show progress: make a diff between the last run and the lastStoredRun, showing progress or regress in tests (new passed, new failures, new errors)
The idea is that whenever you are satisfied with the current results of some of your tests, you can save this state as a reference point with the 'Store results...' action. This reference point can be compared with subsequent test results to show your progression or regression.
Test results are stored in a class side variable some are kept local to your image. Reference results are stored in a special method for each TestCase, so that they are saved with their package and can be used as a common reference for package developers. So a good practice is to store the latest test results as reference before committing your changes.
Icons support: OB Package browser now has icons for test methods in TestCase subclasses: - green circle: test has passed in the last run - red circle: test has failed - half green/half red circle: state unknown, test has no history or test has changed since last run - (no icon): test has raised an error - upside green arrow: test has progressed since last reference run - downside blue triangle: test has regressed since last reference run
A test is in progression if it goes from error or failure to passed state. A test is in regression if it goes from passed to error or failure state.
The last two icons have other meanings with methods not related to test, so we should change them whenever someone has better icons.
Authors: Alexandre Bergel, Simon Denier, David Röthlisberger
-- Simon
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
I really want to clean the author code and related but I want to focus on etoy cleaning and finish.
yes, popups in the update process should be avoided (else this will kill an automated process).
In this case the reason is that TestCase class >> #methodChanged: is executed each time a method is modified or compiled and it then creates for each test case class a new dictionary that stores the author name (and if not set, this will trigger the popup). This dictionary is then stored in another dictionary in a class variable... is this really what we want/need?
Anyway, looking at the code of Author I also noticed that we now have already _three_ ways of accessing singletons. We had the following two (which I can never remember):
SmalltalkImage current SystemNavigation default
And now also: Author uniqueInstance
may be for this one we could use the singleton internal and propose some class methods to have a better interface.
It would be nice to have some code conventions (also on the formating) and that we try to keep an eye on the quality of the code that gets introduced in the image. For example, the following method I consider a bad smell:
Author>>#initials: aString initials := aString. "Case of being reset due to, eg, copy of image." aString isEmpty ifTrue: [name := '']
It looks like a normal accessor but has a side effect on another variable under some conditions. There should be another method #reset.
This initials and name stuff were wrong in Utilities and they are wrong in authors. Stef
Adrian ___________________ http://www.adrian-lienhard.ch/
I will let david integrate them.
ok, I integrated OB-Enhancements-simon_denier.254.1.cs into OB-Enhancements-dr.254. Thanks, Simon! Concerning running of a single test method: I think it would be very useful if you could only update the results of this method without erasing the other results. I mean technically this should be possible to implement, it just a little bit complicate. Because the usability suffers a lot when all other test methods of a test case lose their results upon the run of new test method. Cheers, David
On 21 nov. 08, at 10:17, Stéphane Ducasse wrote:
I have the not run green/red icons but not the green ones when the tests are run. Even if once it worked because I saw it. Stef
What Stef is talking about is the ability to run tests in the browser with the cmd-t shortcut. Indeed, test status is not updated in this case. Test status are only updated when ran through the *TestRunner*. But, it makes perfect sense that running tests through the browser should update the status.
I have a very simple small patch to run tests with history from the browser (one method send!). It works when running tests on a package, a class or category.
<OB-Enhancements-simon_denier.254.1.cs>
The running behavior when a single test method runs is different, so there is a different patch, however I am not sure we want it: running only one method will erase the previous test result for the class, so you will have to run all tests again to see their result (well the same is true if you only run a protocol and there are tests in different protocols anyway, but this is a rarity)
<OBCmdTestMethod.simon.denier.1.cs>
I will try to check why test classes ask for your name.
I can work out something. Any hint about how it works in OB?
PS: I have been bothered by the password box being asked twice too. Worse, when I load both Polymorph and my slice, if I try to move the cursor to type in my name, it produces a new box, see screenshot. Be aware.
<Picture 1.png>
On Nov 20, 2008, at 11:00 PM, David Röthlisberger wrote:
Now I do not understand since when I run the tests the icons do not change. Strange. So you always get the not run icon (circle with green and red)? For me this is not the case, the icons do change. Can you check whether it saved a history in the class variable of TestCase?
david
Stef
On Nov 20, 2008, at 8:17 PM, David Röthlisberger wrote:
I loaded the fix of John for the menu and the changes for SUnit icons and my image freshes when I open the Package browser and run the tests in 10162
which tests? All tests?
David
alex just told me that he will look into the author problem. Stef On Nov 22, 2008, at 3:39 PM, David Röthlisberger wrote:
I will let david integrate them.
ok, I integrated OB-Enhancements-simon_denier.254.1.cs into OB- Enhancements-dr.254. Thanks, Simon!
Concerning running of a single test method: I think it would be very useful if you could only update the results of this method without erasing the other results. I mean technically this should be possible to implement, it just a little bit complicate. Because the usability suffers a lot when all other test methods of a test case lose their results upon the run of new test method.
Cheers, David
On 21 nov. 08, at 10:17, Stéphane Ducasse wrote:
I have the not run green/red icons but not the green ones when the tests are run. Even if once it worked because I saw it. Stef
What Stef is talking about is the ability to run tests in the browser with the cmd-t shortcut. Indeed, test status is not updated in this case. Test status are only updated when ran through the *TestRunner*. But, it makes perfect sense that running tests through the browser should update the status.
I have a very simple small patch to run tests with history from the browser (one method send!). It works when running tests on a package, a class or category.
<OB-Enhancements-simon_denier.254.1.cs>
The running behavior when a single test method runs is different, so there is a different patch, however I am not sure we want it: running only one method will erase the previous test result for the class, so you will have to run all tests again to see their result (well the same is true if you only run a protocol and there are tests in different protocols anyway, but this is a rarity)
<OBCmdTestMethod.simon.denier.1.cs>
I will try to check why test classes ask for your name.
I can work out something. Any hint about how it works in OB?
PS: I have been bothered by the password box being asked twice too. Worse, when I load both Polymorph and my slice, if I try to move the cursor to type in my name, it produces a new box, see screenshot. Be aware.
<Picture 1.png>
On Nov 20, 2008, at 11:00 PM, David Röthlisberger wrote:
Now I do not understand since when I run the tests the icons do not change. Strange. So you always get the not run icon (circle with green and red)? For me this is not the case, the icons do change. Can you check whether it saved a history in the class variable of TestCase?
david
Stef
On Nov 20, 2008, at 8:17 PM, David Röthlisberger wrote:
I loaded the fix of John for the menu and the changes for SUnit icons and my image freshes when I open the Package browser and run the tests in 10162
which tests? All tests?
David
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
On 22 nov. 08, at 13:08, Adrian Lienhard wrote:
The reason is that TestCase class >> #methodChanged: is executed each time a method is modified or compiled and it then creates for each test case class a new dictionary that stores the author name (and if not set, this will trigger the popup). This dictionary is then stored in another dictionary in a class variable...
Actually this is something related. Whenever you browse a TestCase class, OB scans the test history to look for previous results. If test results are not present, then an empty dictionary of results is sent back. But this dictionary is still initialized with a timestamp and the author name, so the name box can raise. Do we need the author name in test results? It's good for traceability, but too much hassle. Easy to fix anyway.
Adrian
On Nov 22, 2008, at 12:43 , Stéphane Ducasse wrote:
simon, alex and others can you check why the author name is asked while it should not? This is annoying and I would like to see that fixed.
Stef
On Nov 19, 2008, at 10:02 PM, Simon Denier wrote:
Hi all
Just to notify a new enhancement to review in the PharoInbox.
SLICE-Issue338-SUnitHistoryAndIcons-simon_denier.2
Short doc:
Add: - support history for test runs as well as progression filter to show test in progression, regression - support icons in OB to show the current state of a test: passed, failed, progressed, regressed...
History support: - whenever some test cases run from the TestRunner, their results are stored in a class side variable TestResult class>>History - contextual menu for history in TestRunner>>error pane: 1) History: access submenu to TestRunner instance history: can save and show progress between results ran in the same TestRunner; lost when this particular instance of TestRunner is closed 2) Store results as progress reference: create/update a lastStoredRun method on the class side of each TestCase which have just been run, containing the results 3) Show progress: make a diff between the last run and the lastStoredRun, showing progress or regress in tests (new passed, new failures, new errors)
The idea is that whenever you are satisfied with the current results of some of your tests, you can save this state as a reference point with the 'Store results...' action. This reference point can be compared with subsequent test results to show your progression or regression.
Test results are stored in a class side variable some are kept local to your image. Reference results are stored in a special method for each TestCase, so that they are saved with their package and can be used as a common reference for package developers. So a good practice is to store the latest test results as reference before committing your changes.
Icons support: OB Package browser now has icons for test methods in TestCase subclasses: - green circle: test has passed in the last run - red circle: test has failed - half green/half red circle: state unknown, test has no history or test has changed since last run - (no icon): test has raised an error - upside green arrow: test has progressed since last reference run - downside blue triangle: test has regressed since last reference run
A test is in progression if it goes from error or failure to passed state. A test is in regression if it goes from passed to error or failure state.
The last two icons have other meanings with methods not related to test, so we should change them whenever someone has better icons.
Authors: Alexandre Bergel, Simon Denier, David Röthlisberger
-- Simon
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Simon
Ok I see so in that case removing the authorname can be a good compromised Stef On Nov 22, 2008, at 4:02 PM, Simon Denier wrote:
On 22 nov. 08, at 13:08, Adrian Lienhard wrote:
The reason is that TestCase class >> #methodChanged: is executed each time a method is modified or compiled and it then creates for each test case class a new dictionary that stores the author name (and if not set, this will trigger the popup). This dictionary is then stored in another dictionary in a class variable...
Actually this is something related. Whenever you browse a TestCase class, OB scans the test history to look for previous results. If test results are not present, then an empty dictionary of results is sent back. But this dictionary is still initialized with a timestamp and the author name, so the name box can raise.
Do we need the author name in test results? It's good for traceability, but too much hassle. Easy to fix anyway.
Adrian
On Nov 22, 2008, at 12:43 , Stéphane Ducasse wrote:
simon, alex and others can you check why the author name is asked while it should not? This is annoying and I would like to see that fixed.
Stef
On Nov 19, 2008, at 10:02 PM, Simon Denier wrote:
Hi all
Just to notify a new enhancement to review in the PharoInbox.
SLICE-Issue338-SUnitHistoryAndIcons-simon_denier.2
Short doc:
Add: - support history for test runs as well as progression filter to show test in progression, regression - support icons in OB to show the current state of a test: passed, failed, progressed, regressed...
History support: - whenever some test cases run from the TestRunner, their results are stored in a class side variable TestResult class>>History - contextual menu for history in TestRunner>>error pane: 1) History: access submenu to TestRunner instance history: can save and show progress between results ran in the same TestRunner; lost when this particular instance of TestRunner is closed 2) Store results as progress reference: create/update a lastStoredRun method on the class side of each TestCase which have just been run, containing the results 3) Show progress: make a diff between the last run and the lastStoredRun, showing progress or regress in tests (new passed, new failures, new errors)
The idea is that whenever you are satisfied with the current results of some of your tests, you can save this state as a reference point with the 'Store results...' action. This reference point can be compared with subsequent test results to show your progression or regression.
Test results are stored in a class side variable some are kept local to your image. Reference results are stored in a special method for each TestCase, so that they are saved with their package and can be used as a common reference for package developers. So a good practice is to store the latest test results as reference before committing your changes.
Icons support: OB Package browser now has icons for test methods in TestCase subclasses: - green circle: test has passed in the last run - red circle: test has failed - half green/half red circle: state unknown, test has no history or test has changed since last run - (no icon): test has raised an error - upside green arrow: test has progressed since last reference run - downside blue triangle: test has regressed since last reference run
A test is in progression if it goes from error or failure to passed state. A test is in regression if it goes from passed to error or failure state.
The last two icons have other meanings with methods not related to test, so we should change them whenever someone has better icons.
Authors: Alexandre Bergel, Simon Denier, David Röthlisberger
-- Simon
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Simon
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
The new update in PharoInbox should deal with the previous problem: - no more author popup when browsing some TestCase - update test history after running tests from OB SLICE-Issue338-SUnitHistoryAndIcons-simon_denier.6.mcz On 22 nov. 08, at 18:33, Stéphane Ducasse wrote:
Ok I see so in that case removing the authorname can be a good compromised
Stef On Nov 22, 2008, at 4:02 PM, Simon Denier wrote:
On 22 nov. 08, at 13:08, Adrian Lienhard wrote:
The reason is that TestCase class >> #methodChanged: is executed each time a method is modified or compiled and it then creates for each test case class a new dictionary that stores the author name (and if not set, this will trigger the popup). This dictionary is then stored in another dictionary in a class variable...
Actually this is something related. Whenever you browse a TestCase class, OB scans the test history to look for previous results. If test results are not present, then an empty dictionary of results is sent back. But this dictionary is still initialized with a timestamp and the author name, so the name box can raise.
Do we need the author name in test results? It's good for traceability, but too much hassle. Easy to fix anyway.
Adrian
On Nov 22, 2008, at 12:43 , Stéphane Ducasse wrote:
simon, alex and others can you check why the author name is asked while it should not? This is annoying and I would like to see that fixed.
Stef
On Nov 19, 2008, at 10:02 PM, Simon Denier wrote:
Hi all
Just to notify a new enhancement to review in the PharoInbox.
SLICE-Issue338-SUnitHistoryAndIcons-simon_denier.2
Short doc:
Add: - support history for test runs as well as progression filter to show test in progression, regression - support icons in OB to show the current state of a test: passed, failed, progressed, regressed...
History support: - whenever some test cases run from the TestRunner, their results are stored in a class side variable TestResult class>>History - contextual menu for history in TestRunner>>error pane: 1) History: access submenu to TestRunner instance history: can save and show progress between results ran in the same TestRunner; lost when this particular instance of TestRunner is closed 2) Store results as progress reference: create/update a lastStoredRun method on the class side of each TestCase which have just been run, containing the results 3) Show progress: make a diff between the last run and the lastStoredRun, showing progress or regress in tests (new passed, new failures, new errors)
The idea is that whenever you are satisfied with the current results of some of your tests, you can save this state as a reference point with the 'Store results...' action. This reference point can be compared with subsequent test results to show your progression or regression.
Test results are stored in a class side variable some are kept local to your image. Reference results are stored in a special method for each TestCase, so that they are saved with their package and can be used as a common reference for package developers. So a good practice is to store the latest test results as reference before committing your changes.
Icons support: OB Package browser now has icons for test methods in TestCase subclasses: - green circle: test has passed in the last run - red circle: test has failed - half green/half red circle: state unknown, test has no history or test has changed since last run - (no icon): test has raised an error - upside green arrow: test has progressed since last reference run - downside blue triangle: test has regressed since last reference run
A test is in progression if it goes from error or failure to passed state. A test is in regression if it goes from passed to error or failure state.
The last two icons have other meanings with methods not related to test, so we should change them whenever someone has better icons.
Authors: Alexandre Bergel, Simon Denier, David Röthlisberger
-- Simon
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo- project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Simon
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Simon
Thanks a lot simon This is great to see that fixed and get this great icon support for our tests :) Stef On Nov 22, 2008, at 10:24 PM, Simon Denier wrote:
The new update in PharoInbox should deal with the previous problem: - no more author popup when browsing some TestCase - update test history after running tests from OB
SLICE-Issue338-SUnitHistoryAndIcons-simon_denier.6.mcz
On 22 nov. 08, at 18:33, Stéphane Ducasse wrote:
Ok I see so in that case removing the authorname can be a good compromised
Stef On Nov 22, 2008, at 4:02 PM, Simon Denier wrote:
On 22 nov. 08, at 13:08, Adrian Lienhard wrote:
The reason is that TestCase class >> #methodChanged: is executed each time a method is modified or compiled and it then creates for each test case class a new dictionary that stores the author name (and if not set, this will trigger the popup). This dictionary is then stored in another dictionary in a class variable...
Actually this is something related. Whenever you browse a TestCase class, OB scans the test history to look for previous results. If test results are not present, then an empty dictionary of results is sent back. But this dictionary is still initialized with a timestamp and the author name, so the name box can raise.
Do we need the author name in test results? It's good for traceability, but too much hassle. Easy to fix anyway.
Adrian
On Nov 22, 2008, at 12:43 , Stéphane Ducasse wrote:
simon, alex and others can you check why the author name is asked while it should not? This is annoying and I would like to see that fixed.
Stef
On Nov 19, 2008, at 10:02 PM, Simon Denier wrote:
Hi all
Just to notify a new enhancement to review in the PharoInbox.
SLICE-Issue338-SUnitHistoryAndIcons-simon_denier.2
Short doc:
Add: - support history for test runs as well as progression filter to show test in progression, regression - support icons in OB to show the current state of a test: passed, failed, progressed, regressed...
History support: - whenever some test cases run from the TestRunner, their results are stored in a class side variable TestResult class>>History - contextual menu for history in TestRunner>>error pane: 1) History: access submenu to TestRunner instance history: can save and show progress between results ran in the same TestRunner; lost when this particular instance of TestRunner is closed 2) Store results as progress reference: create/update a lastStoredRun method on the class side of each TestCase which have just been run, containing the results 3) Show progress: make a diff between the last run and the lastStoredRun, showing progress or regress in tests (new passed, new failures, new errors)
The idea is that whenever you are satisfied with the current results of some of your tests, you can save this state as a reference point with the 'Store results...' action. This reference point can be compared with subsequent test results to show your progression or regression.
Test results are stored in a class side variable some are kept local to your image. Reference results are stored in a special method for each TestCase, so that they are saved with their package and can be used as a common reference for package developers. So a good practice is to store the latest test results as reference before committing your changes.
Icons support: OB Package browser now has icons for test methods in TestCase subclasses: - green circle: test has passed in the last run - red circle: test has failed - half green/half red circle: state unknown, test has no history or test has changed since last run - (no icon): test has raised an error - upside green arrow: test has progressed since last reference run - downside blue triangle: test has regressed since last reference run
A test is in progression if it goes from error or failure to passed state. A test is in regression if it goes from passed to error or failure state.
The last two icons have other meanings with methods not related to test, so we should change them whenever someone has better icons.
Authors: Alexandre Bergel, Simon Denier, David Röthlisberger
-- Simon
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo- project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Simon
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Simon
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
David there is a OB 257 for you in the inbox.
I will let david integrate them.
ok, I integrated OB-Enhancements-simon_denier.254.1.cs into OB- Enhancements-dr.254. Thanks, Simon!
Concerning running of a single test method: I think it would be very useful if you could only update the results of this method without erasing the other results. I mean technically this should be possible to implement, it just a little bit complicate. Because the usability suffers a lot when all other test methods of a test case lose their results upon the run of new test method.
Cheers, David
Simon I harvested only the changed you did in SUnit. For the OB changes I will let david merge them in OB. Stef
David there is a OB 257 for you in the inbox.
Great, I committed this as version OB-Enhancements-dr.255 to the OB repo. David
I will let david integrate them.
ok, I integrated OB-Enhancements-simon_denier.254.1.cs into OB-Enhancements-dr.254. Thanks, Simon!
Concerning running of a single test method: I think it would be very useful if you could only update the results of this method without erasing the other results. I mean technically this should be possible to implement, it just a little bit complicate. Because the usability suffers a lot when all other test methods of a test case lose their results upon the run of new test method.
Cheers, David
Hi simon,
SLICE-Issue338-SUnitHistoryAndIcons-simon_denier.6.mcz
I loaded your file, but there is no icon in OB that show up. Sorry for last week end, I could not work as much as I wanted. Alexandre
On 22 nov. 08, at 18:33, Stéphane Ducasse wrote:
Ok I see so in that case removing the authorname can be a good compromised
Stef On Nov 22, 2008, at 4:02 PM, Simon Denier wrote:
On 22 nov. 08, at 13:08, Adrian Lienhard wrote:
The reason is that TestCase class >> #methodChanged: is executed each time a method is modified or compiled and it then creates for each test case class a new dictionary that stores the author name (and if not set, this will trigger the popup). This dictionary is then stored in another dictionary in a class variable...
Actually this is something related. Whenever you browse a TestCase class, OB scans the test history to look for previous results. If test results are not present, then an empty dictionary of results is sent back. But this dictionary is still initialized with a timestamp and the author name, so the name box can raise.
Do we need the author name in test results? It's good for traceability, but too much hassle. Easy to fix anyway.
Adrian
On Nov 22, 2008, at 12:43 , Stéphane Ducasse wrote:
simon, alex and others can you check why the author name is asked while it should not? This is annoying and I would like to see that fixed.
Stef
On Nov 19, 2008, at 10:02 PM, Simon Denier wrote:
Hi all
Just to notify a new enhancement to review in the PharoInbox.
SLICE-Issue338-SUnitHistoryAndIcons-simon_denier.2
Short doc:
Add: - support history for test runs as well as progression filter to show test in progression, regression - support icons in OB to show the current state of a test: passed, failed, progressed, regressed...
History support: - whenever some test cases run from the TestRunner, their results are stored in a class side variable TestResult class>>History - contextual menu for history in TestRunner>>error pane: 1) History: access submenu to TestRunner instance history: can save and show progress between results ran in the same TestRunner; lost when this particular instance of TestRunner is closed 2) Store results as progress reference: create/update a lastStoredRun method on the class side of each TestCase which have just been run, containing the results 3) Show progress: make a diff between the last run and the lastStoredRun, showing progress or regress in tests (new passed, new failures, new errors)
The idea is that whenever you are satisfied with the current results of some of your tests, you can save this state as a reference point with the 'Store results...' action. This reference point can be compared with subsequent test results to show your progression or regression.
Test results are stored in a class side variable some are kept local to your image. Reference results are stored in a special method for each TestCase, so that they are saved with their package and can be used as a common reference for package developers. So a good practice is to store the latest test results as reference before committing your changes.
Icons support: OB Package browser now has icons for test methods in TestCase subclasses: - green circle: test has passed in the last run - red circle: test has failed - half green/half red circle: state unknown, test has no history or test has changed since last run - (no icon): test has raised an error - upside green arrow: test has progressed since last reference run - downside blue triangle: test has regressed since last reference run
A test is in progression if it goes from error or failure to passed state. A test is in regression if it goes from passed to error or failure state.
The last two icons have other meanings with methods not related to test, so we should change them whenever someone has better icons.
Authors: Alexandre Bergel, Simon Denier, David Röthlisberger
-- Simon
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo- project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Simon
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Simon
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
Oups, it works now. Forgot to update OB from wiresong. I thought that loadOBalpha would have taken care of it. Cheers, Alexandre On 22 Nov 2008, at 18:24, Simon Denier wrote:
The new update in PharoInbox should deal with the previous problem: - no more author popup when browsing some TestCase - update test history after running tests from OB
SLICE-Issue338-SUnitHistoryAndIcons-simon_denier.6.mcz
On 22 nov. 08, at 18:33, Stéphane Ducasse wrote:
Ok I see so in that case removing the authorname can be a good compromised
Stef On Nov 22, 2008, at 4:02 PM, Simon Denier wrote:
On 22 nov. 08, at 13:08, Adrian Lienhard wrote:
The reason is that TestCase class >> #methodChanged: is executed each time a method is modified or compiled and it then creates for each test case class a new dictionary that stores the author name (and if not set, this will trigger the popup). This dictionary is then stored in another dictionary in a class variable...
Actually this is something related. Whenever you browse a TestCase class, OB scans the test history to look for previous results. If test results are not present, then an empty dictionary of results is sent back. But this dictionary is still initialized with a timestamp and the author name, so the name box can raise.
Do we need the author name in test results? It's good for traceability, but too much hassle. Easy to fix anyway.
Adrian
On Nov 22, 2008, at 12:43 , Stéphane Ducasse wrote:
simon, alex and others can you check why the author name is asked while it should not? This is annoying and I would like to see that fixed.
Stef
On Nov 19, 2008, at 10:02 PM, Simon Denier wrote:
Hi all
Just to notify a new enhancement to review in the PharoInbox.
SLICE-Issue338-SUnitHistoryAndIcons-simon_denier.2
Short doc:
Add: - support history for test runs as well as progression filter to show test in progression, regression - support icons in OB to show the current state of a test: passed, failed, progressed, regressed...
History support: - whenever some test cases run from the TestRunner, their results are stored in a class side variable TestResult class>>History - contextual menu for history in TestRunner>>error pane: 1) History: access submenu to TestRunner instance history: can save and show progress between results ran in the same TestRunner; lost when this particular instance of TestRunner is closed 2) Store results as progress reference: create/update a lastStoredRun method on the class side of each TestCase which have just been run, containing the results 3) Show progress: make a diff between the last run and the lastStoredRun, showing progress or regress in tests (new passed, new failures, new errors)
The idea is that whenever you are satisfied with the current results of some of your tests, you can save this state as a reference point with the 'Store results...' action. This reference point can be compared with subsequent test results to show your progression or regression.
Test results are stored in a class side variable some are kept local to your image. Reference results are stored in a special method for each TestCase, so that they are saved with their package and can be used as a common reference for package developers. So a good practice is to store the latest test results as reference before committing your changes.
Icons support: OB Package browser now has icons for test methods in TestCase subclasses: - green circle: test has passed in the last run - red circle: test has failed - half green/half red circle: state unknown, test has no history or test has changed since last run - (no icon): test has raised an error - upside green arrow: test has progressed since last reference run - downside blue triangle: test has regressed since last reference run
A test is in progression if it goes from error or failure to passed state. A test is in regression if it goes from passed to error or failure state.
The last two icons have other meanings with methods not related to test, so we should change them whenever someone has better icons.
Authors: Alexandre Bergel, Simon Denier, David Röthlisberger
-- Simon
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo- project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Simon
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Simon
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
participants (5)
-
Adrian Lienhard -
Alexandre Bergel -
David Röthlisberger -
Simon Denier -
Stéphane Ducasse