[Pharo-project] In the way of cleaning etoy
Hi guys I'm working on removing etoy. I'm stuck with some methods I checked the references to Player restoreClassInstVars: is for example one of them. Now I would like to know what do you think of project. I think that we should remove it as well as bookmorph but I would like to know what do you think. Stef
I have an image that I ripped bookmorph out of, you want it? I ripped quite a few morphic classes out, plus removed quite a few "test" methods that lurk on the class side of various classes. BookMorph subclasses are StackMorph (which is easy to dispose of, and TabbedPalette which is harder because that's used by the the PreferenceBrower logic I dropped the Preference Browser logic so I didn't chase where PreferencePanel was used. Still there were a few methods that needed updating, perhaps thing to make this a bit easier is if someone could review usage if isKindOf: and change that to tests like isBookMorph, etc Also stuff test methods and Sunit tests into a seperate MC package that you can choose to unload if you want. On 30-Jan-09, at 12:59 PM, Stéphane Ducasse wrote:
Hi guys
I'm working on removing etoy.
I'm stuck with some methods I checked the references to Player restoreClassInstVars: is for example one of them.
Now I would like to know what do you think of project. I think that we should remove it as well as bookmorph but I would like to know what do you think.
-- = = = ======================================================================== John M. McIntosh <johnmci@smalltalkconsulting.com> Corporate Smalltalk Consulting Ltd. http://www.smalltalkconsulting.com = = = ========================================================================
Do you have cs or a MC package? Because I think that I would have to redo it following what you did because of possible conficts. So the main message is Yes let us rip out BookMorph which sounds the right things to do.
I have an image that I ripped bookmorph out of, you want it? I ripped quite a few morphic classes out, plus removed quite a few "test" methods that lurk on the class side of various classes.
BookMorph subclasses are StackMorph (which is easy to dispose of, and TabbedPalette which is harder because that's used by the the PreferenceBrower logic
You mean the old one or the new one?
I dropped the Preference Browser logic so I didn't chase where PreferencePanel was used.
Still there were a few methods that needed updating, perhaps thing to make this a bit easier is if someone could review usage if isKindOf: and change that to tests like isBookMorph, etc
Also stuff test methods and Sunit tests into a seperate MC package that you can choose to unload if you want.
On 30-Jan-09, at 12:59 PM, Stéphane Ducasse wrote:
Hi guys
I'm working on removing etoy.
I'm stuck with some methods I checked the references to Player restoreClassInstVars: is for example one of them.
Now I would like to know what do you think of project. I think that we should remove it as well as bookmorph but I would like to know what do you think.
-- = = = = = ====================================================================== John M. McIntosh <johnmci@smalltalkconsulting.com> Corporate Smalltalk Consulting Ltd. http:// www.smalltalkconsulting.com = = = = = ======================================================================
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
participants (2)
-
John M McIntosh -
Stéphane Ducasse