On Fri, Mar 3, 2017 at 1:55 AM, Ben Coman <btc@openinworld.com> wrote:


On Tue, Feb 28, 2017 at 7:04 AM, Martin Dias <tinchodias@gmail.com> wrote:

Stef: I see... each line should have a checkbox. I remember to see in Spec's FastTableModel a method to enable that... I will try.

Ben: I think that's not necessary because the EpLostChangesDetector already opens a browser where only the "lost changes" are visible. Where "lost changes" means everything logged by Epicea after last Image Save.��

I paid particular attention this time to starting after a crash and one thing I'm uncertain about.
Its good that the window says "Lost Changes Detected"
but its not clear the meaning at the bottom where it says "22 filtered entries"
Does this mean these 22 entries were not lost?
Or is it some other reason?
Also, I've a (only mild) concern that I can't see what these other entries are, since I don't know if they are important?��


Hi! you are the first one that mentions this "x filtered entries". Yes, "filtered" like "hidden by a filter".��

Casually, I've worked on its removal. Reasons: implementation is ugly; it difficults time optimizations; it's not standard visually (I suspected nobody undertand it). I'm also removing the "See 50 more" button, which makes the list of changes look more as a standard list, to the user eyes. I'm preparing a new release with these changes, and replacing the TreeModel by a FastTableModel which is much better to scroll on the changes freely.
��
Can you make it more explicit what the filter is?
Oh, after a while I realise there is a tab for this.
Perhaps at the bottom of the changes list
you could say �� "22 filtered entries (see Active Filters tab)"
to help slow people like me.

For the moment, I only added the number of applied filters in the Tab's title, like "Active filters (2)".


So if 'remove all filters", what is the easy way to return to��
the identical previous "Lost Changes" filter.
I realise now that I've been missing the old "indication of save points" ��

The "save points" were deactivated as a workaround the this bug:

https://pharo.fogbugz.com/f/cases/18374/

If we fix this case in another way, then we can restore the logging of image save points (EpSessionSnapshot event).

Cheers
Mart��n

Then I guess I'd be able to select that line and filter "afterwards"

cheers -ben