- Create a slice (group of packages):
- Open the Monticello Browser.
- Open the Slice Maker by clicking the "Slice" button.
- In Slice Maker enter the Fogbugz issue number and "grab" the issue summary.
- Select the dirty packages relevant to your bug fix. Dirty packages are prefixed by a start and are sorted to the top of the list of packages.
- Verify your changes (click on changes button)
- Select the Pharo60 repository
- Select your slice
- Press changes in the Monticello Browser and verify that your changes are the correct one.
- Publish the slice to Pharo50Inbox:
- Select the whole slice (not it's individual packages).
- Select the SmalltalkHub Pharo Inbox repository.
- Press the "Save" button to commit your slice to the inbox repository
- Verify that your fix loads: take a fresh image and load the slice you published.
- Update the bug entry to mention that you submitted a slice in the inbox.
- In Fogzbugz, click on "Resolve" to Change the state of the issue to "Resolved: Fix Review Needed" and ensure that the milestone is set to the next release of Pharo.
- Now you can feel good!
Too many steps. Why is there still no integration with FogBugz? Then there's the dubiousdescign decision of making a slice a selection of dirty packages instead of a selection of changes (what if I work on two things at once and they touch the same package? => two Images).
How old is the slice process and there's no integration with fogbugz, shifting between tools. When is iceberg going to be better integrated than the slice process?
On 15 Jun 2017, at 15:40, Guillermo Polito <guillermopolito@gmail.com> wrote:Thanks pavel, I'll copy paste it in the README :)I will not copy and paste all that in the README. It will not remain...cheers,EstebanOn Thu, Jun 15, 2017 at 10:43 AM, Rajula Vineet <Vineet.Reddy@iiitb.org> wrote:@abergel I was looking for some basic guidelines for example: creating a new
branch with the issue name, having the issue number and name while
submitting a PR. Something like this.
@Subbu I have forked it, but I haven`t made a new branch I will do it.
Thanks for the tips.
@Pavel Thank you very much. This is what I was looking out for.
Rajula
--
View this message in context: http://forum.world.st/Doing-a-pull-request- tp4951443p4951485.html
--
