Le 21/05/2017 �� 05:12, Ben Coman a ��crit :

Is this of concern for Pharo...?�� "Pull requests on GitHub where the
Trait comments get removed (because they were not loaded with the
package in the first place)."

http://forum.world.st/Re-The-Inbox-System-jr-919-mcz-td4941798.html#none

http://forum.world.st/The-Inbox-System-jr-919-mcz-td4933985.html

cheers -ben

On Sun, May 21, 2017 at 5:12 PM, Thierry Goubier <thierry.goubier@gmail.com> wrote:

Hi Ben,

There is two Traits tests in the FileTree repository, and they pass (both under filetree and under gitfiletree) even if I notice that you can load the test package fine, but you get a DNU when browsing that package from the test repository inspector.

The tests classes are MCFileTreeLoaderTraitsTest and MCGitFileTreeLoaderTraitsTest, and the test repository is at: https://github.com/dalehenrich/filetree/tree/pharo5.0/tests/testRepositories/traits.

Would you be interested in checking if the Squeak bug applies, adding an additional test to confirm or infirm with a pull request?

I guess I could if no one else picks it up, but I don't think I'm best placed to do it. I've never used FileTree nor Traits, so I'm not sure where to look for the Trait's comment (is this just a class comment on a subclass of Trait) - and given the move to Iceberg/Git, I'm not sure the FileTree/Git��learning��curve is worth it for me.�� I was hoping someone familiar with both or one of them could at least confirm the problem first.

cheers -ben��