Ok, I write the changeset, but I don't like it hehehehe.

What about puting isMacintosh, isUnix and isWindows in SmalltalkImage ?
I think those methods are useful and perhaps many people in different packages are doing things like this:
��� ^SmalltalkImage current platformName� = 'Mac OS'

This is not nice. Tomorrow we change the platformName and we have to modify a lot of code.

For example, I searched the string "SmalltalkImage current platformName = 'Mac OS'" and it is in a lot of places. I think we should get rid of them.

what do you think?

best,

Mariano



On Tue, Jul 28, 2009 at 3:18 PM, Adrian Lienhard <adi@netstyle.ch> wrote:
Yes, if you tested it and think it is good, please change the status
to verified.

Cheers,
Adrian

On Jul 28, 2009, at 17:12 , Miguel Cob� wrote:

> should the ticket be marked as verified?
>
>
> On Tue, Jul 28, 2009 at 10:10 AM, Miguel Cob�<miguel.coba@gmail.com>
> wrote:
>> It works ok on my
>>
>> Debian Linux 5.0 (Lenny) i386.
>> Debian Linux 5.0 (Lenny) amd64.
>>
>> Miguel Cob�
>>
>> 2009/7/28 Mariano Martinez Peck <marianopeck@gmail.com>:
>>>
>>>
>>> On Tue, Jul 28, 2009 at 11:58 AM, Adrian Lienhard
>>> <adi@netstyle.ch> wrote:
>>>>
>>>> On Jul 28, 2009, at 14:51 , Mariano Martinez Peck wrote:
>>>>
>>>>> On Tue, Jul 28, 2009 at 5:42 AM, Damien Cassou <damien.cassou@gmail.com
>>>>>> wrote:
>>>>>
>>>>>> 2009/7/27 Mariano Martinez Peck <marianopeck@gmail.com>:
>>>>>>> HostSystemMenusTest class>>expectedFailures
>>>>>>>
>>>>>>> SmalltalkImage current platformName = 'Mac OS' ifFalse:[
>>>>>>> � � ^#(#testXXX #testYYY)].
>>>>>>> ].
>>>>>>> ^#()
>>>>>>
>>>>>> Expected failures are indications of bugs that are not yet
>>>>>> corrected.
>>>>>> Does not seem to apply here.
>>>>>
>>>>>
>>>>> ahhh okok. So...shall we go for torsten solution ?
>>>>
>>>> Yes.
>>>
>>> http://code.google.com/p/pharo/issues/detail?id=996
>>>
>>> I also attached a possible changeset.
>>>
>>> best,
>>>
>>> Mariano
>>>
>>>>
>>>> Adrian
>>>>
>>>>
>>>>>
>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Damien Cassou
>>>>>> http://damiencassou.seasidehosting.st
>>>>>>
>>>>>> "Lambdas are relegated to relative obscurity until Java makes
>>>>>> them
>>>>>> popular by not having them." James Iry
>>>>>>
>>>>>> _______________________________________________
>>>>>> Pharo-project mailing list
>>>>>> Pharo-project@lists.gforge.inria.fr
>>>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>>>>>
>>>>> _______________________________________________
>>>>> Pharo-project mailing list
>>>>> Pharo-project@lists.gforge.inria.fr
>>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-
>>>>> project
>>>>
>>>>
>>>> _______________________________________________
>>>> Pharo-project mailing list
>>>> Pharo-project@lists.gforge.inria.fr
>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>>
>>>
>>> _______________________________________________
>>> Pharo-project mailing list
>>> Pharo-project@lists.gforge.inria.fr
>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>>
>>
>
> _______________________________________________
> Pharo-project mailing list
> Pharo-project@lists.gforge.inria.fr
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
Pharo-project@lists.gforge.inria.fr
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project