On 13 April 2018 at 23:15, Alistair Grant <akgrant0710@gmail.com> wrote:
On 13 April 2018 at 17:07, Cyril Ferlicot <cyril.ferlicot@gmail.com> wrote:
>
>
> On ven. 13 avr. 2018 at 17:03, Guillermo Polito <guillermopolito@gmail.com> wrote:
>>
>>
>> The thing is that the best way to do it is to clone your own fork... And each one has her/his one.

I know, but momentarily forgot while trying to work on my first Issue with the new UI.
However I discovered something cool...

I had directly cloned "git@github.com:pharo-project/pharo.git"
successfully brought that "Up to date"
then in the "Working copy of pharo" window, clicked <New Issue> and filled in details,
made my code change,
then clicked <Commit>
then clicked <Push> bringing me to a window titled "Push pharo/21686-.../21686..."
where the only option to "Push to remote: " was�� "origin (git@github.com:pharo-project/pharo.git)"
and clicking <Push> of course produced an error "LGit_GIT_EEOF: ERROR: Permission to pharo-project/pharo.git denied to bencoman."
Fair enough!

But then...!!!
Back in the "Repositories" window,
"pharo" > right-click > Repository > Add Remote
�� ��Remote name = bencoman
�� ��Remote URL =��git@github.com:pharo-project/pharo.git
And back in the��"Working copy of pharo" window
clicked <Push>�� bringing again me to a window titled "Push pharo/21686-.../21686..."
but now I had an extra option "bencoman <git@github.com:bencoman/pharo.git>"
and selecting that and clicking�� <Push> worked!!!!

https://github.com/bencoman/pharo/tree/21686-Setting-background-images-doesnt-work-on-Pharo-70

Now the key thing here is that I **didn't** have to��first��
synchronise�� github.com:bencoman/pharo.git�� with�� github.com:pharo-project/pharo.git
and remember to clone�� github.com: bencoman/pharo.git .
I just pushed to my repo **after-the-fact**.

I haven't submitted many fixes lately to get familiar with Iceberg,
and maybe I missed something in the old workflow,��
but previously it seemed that my pharo github repo needed to be up to date,��
and I must clone from there.

The new UI is intuitive and made it east to clone from pharo-project, make fix the push to bencoman.
I worked this out from just a small bit of trial & error.


One request...
In attached snapshot��where the remotes show "origin",��
please consider showing that as "pharo-project"
The term "origin" is useful for generic documentation and for examples,
but there is *nothing* special about that label from a git perspective.
A remote is a remote is a remote.

Since mostly pharo development workflow will follow a triangle,��
from remote pharo-project repo, to remote personal repo, PR to remote pharo-project repo,
it would be more useful conceptually��
to have the pharo-project remote labelled "pharo-project" rather than labelled "origin".

cheers -ben

��
>>
>
>
> What your can do is display the list of forks and ask to select the right one. Then it will create the Pharo repo with the two remotes.


I was going to suggest prompting for the git username.�� You can
substitute it in to:

git@github.com:{username}/pharo.git

and add upstream (pharo-project).


Cheers,
Alistair