On Jan 6, 2016, at 3:13 PM, Nicolas Cellier <nicolas.cellier.aka.nice@gmail.com> wrote:

Hi,

I wish the commits were much more atomic than they currently are...

With current practice, reviewing the changes is near to impossible:

- it requires far too much concentration

- it's just impossible through github web interface

For example, I did wander if the structure fields were correclty aligned in:
https://github.com/pharo-project/pharo-core/blame/5986a695fb28834247a90dbf85c0d1e02a54b6fc/FFI-NB.package/FFIExternalStructure.class/class/private/compileFields_withAccessors_.st#L9

because I see no code for aligning the offsets...

But I cannot even navigate in the history... If I do so,
https://github.com/pharo-project/pharo-core/commit/dfd4f3ae0f0b0af7766c1405a3affa3f890ce51a

the page tells me
"Sorry, we could not display the entire diff because too many files (2,121) changed"

and I couldn't find a way of displaying the portion of interest.

I thus loose the ability to deposit a comment.

I can still open a fresh Pharo image and browse and review the whole code snapshot there.

Or I can navigate more easily in history with git tools.
But if I wanted a lightweight review thru web, focusing on the diffs and navigating a bit in history without replicating the repository, I can't.

While ranting, it's nice to have the commits performed by a jenkins server, but how do we track the authors of original modifications?

In a normal git based development, there would be feature branches integrated/merged in trunk/master by whatever process.

But in current process i fail to capture such information...

This gives a taste of under-powered use of the tools, and I wander if being visible in these conditions is a good thing: we don't expose the best practices.