On Sun, Jan 10, 2010 at 11:34 AM, Adrian Lienhard
<adi@netstyle.ch> wrote:
On Jan 9, 2010, at 22:32 , Mariano Martinez Peck wrote:
> Thanks Benoit for the report and taking the time to run all the
> tests. I
> already knew that there are a lot failing tests. Unfortunately,
> there is not
> too much I can do:
>
> 1) Maintainers of packages with failures can tell me if they are
> failing for
> "my fault". I mean, �because I don't load a dependency or something
> like
> that. And if this is the case, I can fix that.
>
> 2) I can remove all the packages that have failing tests -> I think
> we will
> load very few packages.
>
> 3) We should ask maintainers to fix them. Of course, there are
> packages that
> even don't have maintainers.
>
> thoughts about this ?
Some time ago I individually talked with each maintainer and
eventually we managed to get all tests pass. That was with the
previous build of the Pharo image that Damien did. Now, I don't know
which additional tests you have loaded (?) but either these need to be
fixed or we should not load them. We want all tests to be green for
the release.
Adrian: Most of the failing tests are from OB. Someone said Lukas made all those tests green, but they are commited in his repo. Someone should merge that with the wiresong repo. If no one merge that, I don't know what to do: or remove them or keep them.
The only 3 tests no related with OB that are failing are:
ObjectFinalizerTests >> testFinalizationOfEquals
This one is failure, but running it again, it is green. Any idea?
ReleaseTest >> testUndeclared
failes.
WeakSetInspectorTest >> testSymbolTableM6812
Related to NewInspector. I cc Frederic.
Cheers
Mariano
�
Cheers,
Adrian