Hi again,

I added a first shot at theming. The idea is simple:

- we have one method in UITheme called spotterThemer that simply returns a SpotterThemer, and

- all Spotter/Spotlight specific rendering methods are in SpotterThemer

I think this should be the design to follow for all morphs. I blogged about it in more details here:

http://www.humane-assessment.com/blog/a-pharo-refactoring-story-adding-theme-ability-to-a-morph/

You can get the code from here:

Gofer new 

smalltalkhubUser: 'girba' project: 'GPlay';

package: 'Spotlight';

disablePackageCache;

load

In summary, something like:

SpotlightItemMorph>>onSelected

self color: (Color r: 0.2627 g: 0.4588 b: 0.9333).

becomes:

SpotlightItemMorph>>onSelected

self theme spotterThemer configureSelectedItemMorph: self

And the default SpotterThemer says:

SpotterThemer>>configureSelectedItemMorph: aMorph

     aMorph color: (Color r: 0.2627 g: 0.4588 b: 0.9333)

What do you think?

Cheers,

Doru

On Sun, Jan 5, 2014 at 9:26 AM, Tudor Girba <tudor@tudorgirba.com> wrote:

Hi Sean,

I just tested it. It works just great.

First, would it be Ok with you to move the project to a more public place (like http://www.smalltalkhub.com/#!/~PharoExtras) so that others can contribute easier?

Second, I created a configuration with a development and stable version. You can find it here:

Gofer new 

smalltalkhubUser: 'girba' project: 'GPlay';

package: 'ConfigurationOfSpotter';

load.

(Smalltalk globals at: #ConfigurationOfSpotter)

loadStable

And in the MetaRepoForPharo30 so that you can load it from the Configuration Browser. Please note that I named the configuration Spotter, because there already exists a ConfigurationOfSpotlight for the widget of Esteban. Would it be Ok to change the name of the classes, too, to avoid confusion?

Third, I think we should not mix the morph with the global shortcut. I understand this is convenient, but these should pretty much be different projects. Is that Ok with you?

Fourth, I would like to theme this morph, too :). With this occasion, I would like to try a slightly different design for handling the theme code. I will follow up on this in another mail.

Doru

On Sat, Jan 4, 2014 at 5:42 PM, Sean P. DeNigris <sean@clipperadams.com> wrote:

I'm happy for now. As a general purpose completion option, I'd say we're
officially at version 1.0. No obvious bugs, and provides the basic features
I'd want.

As for replacing the existing Spotlight, I've decided to eat my own dog food
and use the new tool in my images:
  *** n.b., if you load the Spotlight package now, it will override the
global Spotlight shortcut

p.s. Steph, I added packages to the example for you ;) �
<http://forum.world.st/file/n4734153/Screen_Shot_2014-01-04_at_11.18.57_AM.png>



-----
Cheers,
Sean
--
View this message in context: http://forum.world.st/Spotlight-Demo-tp4733076p4734153.html

Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

--

www.tudorgirba.com

"Every thing has its own flow"

--

www.tudorgirba.com

"Every thing has its own flow"