Hi,

On Thu, Apr 9, 2015 at 12:31 PM, Nicolai Hess <nicolaihess@web.de> wrote:

2015-04-09 11:53 GMT+02:00 Tudor Girba <tudor@tudorgirba.com>:

Hi,

On Thu, Apr 9, 2015 at 11:44 AM, Nicolai Hess <nicolaihess@web.de> wrote:

2015-04-09 11:36 GMT+02:00 Tudor Girba <tudor@tudorgirba.com>:

Hi,

On Thu, Apr 9, 2015 at 11:31 AM, Nicolai Hess <nicolaihess@web.de> wrote:

2015-04-09 8:48 GMT+02:00 Tudor Girba <tudor@tudorgirba.com>:

I would not do that. I think that removing the example pragma check is sufficient for now. Could we do it?

Sufficient for what?

You said to add the extra check saying "��*AND HAS NOT* a <example> (or <gtExample>) pragma "

and I said that it is sufficient to just remove the pragma check for the Pharo 4 release :).

No, I don't think this is enough. There are so many #exampleXXX method from GT in the Pharo4 image

and most of them don't work with nautilus play-icon for #exampleXXX methods

They don't do anything harmful either.

No? We have now methods with the play icon that opens some window/widget/... (The old examples)

And we have now many new example methods with this play icon that just do nothing (visible).

I find this distracting.

��

But, you can also add the check as you suggest.

Well, I don't like this solution.
We would define a method to be an "example method" if it is *not* tagged with <example> pragma.

This is confusing too.

Yes, that is why I said that we should not add that check :)

��

Possible solutions:

- remove the "run this example" play icon from nautilus, because with all the new exampleXXX methods from GT

it is useless for ~half of all the methods.

- rename the example methods from GT to something else, so it does not interfere with nautilus

Ok. We will rename the #example* methods from GT to gtExample* before the release.

��

- change the isExampleMethod check to *only* check for some <OnWhatEverExamplePragmaWeAgree>�� and

�� tag all old (spec/widget/UI) example methods with this pragma.

I wish to have no pragma in isExampleMethod for Pharo 4. We can talk about it afterwards.

But, we still need a pharo issue. Could you create one? :)

Cheers,

Doru

For Pharo 4.0 I think we have to live with this mess and clean it up for the next release.

��

��

��

��

I think there is no problem if we remove the pragma check. Because only very few (if any)

example methods (those that really open an example) relies only on the pragma, without having a #exampleXXX name too.

Exactly.

��

I just think this would not change much.
We need to clean up the mess with the #example* methods.

Thanks.

Can you produce the issue and slice?

For what, removing the example check or renaming all #example* methods that don't open an example?

For removing the example check.

Cheers,

Doru

��

��

@Torsten: are you fine with this?

Doru

��

��

Cheers,

Doru

On Wed, Apr 8, 2015 at 5:16 PM, Nicolai Hess <nicolaihess@web.de> wrote:

2015-04-08 10:20 GMT+02:00 Tudor Girba <tudor@tudorgirba.com>:

And, to have a better chance of having a clean slate discussion later on in which to consider the value we associate to names, I would like to remove the <example> check from isExampleMethod and continue to preserve the treatment of #example* selectors in Nautilus.

Wouldn't we need to change the check to:

isExampleMethod
���� if selector starts with 'example' *AND HAS NOT* a <example> (or <gtExample>) pragma

because there are tons of #example* methods, some of them open an example and some of them with the pragma, create an instance for the inspector?

��

--

www.tudorgirba.com

"Every thing has its own flow"

--

www.tudorgirba.com

"Every thing has its own flow"

--

www.tudorgirba.com

"Every thing has its own flow"

--

www.tudorgirba.com

"Every thing has its own flow"