what if you want to have side by side two different themes to compare the best icons
choices?

This is a valid concern, but I do not understand how this would work if the only thing you pass in iconName: is just one symbol:

act: aBlock iconName: aSymbol entitled: aString

So there needs to be a lookup. This lookup will depend on the current icon theme. So, you could open on window with one theme, switch the theme and then open another window. Or did I misunderstand something?

The idea is that all the tools: should have an iconProvider and not a global lookup (even if the lookup can access a global)

My idea was that we leave the public API of Glamour to be:

act: aBlock icon: aSymbolOrForm��entitled: aString

and then if you want to play with things, you can also explicitly pass one icon or another (beside relying on the default lookup behavior).

What do you think?
������ I would like to avoid clients to use Symbol >> asIcon it can be an internal implementation.


Doru



In this way we do not have to change the external interface, and only the internal��implementation has to send an ���asIcon��� before using it?

Cheers,
Doru



On Oct 12, 2016, at 10:33 PM, stepharo <stepharo@free.fr> wrote:

I'm adding

act: aBlock iconName: aSymbol entitled: aString
�� ��self act: aBlock icon: (self iconNamed: aSymbol) entitled: aString

and

act: aBlock iconName: aSymbol on: aCharacter entitled: aString
�� ��self act: aBlock icon: (self iconNamed: aSymbol) on: aCharacter entitled: aString

and others ....

--
www.tudorgirba.com
www.feenk.com

"Every thing has its own flow."










--
www.tudorgirba.com
www.feenk.com

"We are all great at making mistakes."