2015-02-19 11:11 GMT+01:00 Sven Van Caekenberghe <sven@stfx.eu>:

> On 19 Feb 2015, at 03:15, Sean P. DeNigris <sean@clipperadams.com> wrote:
>
> Fix in inbox:
> SLICE-Issue-14959-MC-Hook-for-Default-Credentials-SeanDeNigris.1
>
> When creating a repo in the MC Browser, it would be great to pre-populate
> the user and password fields.
>
> Thus, we declare a CredentialSource role collaborating with MCHttpRepository
> and subclasses. The in-kernel default is a no-op Null object, but users can
> install (via MCHttpRepository class>>#credentialSource:) any object that
> responds to #defaultUserFor: and #defaultPasswordFor:
>
> I'd like to apply this to Gofer, too, but I found a big switch statement in
> ZnUrl>>#mcRepositoryAsUser:withPassword: and now my head hurts ;)

Yes, that is not good (ahem).

We should let the root, MCRepository, decide, probably doing a lookup through its subclasses. All subclasses should also uniformly take credentials.

Yes! I want an end to that big switch !

(I had to write an override to that to get gitfiletree:// urls to work, as well as two or three other spots in Zn where known url protocols are hardcoded).

Thierry

�

> Anyway maybe this will spur discussion...
>
>
>
> -----
> Cheers,
> Sean
> --
> View this message in context: http://forum.world.st/FIX-Maybe-Issue-14959-MC-Hook-for-Default-Credentials-tp4806424.html
> Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
>