��
On Tue, May 07, 2019 at 03:36:32PM -0700, Eliot Miranda wrote:
> In VMMaker.oscog-GAP.2533 I would prefer to see printString instead of
> asString.�� asString is a horrible hack.�� printString says what we mean.
Sure. I've submitted another version to the inbox:
Name: VMMaker.oscog-GAP.2534
Author: GAP
Time: 9 May 2019, 5:12:22.055089 pm
UUID: cd6aae16-6f20-4ddb-9328-64b19b413cb1
Ancestors: VMMaker.oscog-eem.2532
Convert numeric constants to strings for concatenation using #printString.
Required for Pharo compatibility, where the arguments of concatenation are not automatically coerced to strings.
��
> ==== Patch 1 ====
> > Name: VMMaker.oscog-GAP.2533
> > Author: GAP
> > Time: 7 May 2019, 10:57:16.034354 am
> > UUID: 3209319f-60f3-4586-8d03-cfac3c9fddee
> > Ancestors: VMMaker.oscog-eem.2532
> >
> > Convert numeric constants to strings for concatenation.
> > Required for Pharo compatibility, where the arguments of concatenation are
> > not automatically coerced to strings.
> >
>
> I trust you on these.�� I'm not really in a position to test this out right
> now.�� I suggest you push the�� VMMakerCompatibilityForPharo6 packages to
> VMMaker as soon as you'd like.�� You can write VMMaker right?
>
+1
Guille, if you want commit access to the repo, you can make an account
on source.squeak.org and I'll add you the the VMMaker project. Or if
it's easier, just say which packages you are ready to move and either
I or Eliot (or any of the others with commit access) will move it to
VMMaker for you.
I note that VMMaker.oscog-GAP.2533 package is part of the main
VMMaker.oscog package. If you need to have that tested on Squeak I
can probably do that for you within the next couple of days if no
one else gets to it first.
Well, the change I did in that package was fairly small, and I'm using squeak to generate also some parts of the VM to compare to what I generate from Pharo.
So, I'd say I've tried it myself already.
For the Pharo specific package, I've already uploaded it to the VMMaker repository.
I had already rights to do it :).
Name: VMMakerCompatibilityForPharo6-GuillermoPolito.11
Author: GuillermoPolito
Time: 9 May 2019, 5:15:50.00473 pm
UUID: e1a685a9-d744-0d00-b3c1-ad600f1a7e9a
Ancestors: VMMakerCompatibilityForPharo6-GuillermoPolito.10
With these changes I can already compile and run Cog and almost all tests pass :)
I have also a couple dozen tests about AST translation and C generation, mainly about those parts that are covered differently between Pharo's and Squeak's ASTs.
Would you like that I push them inside the VMMaker package or make a separate package?
Thanks!
Guille