Levente,

that's weird, i'm sending you a screenshot i'm running�PharoCore 12271 with�Ocompletion-ul.88 loaded

I really like how you clear the way with these two questions,
- should OCompletion be used in that panel?�
- should that panel use TextEditor instead of SmalltalkEditor?

Using OCompletion is ok i think, in another email i said that having two way autocompletion with the TextEditor element and the recent�WHATEVER used list above dont make sense to me, but some argue that they use their mouse to go to a recently used class.

i think the finder window should be minimal, just the input text element -no recent used list- and have autocompletion (ie.�web autocompletion). As web users we see that a lot, i will not miss the recent WHATEVER list.

On your second question, imho we're trying to find a Smalltalk class or Smalltalk�WHATEVER, could be better to have a SmalltalkEditor instance instead of TextEditor one.

Cheers,
Francisco

PharoScreenshot.1.png

On Wed, Dec 8, 2010 at 4:20 AM, Alain Plantec <alain.plantec@free.fr> wrote:
I agree with Levente. The basic completion (cmd-q) is also only usable with a SmalltalkEditor.
Cheers
Alain

Le 08/12/2010 03:58, Levente Uzonyi a �crit :

On Wed, 8 Dec 2010, Francisco Ortiz Pe?aloza wrote:

So Levente you're saying that given the following use case you musn't add
#model to TextEditor but change TextEditor collaboration with an instance of
SmalltalkEditor

OCompletion works well to edit code in the system browser as is, the DNU
occurs when as an example you do a class find (Cmd+f) on SystemBrowser and
you start typing on that "Class name or fragment" window looking for
something.

Adding the accessor is fine of course, it may be useful for other things too. I'm saying that OCompletion is intended to work in places where code completion is necessary and those places are usually SmalltalkEditors. There are two things to think about:
- should OCompletion be used in that panel?
- should that panel use TextEditor instead of SmalltalkEditor?

Btw using the latest version of PharoCore (12271) I can't reproduce the error in the way you described it.


Levente


Cheers,
Francisco

On Tue, Dec 7, 2010 at 9:07 PM, Levente Uzonyi <leves@elte.hu> wrote:

On Tue, 7 Dec 2010, pharo@googlecode.com wrote:

�Status: Accepted
Owner: guillermopolito

New issue 3385 by guillermopolito: TextEditor doest not understand #model
http://code.google.com/p/pharo/issues/detail?id=3385

The accessor should be added to load last version of OCompletion in Core
1.2



OCompletion shouldn't be used in a TextEditor. OCompletion is for Smalltalk
code completion, while TextEditor is intended to be a text editor (ask
Juan). That's why OCompletion adds the model accessor to SmalltalkEditor and
not to TextEditor.


Levente