On 23 Aug 2019, at 12:13, Denis Kudriashov <dionisiydk@gmail.com> wrote:

Hi

��, 23 ��. 2019 ��., 11:06 Marcus Denker <marcus.denker@inria.fr>:

> On 23 Aug 2019, at 11:49, Cyril Ferlicot <cyril.ferlicot@gmail.com> wrote:
>
> Hi,
>
> Since yesterday I get a lot of bugs when I try to edit class
> definitions while having the slot template in class definition
> enabled. (See comment:
> https://github.com/pharo-project/pharo/pull/4391)
> This make it a little hard to develop :(
>
> Is there an easy fix? Else maybe we should revert the change until we
> have the fix?
>

I have a fix, I will commit when the internet connection is good enough

That's good.

https://github.com/pharo-project/pharo/pull/4409

I guess it was a class parser bug? I only tested browser with classic definition.

yes, even with this fix I need to do some (larger) change to support Slots with parameters, e.g.

{#lazy => LazySlot default: 5 .

#computed => ComputedSlot with: [:object | object calculateSomething] }

This need some change in how the class parser models slots, though�� CDSlotNode is just modelling a name and the class of the slot, but not the fact

that slot definitions can contain parameters which can contain even blocks��

and with composition (not yet in Pharo8), we need to support things like

#lazyAndObservable => SpObservableSlot + LazySlot default: 5 .

but I think it is not hard to do.