Two concerns from one flow of events...I was trying out "review a pull request" feature for the first time.�� This looks very promising, but I got stuck.��In Pharo 6.1...Updated Icerberg per https://github.com/pharo-vcs/iceberg#update-icebergIceberg���� > Settings > Use custom keys = Enabled�� > Add > Clone remote repository�� �� �� Remote URL = git@github.com:exercism/pharo.git�� ==> "pharo" repo appears, status "Not loaded"�� > "pharo" repo > Packages ==> BaselineOfExercism, Exercism, etc���������� > "pharo" repo > Github > View pull request > origin > enter github account password�� ==> shows PR#98 "Move setup to class initialization..."�� �� > right-click 98 > Review pull request�� ==> an empty window titled "Browsing pull request: #98...." appeared (see attached)Trying the same in Pharo 7 gave a different problem...From Launcher started Pharo-7.0.0-alpha.build.1231.sha.cf8aa48.arch.32bit...Iceberg���� > Settings > Use custom keys = Enabled�� > "pharo" repo > Forget Repository > Ticked "Also remove repository from file system"�� > Add > Clone remote repository�� �� �� Remote URL = git@github.com:exercism/pharo.git�� ==> "pharo" appears, status = "Fetch required. Unknown cf8aa48"�� > "pharo" repo > Fetch�� ==> no change in status,���� �� �� but I do see the the expected files in repo on disk���� > "pharo" repo > Packages�� ==> only shows LICENSE and README.md.������ �� �� Why did this "just work" in 6.1 ?�� �� �� It seems the source directory is wrong.���� �� �� From this point is it possible to update the source directory to "dev/src/" ?Maybe its due to the name clash "pharo-project/pharo" versus "exercism/pharo"and something was retained after the "Forget Repository".����Such a name clash is unfortunate, but is a corner case that should be handled.This could be a useful test case.Before I log an issue, could someone check I'm not doing something wrong.cheers -benP.S. A work around might have been giving a custom local name for the exercism/pharo repo,��much like you can specify the folder created by command line 'git clone'.��Is such a feature planned for Iceberg?
|
������ | Guille Polito Research Engineer Centre de Recherche en Informatique, Signal et Automatique de Lille CRIStAL - UMR 9189 French National Center for Scientific Research - http://www.cnrs.fr Phone: +33 06 52 70 66 13 |