Hi,

just a little update: yesterday I realised the tool lacked an important view: the changes between the PR and the actual destination of it (for example, you are doing a PR into ���development��� branch, and what is there could be different to what is loaded in your image. 

So I added that tab in the changes browser for the Pull Request: ���Changes vs. destination��� : 



this should allow you to analyse the PR in a more consistent way as before. 

now you have:

- changes vs. destination
- changes since selection (show changes against image version)
- changes vs. parent (show changes between selected commit and it���s parent)

that should be enough to actually review the pull request ;)

Esteban



On 7 Jul 2017, at 08:37, Esteban Lorenzano <estebanlm@gmail.com> wrote:


On 6 Jul 2017, at 17:35, Tim Mackinnon <tim@testit.works> wrote:

Will this update be picked up with the scripted steps you described for 0.5 (particularly if you want to run in a v6 image?).And do we just run them again to get it? (I assume that if you have already loaded 0.5 you just do the metacello bit - but in a new image, would those steps get you 0.5.1?)

yes (because 0.5.1 is released so integrated on master). 
otherwise you can specify version by doing: 

Metacello new
  baseline: 'Iceberg';
  repository: 'github://pharo-vcs/iceberg:v0.5.1���;
  load.

Esteban


(e.g. your wrote:

then, to update, execute this (sorry, this is like that because we have still an older Metacello version): 

#('Iceberg-UI' 'Iceberg-Plugin' 'Iceberg-Metacello-Integration' 'Iceberg-Libgit' 'Iceberg' 'BaselineOfIceberg' 'LibGit-Core' 'BaselineOfLibGit���) 
do: [ :each | each asPackage removeFromSystem ].

Metacello new
  baseline: 'Iceberg';
  repository: 'github://pharo-vcs/iceberg';
  load.
)

Tim

On 6 Jul 2017, at 16:23, Esteban Lorenzano <estebanlm@gmail.com> wrote:

it should be fixed now, I think :)

On 6 Jul 2017, at 17:07, Pavel Krivanek <pavel.krivanek@gmail.com> wrote:

There seems to be an issue in the baseline with circular dependencies. Load it, skip all warnings and then try to reload all packages in the Iceberg repository (from the Iceberg window).

-- Pavel

2017-07-06 16:53 GMT+02:00 Norbert Hartl <norbert@hartl.name>:
Am I the only one or are there some classes missing?

Norbert

Am 06.07.2017 um 15:35 schrieb Esteban Lorenzano <estebanlm@gmail.com>:

Hi,

I just released Iceberg version 0.5.1 with a Pull Request tool Guille and I worked on since yesterday. 
It allows you to list open Pull Requests (by right click on a repo, GitHub/Review pull requests��� option): 

<Screen Shot 2017-07-06 at 14.59.32.png>

And then if you doubleclick on one (or select it with right button), you will see this: 


<Screen Shot 2017-07-06 at 15.00.56.png>
it allows you to see changes and 

- merge changes into your image (in case you want to see more in details the code, run tests, etc.)
- accept a pull request
- reject a pull request

no, it does not shows (at least *yet*) comments, and it does not allows you to add comments, reviews, etc. 
this could be done, but not time to implement it now, so for now this has to be enough. 

Again, this can be loaded in a 6.0 image by executing this script: 

#('Iceberg-UI' 'Iceberg-Plugin' 'Iceberg-Metacello-Integration' 'Iceberg-Libgit' 'Iceberg' 'BaselineOfIceberg' 'LibGit-Core' 'BaselineOfLibGit') do: [ :each | each asPackage removeFromSystem ].

Metacello new
  baseline: 'Iceberg';
  load. 

(and you still need to have the vm that is meant for Pharo7)

This tools are open for you to use on your projects��� and to improve them, I accept pull requests on pharo-vcs/iceberg.

cheers!
Esteban