On Sat, Feb 18, 2012 at 5:12 PM, Benjamin
<benjamin.vanryseghem.pharo@gmail.com> wrote:
On Feb 18, 2012, at 11:22 AM, Mariano Martinez Peck wrote:
Hi Ben. What you did is very very cool. I was waiting for it since a lot of time. So...I had no excuses left to use it ;)�� You asked for feedback?� Ok, I have a long pass. I hope you can get something useful from it. I would like to provide more help but this is all I can offer right now:
- When you are in a pane, say Class column, you press the right arow ->� and the focus goes to the next column, so if you do down arrow now you start to move between methods. However, when you move from column, the first row (protocols in this case) of the right column is not highlighted so you don't really know if you are there or not until you start to move (like arrow down).� So, I would autoselect/autohighlight first row of next column in that case.
�
The selected list is surrounded by a light blue rectangle. I think the width of this border should be increase a bit, but it depends of the theme :)
hahahahah� ok...now I see it. But it is incredible complicated to see it ;)�� Indeed it would be much better if:� a) the border is bigger� b) why not to always auto select the first row?
�
- file out in menu of protocols or methods does nothing -> if file out of single protocols is not supported it should be removed from the menu.
On methods, it works for me :)
true...I tried again and it works. Sorry ;)
�
On protocols, I fixed it :)
mmm did you commit?� I have updated everything and still it doesn't work. MessageNotUnderstood: NautilusUI>>fileOutCategories:from:
�
- multiple select in protocols does not add methods in methods pane. The new protocol is just highlighted, its methods are shown in the method column, but we lost the previous one, even if the previous category is still selected.
- Done :)
Almost ;)
Example: browse RBReadBeforeWrittenTester. select protocol 'accessing'. Now with ctrl and click select also 'initialize-release'. Ok. good now we have both selected. But now, click again in 'initialize-release', and you will see that instead of only letting 'accessing', instead you show ALL methods.�
�
- when selecting several methods and� try to remove them, do not ask each method individually� "it has xx senders.. what do you want to do?" � give options according to the fact that there are several methods, but it only once. For example: "remove all and see all senders" "or just remove all". If you ask that for each method�then it is not a bulk remove but again, having to remove method by method�
I should, but it's some work :)
Ok, no problem.� Maybe we can open tickets/wishlists somewhere ?
�
- Sometimes the icon for the tests appear even if those methods are not tests. Look attached file notTestMethods.
Here, the test icon is displayed because there is a corresponding test. (In your example, it means that the method BehaviorTest>>#testAllMethods exists :)
hehehehe ok. Funny. In my cases I think I have a really low percentage of mapping between methods names and the test for them. But its fine, maybe for someone is useful. Maybe a different color/icon from the one using for those which are real tests?
�
- When you are showing extensions to a class, I would not show the whole class, but intead just the extensions from the package I am browsing. Look attached NotShowFullClass.
First I thought about that too, but then I figured out that when you are writing an extension, it's really useful to be able to know the whole set of available methods in a glance :)
Ok. I found it confusing at the beginning, but ok. Anyway, in that case, following to what happens in Classes, the protocolos which are not mine should be in gray and MINE in black. In my example, I mean to let black *Ast-Core and put gray to all the rest?�
�
- It would be very very cool if from the Class Search popup we have a shortcut to not change the current browse but instead open it in another one.
This should be done on Class Search, but indeed, it will be cool ;)
:)
�
- When you are in the class column and you do right click and create a class, the class column where you are is not refreshed automatically and you don't see the just created class. You need to go to another package and then come back to see it�.I guess you need to trigger a refresh or invalidate some cache.
- Fixed :)
Ok, I guess you didn't commit yet ;)
�
- When viewing hierarchy package and class columns are swapped�confusing.
- Yes I know, but there are a set of good arguments behind ^^
hehee I am all ears
�
- Bug somehow using the left arrow "<". Find attached PharoDebugBug1.log
Can't reproduce it :s
I cannot either. It just happened once and I couldn't reproduce it :(
�
- Bug: select a package. Right click, find package, cancel. DNU. Find attached� PharoDebugBug2.log
- Fixed
Checked and works
�
- Does it make sense� to show "Run tests" when we are in a package where we have not even one single test? For example, go to the package 'Zinc-HTTP-Streaming'� right click..and you will see Run tests� I would only let that option for the cases that you KNOW there are tests inside.
- Done
Checked nad works.
One new problem. If I do "Run tests" to the package CompilerTests some of the classes are not colored as green, but if I click in the class, then I see inside that their test methods are green.
�
-In the code pane, the extended search doesn't work and instead it just opens the same menu again. THis is a petty because I use "method source with it" quite a lot ;)
- A submenu has been added :)
AWEOME :)
�
- Bug: select the package� 'Multilingual-Tests-TextConversion'. Find PharoDebug3.log attached.
- Fixed too
Tested and works.
�
- When selecting a package (but no classes yet), wouldn't make sense to set the package name as the title in the windows rather than Nautilus?
- Fixed :)
Tested and works.
�
Well, that's all so far. It is a very cool browser and I plan to start using it as my default :)
Please continue!!!
Thanks A LOT for your feedback :)
Thanks for your great work. Immediate answer and a bunch of fixes. Awesome.
Continue!
�
Ben
On Sat, Feb 18, 2012 at 10:54 AM, Andreas Wacknitz
<a.wacknitz@gmx.de> wrote:
Am 18.02.2012 um 01:40 schrieb Benjamin:
Hi guys,
I am glad to announce that refactorings (RBEngine) are now integrated into Nautilus :)
I hope you will enjoy it, and as usual, any feedback is welcome :)
(the next step is to do a nice changes browser :) )
Ben
I downloaded the Jenkins build this morning.
When I select the "Announcement-Tests-Core" package I will get a DNU False>>ifEmpty:
Nevertheless, keep on your impressive work!
Regards
Andreas
--
Mariano
http://marianopeck.wordpress.com