----- Original Message -----

From: Benjamin

To: Pharo-project@lists.gforge.inria.fr

Sent: Wednesday, April 25, 2012 11:58 AM

Subject: Re: [Pharo-project] Polymorph (and a few other) changes/fixes

Ok, found why :)

This fix it for me :)

Can you have a quick look ?

Thanks in advance,

Ben

---

On Apr 25, 2012, at 12:29 PM, Gary Chambers wrote:

Hi,

 

well it seems that there is now an inst var on DropListMorph for wrapSelector,

only used by getter/setter and wrapItem:index:

 

Setting sends updateContents which uses wrapItem:index: on the (sub) list morph, which never gets changed.

So, although the contents are correct (eventually returns to the local wrapItem:index), the list items are incorrect as

updateList never gets sent to the list...

 

E.g.

 

(UITheme builder
 newDropListFor: (ListModel new list: {Object. Rectangle})
 list: #list
 getSelected: nil
 setSelected: nil
 getEnabled: nil
 help: nil)
 wrapSelector: #className;
 openInWindow

 

 

Easy to fix but I'll wait till it is before I post some of my changes that were in conflict.

 

Regards, Gary

----- Original Message -----

From: Benjamin

To: Pharo-project@lists.gforge.inria.fr

Sent: Wednesday, April 25, 2012 10:28 AM

Subject: Re: [Pharo-project] Polymorph (and a few other) changes/fixes

Do you have an example where the DropListMorph wrapSelector is broken ? 

Ben

On Apr 24, 2012, at 5:21 PM, Gary Chambers wrote:

Finally found the time to package out.

Have tested a bit after fixing some conflicts.

A few minor ones left for DropListMorph as it seems the wrapSelector stuff has changed (and appears broken in 2.0 too).

 

Attached cs and description of changes

Regards, Gary

<Pharo2.0Changes.4.cs><PharoPolymorphChanges.txt>

---

Ok, found why :)


This fix it for me :)

Can you have a quick look ?


Thanks in advance,

Ben







On Apr 25, 2012, at 12:29 PM, Gary Chambers wrote:

> Hi,
> 
> well it seems that there is now an inst var on DropListMorph for wrapSelector,
> only used by getter/setter and wrapItem:index:
> 
> Setting sends updateContents which uses wrapItem:index: on the (sub) list morph, which never gets changed.
> So, although the contents are correct (eventually returns to the local wrapItem:index), the list items are incorrect as
> updateList never gets sent to the list...
> 
> E.g.
> 
> (UITheme builder
>  newDropListFor: (ListModel new list: {Object. Rectangle})
>  list: #list
>  getSelected: nil
>  setSelected: nil
>  getEnabled: nil
>  help: nil)
>  wrapSelector: #className;
>  openInWindow
> 
> 
> Easy to fix but I'll wait till it is before I post some of my changes that were in conflict.
> 
> Regards, Gary
> ----- Original Message -----
> From: Benjamin
> To: Pharo-project@lists.gforge.inria.fr
> Sent: Wednesday, April 25, 2012 10:28 AM
> Subject: Re: [Pharo-project] Polymorph (and a few other) changes/fixes
>
> Do you have an example where the DropListMorph wrapSelector is broken ?
>
> Ben
>
> On Apr 24, 2012, at 5:21 PM, Gary Chambers wrote:
>
>> Finally found the time to package out.
>> Have tested a bit after fixing some conflicts.
>> A few minor ones left for DropListMorph as it seems the wrapSelector stuff has changed (and appears broken in 2.0 too).
>> 
>> Attached cs and description of changes
>>
>> Regards, Gary
>> <Pharo2.0Changes.4.cs><PharoPolymorphChanges.txt>
>
>