Would be nice to have an advanced data collection, but I am not sure that I will have time now to program all that

There is already data collection for spotter and there was chatter about making the collection tool more generic, but I don't think any progress is on that.

So what exactly is "Useless" for? If there was some input box where I could describe why I think its useless in that particular context or whatever...

However I have question about two more cases, not sure if even possible to implement

case 1:

~~~~~~~~~~~~~~~~~~~~~~~~

beFinal

self isFinal: true

~~~~~~~~~~~~~~~~~~~~~~~~

"Unary "accessing" method without explicit return"

#beSomething is quite common pattern (even recommended in Kent's Best Practice Patterns), maybe it should check for name 'be'<Uppercase> before applying the critic?

case 2:

in Roassal it's very common to create a shape but return an element

~~~~~~~~~~~~~~~~~~~~~~~~

RTEllipse new

size: 14;

color: Color black;

element

~~~~~~~~~~~~~~~~~~~~~~~~

RTBox new

elementOn: aModel

~~~~~~~~~~~~~~~~~~~~~~~~

but of course it complains about missing ";yourself".

However I do not really want to ban the critic, because there may other legitimate applications in the method/class; and in Roassal-heavy code it's a nuisance.

So it would require context-aware checks (probably user-defined?) like "if receiver is subclass of RTShape then don't apply this (yourself) rule".

Cheers,

Peter