2011/5/26 laurent laffont
<laurent.laffont@gmail.com>
2011/5/26 laurent laffont
<laurent.laffont@gmail.com>
Gast��n,
I've downloaded the new version - thanks a lot for contributing, it brings fun :)
Some comment:
- tiling browsers don't work any more with OB,��WMWithAnOBBrowserAndDockingBarsTest does not create an OBBrowser anymore but a Browser
In 1.3 core there's not OBBrowser, then, when trying to modify a method with reference to OBBrowser obtained an error. So I remove their references.
I see. I will refactor this so it will be compatible with Core and still work with OB (quite easy).
This would be great, because now I think, in a core are never the most useful tools (Seaside control panel, memory monitor), and TWM should know about them in some way (you apply a pattern to solve this problem?).
��
��
- you've changed TilingWM>>visibleWindows to TilingWM>>windows. The "visible" was not innocent, because tileVisibleWindows cares about windows that are not minimized. On the other side, tileWorkspaces tile all workspaces, minimized or not. So I think in final we may have:
#tileVisibleWindows
#tileWindows ��(maybe #tileAllWindows is a better name)��
#tileVisibleWorkspaces
#tileWorkspaces / #tileAllWorkspaces
......
Please, see you the comment in de versi��n 5 of de package, "Now all botton tile visibles windows.". I think it's better to just get organized visible windows, even when done on a particular kind (such as workspaces). For this is that the word was redundant now visible.
I will think about this.
When you have many windows, minimizing them is the way to let them "suspended", therefore I think it should be organized only visibles.
��
- I will add tests to TWMBar finally as it seems to grow
- I want TilingWM to be 100% test coverage
Sorry, give me some time for learn about this...
Don't hesitate to ask.
ok.
��
- Balloon and spaces for TWMBar is a good idea - we need to make this work effectively :)
yes
��
- Great to have all the buttons per type of applications !
it is still very rudimentary way to filter the windows, but it was helpful to learn about the hierarchy of classes 1.3, in regard to the Models for example.
Indeed I've disable TaskBarMorph in my image as it's useless now :)
Great!!!
I'll be honest, this is my first serious development in Squeak / Pharo, so it gives me much encouragement your comment, there is still much to learn and improve, but it is very encouraging to devote time to something that might be useful to others.
��
Laurent.
��
I've merge some of your changes in TWM-LaurentLaffont.5
:)
��
2011/5/26 Gast��n Dall' Oglio
<gaston.dalloglio@gmail.com>
2011/5/25 Gast��n Dall' Oglio
<gaston.dalloglio@gmail.com>
Excelent!
IMHO, it's better that's not integrated to TaskBarMorph, lets it free :)
For example, click in unused space of the TWMBar and you can move it around you wish in the screen, similar to use DockingBarMorph>>beFloating. I attach screenshot.
Laurent, I improved (or not? :)) your work, if you think that is bad for TWM simply undo it ;)
Feel free to play. Just try to write tests for TilingWM please :)
ok. I load a new version to ss. Now teh button tile visible windows only. I fixed the test...
��
For TWMBar I'm not sure this will be a final GUI. Ideally all will be keyboard driven, I have to play with KeyMapping.
yes, sure.
��
I also think the UI theme Patrick has cleaned fits better with TilingWM:
To try it:
Gofer it
squeaksource: 'PBASandbox';
package: 'PBSandbox';
load.
StandardUITheme beCurrent.
See screenshot.
I try, yes.
��
Patrick, could you push this with a nice package name ?
Laurent.
��
2011/5/25 laurent laffont
<laurent.laffont@gmail.com>
Now there's a button to open the world menu.
On Wed, May 25, 2011 at 11:20 AM, laurent laffont
<laurent.laffont@gmail.com> wrote:
On Wed, May 25, 2011 at 11:06 AM, St��phane Ducasse
<stephane.ducasse@inria.fr> wrote:
I do not understand.
how can I get a browser?
Hey, this is just a start :) ��I will add a button to open the world menu.
once this is one is created I get the browser full screen
but then how do I get a chance to create a new one if I want.
dividing the browsers based on the screen size results in rather small browsers :)
yes, but because browsers waste space IMHO. Maybe we could get rid of windows borders when tiled.
Laurent.
��
Stef
> TWMBar new open.
>
> The real manager is TilingWM. Try:
>
> (TilingWM forWorld: World) tileVisibleWindows.
> (TilingWM forWorld: World) tileBrowsers.
> (TilingWM forWorld: World) tileWorkspaces.
>