How do other people do it ?

On 31 Jan 2019, at 08:18, Pavel Krivanek <pavel.krivanek@gmail.com> wrote:

It is working now again as expected.

The only difference is that you need to use "Github-Create new branch for issue..." instead of "Pharo-Create new branch for issue..." for the new issues reported on GitHub.

-- Pavel

st 30. 1. 2019 v 9:42 odes��latel Guillermo Polito <guillermopolito@gmail.com> napsal:
Hi,

there is an issue for this problem,

https://github.com/pharo-project/pharo/issues/2379

We have identified the cause, I'll propose a fix now

On Wed, Jan 30, 2019 at 8:44 AM ducasse <stepharo@netcourrier.com> wrote:
>
> There is currently a bug eating one character of the commit hash. So
> Iceberg does not find the hash and thinks we need a fetch. So currently
> we need to checkout Pharo8.0 in order to be in a good state :(

OOPs is there a bug entry?
>
>> I also don't understand how to make an issue branch for
>>
>> https://github.com/pharo-project/pharo/issues/2395
>>
>> Is it Iceberg > Pharo > Create new branch for issue or Iceberg > Github > Create new branch for issue ?
>
> Just create a branch and choose the option to create a branch from a
> Github option.
>
> The other one was for Manuscript and is now useless for Pharo 8. I
> opened an issue in Iceberg to remove it but I did not got the time to
> contribute the change.
>
>> What is the difference ?
>> What about the Remote ?
>> Can I work with only an issue on GitHub ?
>>
>
> Yes!
>
> What I am doing currently:
>
> - Open an issue XX
> - Sync my fork Pharo8.0 branch via command line (This is optional and
> can also be done in Pharo. I just do it via command line because I like
> it better that way)

how do you do it? Pull?

> - Download a Pharo 8 image
> - Checkout the Pharo8.0 branch to get in a clean state because of the
> hash eating bug I mentioned earlier
> - Create a new branch from a github issue of the pharo remote
> - Do the changes and commit. I add `Fixes #XX` in the commit message to
> close automatically the issue when the PR is merged.
> - Push to my remote
> - Open a PR against Pharo8.0 through Iceberg > GitHub > Create new pull
> request

and checkout the pharo 8 branch to fix the next one.
>
>> Is the documentation
>>
>> https://github.com/pharo-project/pharo/wiki/Contribute-a-fix-to-Pharo
>>
>> really up to date ?
>>
>
> No
>
> We should correct the hash eating bug before updating it I think.
>
>> Sven
>>
>>
>
>
> --
> Cyril Ferlicot
> https://ferlicot.fr
>

--

Guille Polito
Research Engineer

Centre de Recherche en Informatique, Signal et Automatique de Lille
CRIStAL - UMR 9189
French National Center for Scientific Research - http://www.cnrs.fr

Web: http://guillep.github.io
Phone: +33 06 52 70 66 13