Hi Max,
could the cache be reimplemented using WeakArray? Stuff like this is a drag. eg in Squeak the Windows menu holds onto all the windows that were open when last the menu was opened. So to get a window reclaimed after being closed if you opened the Windows menu you have to open it again. I must fix that.
No idea. I really didn���t look at what it does, I just tracked pointers ;)
But yes, maybe that would be a good idea. Adding ���ASTCache reset.��� all over the place is not really a good strategy.
I���ll send a copy of this message to Marcus and Cl��ment; I suspect they might know more about the AST stuff.
Cheers,
Max
Eliot (phone)
I spent a couple of hours trying to find out why the #obsoleteClasses test sporadically fails. I���ve found one candidate that fixes all the failures that I could produces. Simply put, any test that does something AST related (e.g. runs critics) *has to* reset the ASTCache during #tearDown:
ASTCache reset.
I���ve found two test classes that needed to be adapted: SmalllintManifestCheckerTest and VSReleaseDevelopmentVersionCommandTest.
Cheers,
Max