btc@openinworld.com wrote:

Daniela Meneses wrote:

Hi to all,

I'm writing missing test for the String class methods to improve the test coverage. I will commit my changes in this project at SmalltalkHub:

http://smalltalkhub.com/#!/~DanielaMeneses/ImprovingStringAPI

Feel free to take a look. Any feedback will be really welcome and useful. :D

--

Cheers,

Daniela

hi Daniela,

That is a nice initiative. I guess you have bigger plans to "rethink the String manipulation API of Pharo" where you will want to be experimenting in a separate branch, but adding tests would be beneficial for the mainline now. I'd encourage you to open a Case at pharo.fogbugz.com and submit those tests as a slice :)
You definitely get feedback as part of the integration review process.
cheers -ben

btw a small thing, in #testAsPluralbasedOn, maybe....
    self deny: ('dog' asPluralBasedOn: 1) = 'dogs'.

would be better as
    self assert: ('dog' asPluralBasedOn: 1) equals: 'dog'.

since the first has an infinite number of solutions, and the second has only one.

Also I have seen discussion that
    assert: a equals: b
is preferred over
    assert: ( a = b)

cheers -ben