Hi Sean,

I just tested the new implementation. Exciting :). See below the comments and the little improvement for item count.

But, now, we have another problem: going with up/down jumps over one items (so, you can only reach 1, 3, 5 ...). I could not figure out where the problem comes from. It only happens in the full Spotlight, but not in the completion example.

On Thu, Jan 2, 2014 at 1:53 PM, Sean P. DeNigris <sean@clipperadams.com> wrote:

Tudor Girba-2 wrote

> - I love it how I can navigate with up/down and still continue typing.
> This
> is seriously cool.

:)

Tudor Girba-2 wrote

> - Esc has no effect (

I had implemented it for entry completion. It is working in SpotlighMorph
now also.

Great. Works fine.

Tudor Girba-2 wrote

> - The list entries behave strangely because you use a text morph that can
> be edited. For example, type something, go with the mouse over an item in
> the list, you will see the cursor changes to a text one, click, and you
> can
> start typing there. Why not use a LabelMorph?

I didn't use LabelMorph because it deals with strings, not text, and I want
to be able to e.g. make the matching substring bold like in the examples.
But I locked the TextMorphs, so it's fixed.

Indeed. Got it.

Tudor Girba-2 wrote

> - Pressing Enter does not seem to trigger the action associated with a
> list. Only pressing double click seems to work.
> - The PluggableTextMorph at the top allows Enter. Pressing Enter leads to
> a
> line break. This is not wanted (you asked what I meant by it a field).
> - The PluggableTextMorph at the top should not indicate dirty state

Fixed.

Works.

Tudor Girba-2 wrote

> - Pressing up/down also moves the cursor in the top PluggableTextMorph.
> This should not happen.

This should be fixed now that you can't enter a new line

It's not fixed. Try this:

- type ab

- move down ==> all is fine: the search morph looks like (ab|)

- move up ==> the cursor in the search morph moves at the beginning (|ab)

�

Tudor Girba-2 wrote

> - It would be interesting to have the count of hits even though we are
> only
> displaying a limited amount.

Yes it would. Feel free to submit code ;)

Done. You can find it here:

Gofer new�

smalltalkhubUser: 'girba' project: 'GPlay';

package: 'Spotlight';

load

�

Tudor Girba-2 wrote

> And a question related to "Show all on down arrow when closed":

Ah, yes. I guess this is more relevant to entry completion, but if the
completion menu is not yet open, and you press the down arrow while the text
field has the keyboard focus, the menu will appear with all possible
results.

Aha. Got it.

Cheers,

Doru

�

Keep the feedback coming!!!

-----
Cheers,
Sean
--
View this message in context: http://forum.world.st/Spotlight-Demo-tp4733076p4733615.html
Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

www.tudorgirba.com

"Every thing has its own flow"