This week (48/2020) on the Issue Tracker

MD
Marcus Denker
Fri, Nov 27, 2020 8:21 AM

That was a busy week.. we merged 50 Pull requests the last 7 days. And no, not only trivialities!

Graphics

Add the missing implementation of OSSDL2GLRenderer >> #pixelExtent #7786
https://github.com/pharo-project/pharo/pull/7786

Clean the OSWindowGenericRenderer texture APIs for properly implementing a text renderer #7836
https://github.com/pharo-project/pharo/pull/7836

Fluid Class Definition

Cleanups…

Fixes: #7816 this is what is breaking #7774 #7817
https://github.com/pharo-project/pharo/pull/7817

FFI

Variables/Compiler

Speed Improvements

speedup #hasProperty: a little by using includesProperty: instead of #propertyAt:ifAbsent:

This lead to a Proposal: Simplify How Pragmas are stored (feedback wanted!)
- https://github.com/pharo-project/pharo/issues/7871

Bug Fixes

Small Improvements

Unused Varianbles Cleanup

I wrote about this:
https://blog.marcusdenker.de/finding-unused-variables-an-example-for-first-class-variables

The tests are for now on “self skip” until we clean the unused vars.

Lot of activity to clean it up:

Cleanups

Cleanups are those changes that do not have any immediate
impact for the users. But they prepare the future: they make code
simpler, remove dead code, add documentation, fix typos...

That was a busy week.. we merged 50 Pull requests the last 7 days. And no, not only trivialities! Graphics ======== Add the missing implementation of OSSDL2GLRenderer >> #pixelExtent #7786 https://github.com/pharo-project/pharo/pull/7786 Clean the OSWindowGenericRenderer texture APIs for properly implementing a text renderer #7836 https://github.com/pharo-project/pharo/pull/7836 Fluid Class Definition ======================= Cleanups… Fixes: #7816 this is what is breaking #7774 #7817 https://github.com/pharo-project/pharo/pull/7817 - 7820 class description contains dead code related to slots printing #7828 https://github.com/pharo-project/pharo/pull/7828 - Trait was missing the #named:package: instance creation method #7837 https://github.com/pharo-project/pharo/pull/7837 - Origin/7770 cleaning old definition printer #7845 https://github.com/pharo-project/pharo/pull/7845 FFI === - Cleanup UnifiedFFI packages #7793 https://github.com/pharo-project/pharo/pull/7793 - Extracting FFI backend #7834 https://github.com/pharo-project/pharo/pull/7834 Variables/Compiler ================== - MetaLinks-Cleanup-Variables2 #7742 Instead of names, use Variables! More to come. https://github.com/pharo-project/pharo/pull/7742 - SemanticAnalysis-Args-are-read #7844 Arguments are now correctly tagged as #read im semantic analysis https://github.com/pharo-project/pharo/pull/7844 - Compilerbased-meta-data-tagging #7779 We now tag methods with #halt calls during compilation instead of scanning bytecode slowly later. https://github.com/pharo-project/pharo/pull/7779 Speed Improvements =================== speedup #hasProperty: a little by using includesProperty: instead of #propertyAt:ifAbsent: - CompiledMethod-hasProperty-use-includesProperty #7854 https://github.com/pharo-project/pharo/pull/7854 This lead to a Proposal: Simplify How Pragmas are stored (feedback wanted!) - https://github.com/pharo-project/pharo/issues/7871 Bug Fixes ============ - Fix side-effect in MCOrganizationDefinition #7815 https://github.com/pharo-project/pharo/pull/7815 - #ensureCreateDirectory` Shouldn't Resolve #7833 https://github.com/pharo-project/pharo/pull/7833 - fixing-title-in-osx #7843 Blog post: https://thepharo.dev/2020/11/25/a-vm-bug-no-an-image-one/ https://github.com/pharo-project/pharo/pull/7843 - Fixing dependencies error. #7856 https://github.com/pharo-project/pharo/pull/7856 - 7862-Cleaning-finder-code-glicthes #7864 https://github.com/pharo-project/pharo/pull/7864 Small Improvements ================== - 7755 re excessive arguments rule should exclude ffi callouts #7757 https://github.com/pharo-project/pharo/pull/7757 - 7777-Could-we-have-isTestMethod-on-Symbol-too #7785 https://github.com/pharo-project/pharo/pull/7785 - 7347 improve exception description api #7661 https://github.com/pharo-project/pharo/pull/7661 - Accessor generator should create formatted version #7853 https://github.com/pharo-project/pharo/pull/7853 - Add additional linux platform checking #7803 https://github.com/pharo-project/pharo/pull/7803 Unused Varianbles Cleanup ========================= I wrote about this: https://blog.marcusdenker.de/finding-unused-variables-an-example-for-first-class-variables The tests are for now on “self skip” until we clean the unused vars. - Cleanup-Unused-Ivars #7780 https://github.com/pharo-project/pharo/pull/7780 - add testNoUnusedClassVariablesLeft (skipped for now) #7784 https://github.com/pharo-project/pharo/pull/7784 Lot of activity to clean it up: - Remove unused var in SycMethodNameEditorTest #7799 https://github.com/pharo-project/pharo/pull/7799 - Var cleanup in DependencyAnalyser #7791 https://github.com/pharo-project/pharo/pull/7791 - Care on unused ivars in Renraku #7811 https://github.com/pharo-project/pharo/pull/7811 - Unused ivar MorphicTabManagerAdapter #7809 https://github.com/pharo-project/pharo/pull/7809 - Care on unsued ivars in Calypso #7814 https://github.com/pharo-project/pharo/pull/7814 - Unused ivar in Reflectivity-Tools-Tests #7824 https://github.com/pharo-project/pharo/pull/7824 - Unused ivar in Clap #7822 https://github.com/pharo-project/pharo/pull/7822 - Remove unused trait users #7797 https://github.com/pharo-project/pharo/pull/7797 - Unused ivars in UDPSocketTest #7849 https://github.com/pharo-project/pharo/pull/7849 Cleanups ======== Cleanups are those changes that do not have any immediate impact for the users. But they prepare the future: they make code simpler, remove dead code, add documentation, fix typos... - Move ReAsClassRule to GeneralRules #7759 https://github.com/pharo-project/pharo/pull/7759 - Rule based cleanup for RBCompositeRefactoryChange #7776 https://github.com/pharo-project/pharo/pull/7776 - Simplify ReExcessiveArgumentsRule>>#basicCheck: #7789 https://github.com/pharo-project/pharo/pull/7789 - remove-halt-visitEnglobingErrorNode #7801 https://github.com/pharo-project/pharo/pull/7801 - Fulfil ClassTestCase>>#classToBeTested subclass reponsibility #7805 https://github.com/pharo-project/pharo/pull/7805 - Cleanup and extend Dr. Test #7807 https://github.com/pharo-project/pharo/pull/7807 - Cleanup DrTest - pass #2 #7819 https://github.com/pharo-project/pharo/pull/7819 - Remove FFITutorial #7795 https://github.com/pharo-project/pharo/pull/7795 - Merge-MethodNameEditor-RBMethodNameEditor #7775 https://github.com/pharo-project/pharo/pull/7775 - PharoDocComment : remove a direct reference to RBParser #7781 https://github.com/pharo-project/pharo/pull/7781 - PharoDoc-pass2 #7829 https://github.com/pharo-project/pharo/pull/7829 - [Code cleaning] Replaced 'Character tab asString' to 'String tab' #7835 https://github.com/pharo-project/pharo/pull/7835 - Clean up Base64MimeConverterTest #7851 https://github.com/pharo-project/pharo/pull/7851 - reduce-ASTCache-reset #7783 https://github.com/pharo-project/pharo/pull/7783 - 7857-Cleaning-ends-of-class-names-in-Calypso #7858 https://github.com/pharo-project/pharo/pull/7858 - 7859-CalypsoContextPartTwo #7861 https://github.com/pharo-project/pharo/pull/7861 - Small typo in ExtendedDatePrinter>>#printDate:format:on: #7870 https://github.com/pharo-project/pharo/pull/7870 - Ban rule "class not referenced" for WebBrowser subclasses #7847 https://github.com/pharo-project/pharo/pull/7847