pharo-users@lists.pharo.org

Any question about pharo is welcome

View all threads

P12 new Tonel formatting and PR implications

TM
Tim Mackinnon
Sun, May 12, 2024 10:21 AM

Asking this here as it didn’t get much traction on Discord - but with the move to P12, the category format in Tonel has changed from a symbol to a string e.g.  { #category : #examples } vs { #category : 'examples' } - this causes mega noise when submitting tiny PR's - how is everyone else handling this? Should projects resave every project module to get the new format while people are out of the pool? Or is there a way to force the old format on specific projects until they can be upgraded ?

It seems like a change whose consequences need some attention ?

What are others doing?

Tim

Asking this here as it didn’t get much traction on Discord - but with the move to P12, the category format in Tonel has changed from a symbol to a string e.g. { #category : #examples } vs { #category : 'examples' } - this causes mega noise when submitting tiny PR's - how is everyone else handling this? Should projects resave every project module to get the new format while people are out of the pool? Or is there a way to force the old format on specific projects until they can be upgraded ? It seems like a change whose consequences need some attention ? What are others doing? Tim
SD
stephane ducasse
Sun, May 12, 2024 9:55 PM

The team will be back from vacation…. last week was a three free days week :).

S

On 12 May 2024, at 06:21, Tim Mackinnon tim@testit.works wrote:

Asking this here as it didn’t get much traction on Discord - but with the move to P12, the category format in Tonel has changed from a symbol to a string e.g.  { #category : #examples } vs { #category : 'examples' } - this causes mega noise when submitting tiny PR's - how is everyone else handling this? Should projects resave every project module to get the new format while people are out of the pool? Or is there a way to force the old format on specific projects until they can be upgraded ?

It seems like a change whose consequences need some attention ?

What are others doing?

Tim

Stéphane Ducasse
http://stephane.ducasse.free.fr
06 30 93 66 73

"If you knew today was your last day on earth, what would you do differently? ....ESPECIALLY if, by doing something different, today might not be your last day on earth.” Calvin & Hobbes

The team will be back from vacation…. last week was a three free days week :). S > On 12 May 2024, at 06:21, Tim Mackinnon <tim@testit.works> wrote: > > Asking this here as it didn’t get much traction on Discord - but with the move to P12, the category format in Tonel has changed from a symbol to a string e.g. { #category : #examples } vs { #category : 'examples' } - this causes mega noise when submitting tiny PR's - how is everyone else handling this? Should projects resave every project module to get the new format while people are out of the pool? Or is there a way to force the old format on specific projects until they can be upgraded ? > > It seems like a change whose consequences need some attention ? > > What are others doing? > > Tim Stéphane Ducasse http://stephane.ducasse.free.fr 06 30 93 66 73 "If you knew today was your last day on earth, what would you do differently? ....ESPECIALLY if, by doing something different, today might not be your last day on earth.” Calvin & Hobbes
EL
Esteban Lorenzano
Mon, May 13, 2024 5:31 AM

Hi,

This is indeed a noisy change. That's the reason it was a change we were
holding back during years, but at a point we needed to do it (there is a
spec for tonel format we made together with Gemstone people and at a
point, we needed to go to the agreed definition.

So, yes... this will cause annoying moments until all projects are
migrated. My recommendation is to make a PR with the new format and work
from there.

Esteban

ps: there will be still some noise, next year, since we need to clean up
a bit around... I am sorry in advance.

On 12/05/2024 23:55, stephane ducasse wrote:

The team will be back from vacation…. last week was a three free days
week :).

S

On 12 May 2024, at 06:21, Tim Mackinnon tim@testit.works wrote:

Asking this here as it didn’t get much traction on Discord - but with
the move to P12, the category format in Tonel has changed from a
symbol to a string e.g.  { #category : #examples } vs { #category :
'examples' } - this causes mega noise when submitting tiny PR's - how
is everyone else handling this? Should projects resave every project
module to get the new format while people are out of the pool? Or is
there a way to force the old format on specific projects until they
can be upgraded ?

It seems like a change whose consequences need some attention ?

What are others doing?

Tim

Stéphane Ducasse
http://stephane.ducasse.free.fr
06 30 93 66 73

"If you knew today was your last day on earth, what would you do
differently? ....ESPECIALLY if, by doing something different, today
might not be your last day on earth.” Calvin & Hobbes

Hi, This is indeed a noisy change. That's the reason it was a change we were holding back during years, but at a point we needed to do it (there is a spec for tonel format we made together with Gemstone people and at a point, we needed to go to the agreed definition. So, yes... this will cause annoying moments until all projects are migrated. My recommendation is to make a PR with the new format and work from there. Esteban ps: there will be still some noise, next year, since we need to clean up a bit around... I am sorry in advance. On 12/05/2024 23:55, stephane ducasse wrote: > The team will be back from vacation…. last week was a three free days > week :). > > S > >> On 12 May 2024, at 06:21, Tim Mackinnon <tim@testit.works> wrote: >> >> Asking this here as it didn’t get much traction on Discord - but with >> the move to P12, the category format in Tonel has changed from a >> symbol to a string e.g.  { #category : #examples } vs { #category : >> 'examples' } - this causes mega noise when submitting tiny PR's - how >> is everyone else handling this? Should projects resave every project >> module to get the new format while people are out of the pool? Or is >> there a way to force the old format on specific projects until they >> can be upgraded ? >> >> It seems like a change whose consequences need some attention ? >> >> What are others doing? >> >> Tim > > Stéphane Ducasse > http://stephane.ducasse.free.fr > 06 30 93 66 73 > > "If you knew today was your last day on earth, what would you do > differently? ....ESPECIALLY if, by doing something different, today > might not be your last day on earth.” Calvin & Hobbes > > > > >
TM
Tim Mackinnon
Mon, May 13, 2024 8:27 AM

Hey Esteban - understood. So it sounds like - quickly walk through all your project packages - add a little comment "upgrade to new tonel formt" and then commit (with everyone checked in before) sounds like the way to go.

I'll get on that with projects that I work with.

It does of course imply everyone move up to P12 (from P11) to avoid flip flopping between formats - and I don't think there is any reason to stick to P11 as P12 seems solid and without anything controversial to hold back on.

Thanks for pushing things forward.

Tim

On Mon, 13 May 2024, at 6:31 AM, Esteban Lorenzano via Pharo-users wrote:

Hi,

This is indeed a noisy change. That's the reason it was a change we were holding back during years, but at a point we needed to do it (there is a spec for tonel format we made together with Gemstone people and at a point, we needed to go to the agreed definition.

So, yes... this will cause annoying moments until all projects are migrated. My recommendation is to make a PR with the new format and work from there.

Esteban

ps: there will be still some noise, next year, since we need to clean up a bit around... I am sorry in advance.

On 12/05/2024 23:55, stephane ducasse wrote:

The team will be back from vacation…. last week was a three free days week :).

S

On 12 May 2024, at 06:21, Tim Mackinnon tim@testit.works wrote:

Asking this here as it didn’t get much traction on Discord - but with the move to P12, the category format in Tonel has changed from a symbol to a string e.g.  { #category : #examples } vs { #category : 'examples' } - this causes mega noise when submitting tiny PR's - how is everyone else handling this? Should projects resave every project module to get the new format while people are out of the pool? Or is there a way to force the old format on specific projects until they can be upgraded ?

It seems like a change whose consequences need some attention ?

What are others doing?

Tim

Stéphane Ducasse
http://stephane.ducasse.free.fr
06 30 93 66 73

"If you knew today was your last day on earth, what would you do differently? ....ESPECIALLY if, by doing something different, today might not be your last day on earth.” Calvin & Hobbes

Hey Esteban - understood. So it sounds like - quickly walk through all your project packages - add a little comment "upgrade to new tonel formt" and then commit (with everyone checked in before) sounds like the way to go. I'll get on that with projects that I work with. It does of course imply everyone move up to P12 (from P11) to avoid flip flopping between formats - and I don't think there is any reason to stick to P11 as P12 seems solid and without anything controversial to hold back on. Thanks for pushing things forward. Tim On Mon, 13 May 2024, at 6:31 AM, Esteban Lorenzano via Pharo-users wrote: > Hi, > > This is indeed a noisy change. That's the reason it was a change we were holding back during years, but at a point we needed to do it (there is a spec for tonel format we made together with Gemstone people and at a point, we needed to go to the agreed definition. > > So, yes... this will cause annoying moments until all projects are migrated. My recommendation is to make a PR with the new format and work from there. > > Esteban > > ps: there will be still some noise, next year, since we need to clean up a bit around... I am sorry in advance. > > On 12/05/2024 23:55, stephane ducasse wrote: >> The team will be back from vacation…. last week was a three free days week :). >> >> S >> >>> On 12 May 2024, at 06:21, Tim Mackinnon <tim@testit.works> wrote: >>> >>> Asking this here as it didn’t get much traction on Discord - but with the move to P12, the category format in Tonel has changed from a symbol to a string e.g. { #category : #examples } vs { #category : 'examples' } - this causes mega noise when submitting tiny PR's - how is everyone else handling this? Should projects resave every project module to get the new format while people are out of the pool? Or is there a way to force the old format on specific projects until they can be upgraded ? >>> >>> It seems like a change whose consequences need some attention ? >>> >>> What are others doing? >>> >>> Tim >> >> Stéphane Ducasse >> http://stephane.ducasse.free.fr >> 06 30 93 66 73 >> >> "If you knew today was your last day on earth, what would you do differently? ....ESPECIALLY if, by doing something different, today might not be your last day on earth.” Calvin & Hobbes >> >>
CF
Cyril FERLICOT-DELBECQUE
Mon, May 13, 2024 9:45 AM

Hi,

Here are some additional notes to what was already answered.

If you want to convert all the files of a repository at once to avoid to have multiple PR with format changes you can use this script and commit the resulting files:

| projectName |
projectName := 'Spec2'.
repository := IceRepository repositories detect: [ :repo | repo name = projectName ].
repository workingCopy packages do: [ :pkg |
IceLibgitTonelWriter forInternalStoreFileOut: pkg latestVersion mcVersion on: repository ]

Also, if you work on a project both in p12 and p11, you can avoid the ping pong by fixing a version of tonel in the properties file. The file to update is the .properties that is in the source folder and it should look like this:

{
#format : #tonel,
#version: #'1.0'
}

P12 will take into account the tonel version asked and use it. In previous version of Pharo, this additional line will be ignored and Tonel v1 will be used.

With both of those options it should be possible to reduce the pain of the format update.

Have a nice day

--
Cyril Ferlicot-Delbecque
https://ferlicot.fr

On Sunday, May 12th, 2024 at 12:21 PM, Tim Mackinnon tim@testit.works wrote:

Asking this here as it didn’t get much traction on Discord - but with the move to P12, the category format in Tonel has changed from a symbol to a string e.g. { #category : #examples } vs { #category : 'examples' } - this causes mega noise when submitting tiny PR's - how is everyone else handling this? Should projects resave every project module to get the new format while people are out of the pool? Or is there a way to force the old format on specific projects until they can be upgraded ?

It seems like a change whose consequences need some attention ?

What are others doing?

Tim

Hi, Here are some additional notes to what was already answered. If you want to convert all the files of a repository at once to avoid to have multiple PR with format changes you can use this script and commit the resulting files: | projectName | projectName := 'Spec2'. repository := IceRepository repositories detect: [ :repo | repo name = projectName ]. repository workingCopy packages do: [ :pkg | IceLibgitTonelWriter forInternalStoreFileOut: pkg latestVersion mcVersion on: repository ] Also, if you work on a project both in p12 and p11, you can avoid the ping pong by fixing a version of tonel in the properties file. The file to update is the .properties that is in the source folder and it should look like this: { #format : #tonel, #version: #'1.0' } P12 will take into account the tonel version asked and use it. In previous version of Pharo, this additional line will be ignored and Tonel v1 will be used. With both of those options it should be possible to reduce the pain of the format update. Have a nice day -- Cyril Ferlicot-Delbecque https://ferlicot.fr On Sunday, May 12th, 2024 at 12:21 PM, Tim Mackinnon <tim@testit.works> wrote: > Asking this here as it didn’t get much traction on Discord - but with the move to P12, the category format in Tonel has changed from a symbol to a string e.g. { #category : #examples } vs { #category : 'examples' } - this causes mega noise when submitting tiny PR's - how is everyone else handling this? Should projects resave every project module to get the new format while people are out of the pool? Or is there a way to force the old format on specific projects until they can be upgraded ? > > It seems like a change whose consequences need some attention ? > > What are others doing? > > Tim
SD
stephane ducasse
Mon, May 13, 2024 10:55 AM

Cyril

could you add that in the wiki somewhere. I will publish something on pharo weekly.

S

On 13 May 2024, at 05:45, Cyril FERLICOT-DELBECQUE via Pharo-users pharo-users@lists.pharo.org wrote:

Hi,

Here are some additional notes to what was already answered.

If you want to convert all the files of a repository at once to avoid to have multiple PR with format changes you can use this script and commit the resulting files:

| projectName |
projectName := 'Spec2'.
repository := IceRepository repositories detect: [ :repo | repo name = projectName ].
repository workingCopy packages do: [ :pkg |
IceLibgitTonelWriter forInternalStoreFileOut: pkg latestVersion mcVersion on: repository ]

Also, if you work on a project both in p12 and p11, you can avoid the ping pong by fixing a version of tonel in the properties file. The file to update is the .properties that is in the source folder and it should look like this:

{
#format : #tonel,
#version: #'1.0'
}

P12 will take into account the tonel version asked and use it. In previous version of Pharo, this additional line will be ignored and Tonel v1 will be used.

With both of those options it should be possible to reduce the pain of the format update.

Have a nice day

--
Cyril Ferlicot-Delbecque
https://ferlicot.fr

On Sunday, May 12th, 2024 at 12:21 PM, Tim Mackinnon tim@testit.works wrote:

Asking this here as it didn’t get much traction on Discord - but with the move to P12, the category format in Tonel has changed from a symbol to a string e.g. { #category : #examples } vs { #category : 'examples' } - this causes mega noise when submitting tiny PR's - how is everyone else handling this? Should projects resave every project module to get the new format while people are out of the pool? Or is there a way to force the old format on specific projects until they can be upgraded ?

It seems like a change whose consequences need some attention ?

What are others doing?

Tim

Stéphane Ducasse
http://stephane.ducasse.free.fr
06 30 93 66 73

"If you knew today was your last day on earth, what would you do differently? ....ESPECIALLY if, by doing something different, today might not be your last day on earth.” Calvin & Hobbes

Cyril could you add that in the wiki somewhere. I will publish something on pharo weekly. S > On 13 May 2024, at 05:45, Cyril FERLICOT-DELBECQUE via Pharo-users <pharo-users@lists.pharo.org> wrote: > > Hi, > > Here are some additional notes to what was already answered. > > If you want to convert all the files of a repository at once to avoid to have multiple PR with format changes you can use this script and commit the resulting files: > > | projectName | > projectName := 'Spec2'. > repository := IceRepository repositories detect: [ :repo | repo name = projectName ]. > repository workingCopy packages do: [ :pkg | > IceLibgitTonelWriter forInternalStoreFileOut: pkg latestVersion mcVersion on: repository ] > > Also, if you work on a project both in p12 and p11, you can avoid the ping pong by fixing a version of tonel in the properties file. The file to update is the .properties that is in the source folder and it should look like this: > > { > #format : #tonel, > #version: #'1.0' > } > > P12 will take into account the tonel version asked and use it. In previous version of Pharo, this additional line will be ignored and Tonel v1 will be used. > > With both of those options it should be possible to reduce the pain of the format update. > > Have a nice day > > -- > Cyril Ferlicot-Delbecque > https://ferlicot.fr > > > On Sunday, May 12th, 2024 at 12:21 PM, Tim Mackinnon <tim@testit.works> wrote: > >> Asking this here as it didn’t get much traction on Discord - but with the move to P12, the category format in Tonel has changed from a symbol to a string e.g. { #category : #examples } vs { #category : 'examples' } - this causes mega noise when submitting tiny PR's - how is everyone else handling this? Should projects resave every project module to get the new format while people are out of the pool? Or is there a way to force the old format on specific projects until they can be upgraded ? >> >> It seems like a change whose consequences need some attention ? >> >> What are others doing? >> >> Tim Stéphane Ducasse http://stephane.ducasse.free.fr 06 30 93 66 73 "If you knew today was your last day on earth, what would you do differently? ....ESPECIALLY if, by doing something different, today might not be your last day on earth.” Calvin & Hobbes
SD
stephane ducasse
Mon, May 13, 2024 10:57 AM

On 13 May 2024, at 05:45, Cyril FERLICOT-DELBECQUE via Pharo-users pharo-users@lists.pharo.org wrote:

Hi,

Here are some additional notes to what was already answered.

If you want to convert all the files of a repository at once to avoid to have multiple PR with format changes you can use this script and commit the resulting files:

| projectName |
projectName := 'Spec2'.
repository := IceRepository repositories detect: [ :repo | repo name = projectName ].
repository workingCopy packages do: [ :pkg |
IceLibgitTonelWriter forInternalStoreFileOut: pkg latestVersion mcVersion on: repository ]

Also, if you work on a project both in p12 and p11, you can avoid the ping pong by fixing a version of tonel in the properties file. The file to update is the .properties that is in the source folder and it should look like this:

{
#format : #tonel,
#version: #'1.0'
}

P12 will take into account the tonel version asked and use it. In previous version of Pharo, this additional line will be ignored and Tonel v1 will be used.

With both of those options it should be possible to reduce the pain of the format update.

Have a nice day

--
Cyril Ferlicot-Delbecque
https://ferlicot.fr

On Sunday, May 12th, 2024 at 12:21 PM, Tim Mackinnon tim@testit.works wrote:

Asking this here as it didn’t get much traction on Discord - but with the move to P12, the category format in Tonel has changed from a symbol to a string e.g. { #category : #examples } vs { #category : 'examples' } - this causes mega noise when submitting tiny PR's - how is everyone else handling this? Should projects resave every project module to get the new format while people are out of the pool? Or is there a way to force the old format on specific projects until they can be upgraded ?

It seems like a change whose consequences need some attention ?

What are others doing?

Tim

Stéphane Ducasse
http://stephane.ducasse.free.fr
06 30 93 66 73

"If you knew today was your last day on earth, what would you do differently? ....ESPECIALLY if, by doing something different, today might not be your last day on earth.” Calvin & Hobbes

https://pharoweekly.wordpress.com/2024/05/13/about-controling-change-format-in-p12/ > On 13 May 2024, at 05:45, Cyril FERLICOT-DELBECQUE via Pharo-users <pharo-users@lists.pharo.org> wrote: > > Hi, > > Here are some additional notes to what was already answered. > > If you want to convert all the files of a repository at once to avoid to have multiple PR with format changes you can use this script and commit the resulting files: > > | projectName | > projectName := 'Spec2'. > repository := IceRepository repositories detect: [ :repo | repo name = projectName ]. > repository workingCopy packages do: [ :pkg | > IceLibgitTonelWriter forInternalStoreFileOut: pkg latestVersion mcVersion on: repository ] > > Also, if you work on a project both in p12 and p11, you can avoid the ping pong by fixing a version of tonel in the properties file. The file to update is the .properties that is in the source folder and it should look like this: > > { > #format : #tonel, > #version: #'1.0' > } > > P12 will take into account the tonel version asked and use it. In previous version of Pharo, this additional line will be ignored and Tonel v1 will be used. > > With both of those options it should be possible to reduce the pain of the format update. > > Have a nice day > > -- > Cyril Ferlicot-Delbecque > https://ferlicot.fr > > > On Sunday, May 12th, 2024 at 12:21 PM, Tim Mackinnon <tim@testit.works> wrote: > >> Asking this here as it didn’t get much traction on Discord - but with the move to P12, the category format in Tonel has changed from a symbol to a string e.g. { #category : #examples } vs { #category : 'examples' } - this causes mega noise when submitting tiny PR's - how is everyone else handling this? Should projects resave every project module to get the new format while people are out of the pool? Or is there a way to force the old format on specific projects until they can be upgraded ? >> >> It seems like a change whose consequences need some attention ? >> >> What are others doing? >> >> Tim Stéphane Ducasse http://stephane.ducasse.free.fr 06 30 93 66 73 "If you knew today was your last day on earth, what would you do differently? ....ESPECIALLY if, by doing something different, today might not be your last day on earth.” Calvin & Hobbes
CF
Cyril FERLICOT-DELBECQUE
Mon, May 13, 2024 12:55 PM

I added some documentation here: 

https://github.com/pharo-open-documentation/pharo-wiki/blob/master/General/ExportFormats.md#tonel-versions

I hope this helps :)

--
Cyril Ferlicot-Delbecquehttps://ferlicot.fr

On Monday, May 13th, 2024 at 12:55 PM, stephane ducasse stephane.ducasse@inria.fr wrote:

Cyril

could you add that in the wiki somewhere. I will publish something on pharo weekly.

S

On 13 May 2024, at 05:45, Cyril FERLICOT-DELBECQUE via Pharo-users pharo-users@lists.pharo.org wrote:

Hi,

Here are some additional notes to what was already answered.

If you want to convert all the files of a repository at once to avoid to have multiple PR with format changes you can use this script and commit the resulting files:

| projectName |
projectName := 'Spec2'.
repository := IceRepository repositories detect: [ :repo | repo name = projectName ].
repository workingCopy packages do: [ :pkg |
IceLibgitTonelWriter forInternalStoreFileOut: pkg latestVersion mcVersion on: repository ]

Also, if you work on a project both in p12 and p11, you can avoid the ping pong by fixing a version of tonel in the properties file. The file to update is the .properties that is in the source folder and it should look like this:

{
#format : #tonel,
#version: #'1.0'
}

P12 will take into account the tonel version asked and use it. In previous version of Pharo, this additional line will be ignored and Tonel v1 will be used.

With both of those options it should be possible to reduce the pain of the format update.

Have a nice day

--
Cyril Ferlicot-Delbecque
https://ferlicot.fr

On Sunday, May 12th, 2024 at 12:21 PM, Tim Mackinnon tim@testit.works wrote:

Asking this here as it didn’t get much traction on Discord - but with the move to P12, the category format in Tonel has changed from a symbol to a string e.g. { #category : #examples } vs { #category : 'examples' } - this causes mega noise when submitting tiny PR's - how is everyone else handling this? Should projects resave every project module to get the new format while people are out of the pool? Or is there a way to force the old format on specific projects until they can be upgraded ?

It seems like a change whose consequences need some attention ?

What are others doing?

Tim

Stéphane Ducasse
http://stephane.ducasse.free.fr
06 30 93 66 73

"If you knew today was your last day on earth, what would you do differently? ....ESPECIALLY if, by doing something different, today might not be your last day on earth.” Calvin & Hobbes

I added some documentation here:  https://github.com/pharo-open-documentation/pharo-wiki/blob/master/General/ExportFormats.md#tonel-versions I hope this helps :) -- Cyril Ferlicot-Delbecquehttps://ferlicot.fr On Monday, May 13th, 2024 at 12:55 PM, stephane ducasse <stephane.ducasse@inria.fr> wrote: > Cyril > > could you add that in the wiki somewhere. I will publish something on pharo weekly. > > S > >> On 13 May 2024, at 05:45, Cyril FERLICOT-DELBECQUE via Pharo-users <pharo-users@lists.pharo.org> wrote: >> >> Hi, >> >> Here are some additional notes to what was already answered. >> >> If you want to convert all the files of a repository at once to avoid to have multiple PR with format changes you can use this script and commit the resulting files: >> >> | projectName | >> projectName := 'Spec2'. >> repository := IceRepository repositories detect: [ :repo | repo name = projectName ]. >> repository workingCopy packages do: [ :pkg | >> IceLibgitTonelWriter forInternalStoreFileOut: pkg latestVersion mcVersion on: repository ] >> >> Also, if you work on a project both in p12 and p11, you can avoid the ping pong by fixing a version of tonel in the properties file. The file to update is the .properties that is in the source folder and it should look like this: >> >> { >> #format : #tonel, >> #version: #'1.0' >> } >> >> P12 will take into account the tonel version asked and use it. In previous version of Pharo, this additional line will be ignored and Tonel v1 will be used. >> >> With both of those options it should be possible to reduce the pain of the format update. >> >> Have a nice day >> >> -- >> Cyril Ferlicot-Delbecque >> https://ferlicot.fr >> >> On Sunday, May 12th, 2024 at 12:21 PM, Tim Mackinnon <tim@testit.works> wrote: >> >>> Asking this here as it didn’t get much traction on Discord - but with the move to P12, the category format in Tonel has changed from a symbol to a string e.g. { #category : #examples } vs { #category : 'examples' } - this causes mega noise when submitting tiny PR's - how is everyone else handling this? Should projects resave every project module to get the new format while people are out of the pool? Or is there a way to force the old format on specific projects until they can be upgraded ? >>> >>> It seems like a change whose consequences need some attention ? >>> >>> What are others doing? >>> >>> Tim > > Stéphane Ducasse > http://stephane.ducasse.free.fr > 06 30 93 66 73 > > "If you knew today was your last day on earth, what would you do differently? ....ESPECIALLY if, by doing something different, today might not be your last day on earth.” Calvin & Hobbes
SD
stephane ducasse
Mon, May 13, 2024 1:48 PM

Tx!

On 13 May 2024, at 08:55, Cyril FERLICOT-DELBECQUE via Pharo-users pharo-users@lists.pharo.org wrote:

I added some documentation here: 

https://github.com/pharo-open-documentation/pharo-wiki/blob/master/General/ExportFormats.md#tonel-versions

I hope this helps :)

--
Cyril Ferlicot-Delbecque
https://ferlicot.fr https://ferlicot.fr/

On Monday, May 13th, 2024 at 12:55 PM, stephane ducasse stephane.ducasse@inria.fr wrote:

Cyril

could you add that in the wiki somewhere. I will publish something on pharo weekly.

S

On 13 May 2024, at 05:45, Cyril FERLICOT-DELBECQUE via Pharo-users pharo-users@lists.pharo.org wrote:

Hi,

Here are some additional notes to what was already answered.

If you want to convert all the files of a repository at once to avoid to have multiple PR with format changes you can use this script and commit the resulting files:

| projectName |
projectName := 'Spec2'.
repository := IceRepository repositories detect: [ :repo | repo name = projectName ].
repository workingCopy packages do: [ :pkg |
IceLibgitTonelWriter forInternalStoreFileOut: pkg latestVersion mcVersion on: repository ]

Also, if you work on a project both in p12 and p11, you can avoid the ping pong by fixing a version of tonel in the properties file. The file to update is the .properties that is in the source folder and it should look like this:

{
#format : #tonel,
#version: #'1.0'
}

P12 will take into account the tonel version asked and use it. In previous version of Pharo, this additional line will be ignored and Tonel v1 will be used.

With both of those options it should be possible to reduce the pain of the format update.

Have a nice day

--
Cyril Ferlicot-Delbecque
https://ferlicot.fr

On Sunday, May 12th, 2024 at 12:21 PM, Tim Mackinnon tim@testit.works wrote:

Asking this here as it didn’t get much traction on Discord - but with the move to P12, the category format in Tonel has changed from a symbol to a string e.g. { #category : #examples } vs { #category : 'examples' } - this causes mega noise when submitting tiny PR's - how is everyone else handling this? Should projects resave every project module to get the new format while people are out of the pool? Or is there a way to force the old format on specific projects until they can be upgraded ?

It seems like a change whose consequences need some attention ?

What are others doing?

Tim

Stéphane Ducasse
http://stephane.ducasse.free.fr
06 30 93 66 73

"If you knew today was your last day on earth, what would you do differently? ....ESPECIALLY if, by doing something different, today might not be your last day on earth.” Calvin & Hobbes

Stéphane Ducasse
http://stephane.ducasse.free.fr
06 30 93 66 73

"If you knew today was your last day on earth, what would you do differently? ....ESPECIALLY if, by doing something different, today might not be your last day on earth.” Calvin & Hobbes

Tx! > On 13 May 2024, at 08:55, Cyril FERLICOT-DELBECQUE via Pharo-users <pharo-users@lists.pharo.org> wrote: > > I added some documentation here:  > > https://github.com/pharo-open-documentation/pharo-wiki/blob/master/General/ExportFormats.md#tonel-versions > > I hope this helps :) > > -- > Cyril Ferlicot-Delbecque > https://ferlicot.fr <https://ferlicot.fr/> > > On Monday, May 13th, 2024 at 12:55 PM, stephane ducasse <stephane.ducasse@inria.fr> wrote: >> Cyril >> >> could you add that in the wiki somewhere. I will publish something on pharo weekly. >> >> S >> >>> On 13 May 2024, at 05:45, Cyril FERLICOT-DELBECQUE via Pharo-users <pharo-users@lists.pharo.org> wrote: >>> >>> Hi, >>> >>> Here are some additional notes to what was already answered. >>> >>> If you want to convert all the files of a repository at once to avoid to have multiple PR with format changes you can use this script and commit the resulting files: >>> >>> | projectName | >>> projectName := 'Spec2'. >>> repository := IceRepository repositories detect: [ :repo | repo name = projectName ]. >>> repository workingCopy packages do: [ :pkg | >>> IceLibgitTonelWriter forInternalStoreFileOut: pkg latestVersion mcVersion on: repository ] >>> >>> Also, if you work on a project both in p12 and p11, you can avoid the ping pong by fixing a version of tonel in the properties file. The file to update is the .properties that is in the source folder and it should look like this: >>> >>> { >>> #format : #tonel, >>> #version: #'1.0' >>> } >>> >>> P12 will take into account the tonel version asked and use it. In previous version of Pharo, this additional line will be ignored and Tonel v1 will be used. >>> >>> With both of those options it should be possible to reduce the pain of the format update. >>> >>> Have a nice day >>> >>> -- >>> Cyril Ferlicot-Delbecque >>> https://ferlicot.fr >>> >>> >>> On Sunday, May 12th, 2024 at 12:21 PM, Tim Mackinnon <tim@testit.works> wrote: >>> >>>> Asking this here as it didn’t get much traction on Discord - but with the move to P12, the category format in Tonel has changed from a symbol to a string e.g. { #category : #examples } vs { #category : 'examples' } - this causes mega noise when submitting tiny PR's - how is everyone else handling this? Should projects resave every project module to get the new format while people are out of the pool? Or is there a way to force the old format on specific projects until they can be upgraded ? >>>> >>>> It seems like a change whose consequences need some attention ? >>>> >>>> What are others doing? >>>> >>>> Tim >> >> Stéphane Ducasse >> http://stephane.ducasse.free.fr >> 06 30 93 66 73 >> >> "If you knew today was your last day on earth, what would you do differently? ....ESPECIALLY if, by doing something different, today might not be your last day on earth.” Calvin & Hobbes >> >> >> >> >> > Stéphane Ducasse http://stephane.ducasse.free.fr 06 30 93 66 73 "If you knew today was your last day on earth, what would you do differently? ....ESPECIALLY if, by doing something different, today might not be your last day on earth.” Calvin & Hobbes
TM
Tim Mackinnon
Mon, May 13, 2024 8:51 PM

Hey Cyril - as mentioned on Discord, thanks for advising and sorting this out (for the bigger changes in P13 - it will be useful to get something in the release notes - but definitely don't want to stand in the way of progress)!.

Tim

On Mon, 13 May 2024, at 1:55 PM, Cyril FERLICOT-DELBECQUE via Pharo-users wrote:

I added some documentation here: 

https://github.com/pharo-open-documentation/pharo-wiki/blob/master/General/ExportFormats.md#tonel-versions

I hope this helps :)

--
Cyril Ferlicot-Delbecque
https://ferlicot.fr

On Monday, May 13th, 2024 at 12:55 PM, stephane ducasse stephane.ducasse@inria.fr wrote:

Cyril

could you add that in the wiki somewhere. I will publish something on pharo weekly.

S

On 13 May 2024, at 05:45, Cyril FERLICOT-DELBECQUE via Pharo-users pharo-users@lists.pharo.org wrote:

Hi,

Here are some additional notes to what was already answered.

If you want to convert all the files of a repository at once to avoid to have multiple PR with format changes you can use this script and commit the resulting files:

| projectName |
projectName := 'Spec2'.
repository := IceRepository repositories detect: [ :repo | repo name = projectName ].
repository workingCopy packages do: [ :pkg |
IceLibgitTonelWriter forInternalStoreFileOut: pkg latestVersion mcVersion on: repository ]

Also, if you work on a project both in p12 and p11, you can avoid the ping pong by fixing a version of tonel in the properties file. The file to update is the .properties that is in the source folder and it should look like this:

{
#format : #tonel,
#version: #'1.0'
}

P12 will take into account the tonel version asked and use it. In previous version of Pharo, this additional line will be ignored and Tonel v1 will be used.

With both of those options it should be possible to reduce the pain of the format update.

Have a nice day

--
Cyril Ferlicot-Delbecque
https://ferlicot.fr

On Sunday, May 12th, 2024 at 12:21 PM, Tim Mackinnon tim@testit.works wrote:

Asking this here as it didn’t get much traction on Discord - but with the move to P12, the category format in Tonel has changed from a symbol to a string e.g. { #category : #examples } vs { #category : 'examples' } - this causes mega noise when submitting tiny PR's - how is everyone else handling this? Should projects resave every project module to get the new format while people are out of the pool? Or is there a way to force the old format on specific projects until they can be upgraded ?

It seems like a change whose consequences need some attention ?

What are others doing?

Tim

Stéphane Ducasse
http://stephane.ducasse.free.fr
06 30 93 66 73

"If you knew today was your last day on earth, what would you do differently? ....ESPECIALLY if, by doing something different, today might not be your last day on earth.” Calvin & Hobbes

Hey Cyril - as mentioned on Discord, thanks for advising and sorting this out (for the bigger changes in P13 - it will be useful to get something in the release notes - but definitely don't want to stand in the way of progress)!. Tim On Mon, 13 May 2024, at 1:55 PM, Cyril FERLICOT-DELBECQUE via Pharo-users wrote: > I added some documentation here:  > > https://github.com/pharo-open-documentation/pharo-wiki/blob/master/General/ExportFormats.md#tonel-versions > > I hope this helps :) > > -- > Cyril Ferlicot-Delbecque > https://ferlicot.fr > > > On Monday, May 13th, 2024 at 12:55 PM, stephane ducasse <stephane.ducasse@inria.fr> wrote: >> Cyril >> >> could you add that in the wiki somewhere. I will publish something on pharo weekly. >> >> S >> >>> On 13 May 2024, at 05:45, Cyril FERLICOT-DELBECQUE via Pharo-users <pharo-users@lists.pharo.org> wrote: >>> >>> Hi, >>> >>> Here are some additional notes to what was already answered. >>> >>> If you want to convert all the files of a repository at once to avoid to have multiple PR with format changes you can use this script and commit the resulting files: >>> >>> | projectName | >>> projectName := 'Spec2'. >>> repository := IceRepository repositories detect: [ :repo | repo name = projectName ]. >>> repository workingCopy packages do: [ :pkg | >>> IceLibgitTonelWriter forInternalStoreFileOut: pkg latestVersion mcVersion on: repository ] >>> >>> Also, if you work on a project both in p12 and p11, you can avoid the ping pong by fixing a version of tonel in the properties file. The file to update is the .properties that is in the source folder and it should look like this: >>> >>> { >>> #format : #tonel, >>> #version: #'1.0' >>> } >>> >>> P12 will take into account the tonel version asked and use it. In previous version of Pharo, this additional line will be ignored and Tonel v1 will be used. >>> >>> With both of those options it should be possible to reduce the pain of the format update. >>> >>> Have a nice day >>> >>> -- >>> Cyril Ferlicot-Delbecque >>> https://ferlicot.fr >>> >>> >>> On Sunday, May 12th, 2024 at 12:21 PM, Tim Mackinnon <tim@testit.works> wrote: >>> >>>> Asking this here as it didn’t get much traction on Discord - but with the move to P12, the category format in Tonel has changed from a symbol to a string e.g. { #category : #examples } vs { #category : 'examples' } - this causes mega noise when submitting tiny PR's - how is everyone else handling this? Should projects resave every project module to get the new format while people are out of the pool? Or is there a way to force the old format on specific projects until they can be upgraded ? >>>> >>>> It seems like a change whose consequences need some attention ? >>>> >>>> What are others doing? >>>> >>>> Tim >> >> Stéphane Ducasse >> http://stephane.ducasse.free.fr >> 06 30 93 66 73 >> >> "If you knew today was your last day on earth, what would you do differently? ....ESPECIALLY if, by doing something different, today might not be your last day on earth.” Calvin & Hobbes >> >>