[Pharo-users] How to contribute to Pharo Launcher?

Christophe Demarey christophe.demarey at inria.fr
Tue Jun 19 04:51:34 EDT 2018


Hi Tim,

Thanks a lot for your contributions. Looks good to me. It is a nice addition.
Could you open an issue https://github.com/pharo-project/pharo-launcher/issues/new so that we can keep a trace of your contribution (we open issues for features / improvements also)? 

Thanks also to Cyril who helped you to commit to ST.

Cheers,
Christophe.

> Le 18 juin 2018 à 19:20, Tim Mackinnon <tim at testit.works> a écrit :
> 
> While I’m at it - improve the icon for Launch without Settings (it needed Alpha)
> 
> Name: PharoLauncher-Core-TimM.174
> Author: TimM
> Time: 18 June 2018, 6:11:54.416337 pm
> UUID: d9433566-4f2b-0d00-85be-afca09965ccd
> Ancestors: PharoLauncher-Core-TimM.173
> 
> Sorry - can’t help with the windows launch problems as I don’t have a windows machine any more.
> 
>> On 18 Jun 2018, at 17:35, Tim Mackinnon <tim at testit.works> wrote:
>> 
>> Ok - I’ve done a save for both packages - hopefully they are useful:
>> 
>> Name: PharoLauncher-Spec-TimM.70
>> Author: TimM
>> Time: 18 June 2018, 5:32:00.928101 pm
>> UUID: 5e888bd7-4e2b-0d00-85bb-537409965ccd
>> Ancestors: PharoLauncher-Spec-TimM.69
>> 
>> 
>> Name: PharoLauncher-Core-TimM.172
>> Author: TimM
>> Time: 18 June 2018, 5:34:46.055084 pm
>> UUID: 6a2b63e1-4e2b-0d00-85bc-0fed09965ccd
>> Ancestors: PharoLauncher-Core-TimM.171
>> 
>> 
>> 
>>> On 18 Jun 2018, at 16:30, Cyril Ferlicot D. <cyril.ferlicot at gmail.com> wrote:
>>> 
>>> On 18/06/2018 17:27, Tim Mackinnon wrote:
>>>> Hi Cyril - I have to confess that I don’t recall what the steps are to safely commit in Monticello. I have smallish changes to 2 packages Core and Spec, and I can see that smalltalkhub repo in the MC browser and can browse my changes against it - but how do I commit both packages in there? I vaguely recall something about slices - but wasn’t that a Pharo core thing?
>>>> 
>>>> I get the impression that I don’t just press save on each package against sthub do I?
>>>> 
>>>> Sorry to be so dumb - I’ve just swapped out Monticello usage for Git usage these days.  Just need a few hints to get back on track
>>>> 
>>> 
>>> You need to save the two packages individually.
>>> 
>>> While git is project oriented, StHub is package oriented.
>>> 
>>> Slices are only for Pharo development. (One could adapt them to make
>>> Monticello more project oriented but it is currently not the case).
>>> 
>>> So in conclusion, yes you need to press save on each package. :)
>>> 
>>>> Tim
>>>> 
>>>> 
>>>> 
>>> 
>>> 
>>> -- 
>>> Cyril Ferlicot
>>> https://ferlicot.fr
>>> 
>> 
>> 
> 
> 




More information about the Pharo-users mailing list