[Pharo-dev] [QA] Re: GLMAction and PharoShortcut

Hilaire hilaire at drgeo.eu
Sun Feb 12 10:54:49 EST 2017


Le 12/02/2017 à 11:53, Ben Coman a écrit :
> 
> Well spotted.  They should be consistent.  I guess the next questions are;
> * Does Glamour convert cross platform Meta-x definitions to platform
> specific in its rendering? Or are the Ctrl-xx hard coded?

GLMAction comes with a method to render a print representation of shor
tcut, but it is not its responsibility to do so. It is the short cut
responsibility, so other widget can also use the same and consistent
print representation.

The responsability should go to instance of KMModifiedKeyCombination,
not sure about that though.

The way the modifier is selected in the GLamour looks strange, why not
using the modifier instance?


> * If the former, can Spec be made to do the same conversion for its
> rendering?
> * Or do we prefer to refer to the general Meta-x throughout the UI?


The way short cuts are rendered in menu or tool tip is not consistent.
In Nautilus you have for example: 'Ctrl + A', in debugger it is rendered
'ctrl+a' for Ctrl-a or 'ctrl+shift+a' for Ctrl-A.
In playground you can see both depending on you are viewing a menu or a
button tool tip.

Now I see another place where short cut gets a print representation:
	MorphicMenuItemAdapter>>shortcutText



-- 
Dr. Geo
http://drgeo.eu




More information about the Pharo-dev mailing list