[Pharo-dev] fixing the tab morph

Pavel Krivanek pavel.krivanek at gmail.com
Tue Aug 8 09:01:24 EDT 2017


I personally think that the tabs in TabGroupMorph look more like tabs :-)

-- Pavel

2017-08-07 17:47 GMT+02:00 Esteban Lorenzano <estebanlm at gmail.com>:

> Hi,
>
> So… summer project (to do when there is too much hot to go outside): fix
> some minor things that are inside the image that annoys me since some time.
>
> First issue: the tab morph we have is horrible (and makes horrible
> anything with it).
> I’ve been working on it to fix that “chromish-but-bad” style we had and to
> fix some (a lot) hardcoded colors there.
> Now, for example, Calypso looks like this:
>
>
>
>
> which is IMHO a lot better :)
>
> some remarks:
>
> 1) I find TabManagerMorph an ugly name. Do you think we should change it?
> (I tend to think anything called *Manager, *Controller, etc. as a bad
> naming chose and probably the mark of a smell).
> 2) much more important: we should deprecate TabGroupMorph and
> LazyTabGroupMorph family… there should not be more than one widget to do
> the same in the system.
>
> So well, as usual with old things: you fix a little thing and you uncover
> a lot of new problems :)
>
> Esteban
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.pharo.org/pipermail/pharo-dev_lists.pharo.org/attachments/20170808/57cfa8c9/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Screen Shot 2017-08-07 at 17.43.16.png
Type: image/png
Size: 506524 bytes
Desc: not available
URL: <http://lists.pharo.org/pipermail/pharo-dev_lists.pharo.org/attachments/20170808/57cfa8c9/attachment-0001.png>


More information about the Pharo-dev mailing list