[Pharo-dev] SLICE-Issue-12179-Nautilus-Add-package-filter-input-box

Juraj Kubelka juraj.kubelka at gmail.com
Sun Nov 24 15:38:12 EST 2013


Ok, thank you Marcus.

Jura

El 24-11-2013, a las 17:36, Marcus Denker <marcus.denker at inria.fr> escribió:

> 
> On 24 Nov 2013, at 21:29, Juraj Kubelka <juraj.kubelka at gmail.com> wrote:
> 
>> I would like, but I have not found out how. I will take care of it and ask in mailing list.
>> 
>> Anyway, I am not sure if it was well integrated. I have just downloaded image 30593 and I can see in PackageTreeNautilusUI>>buildFirstColumn: line
>> 
>> ^ firstColumn := PanelMorph new
>> 
>> it should be without instance variable:
>> 
>> ^ PanelMorph new
>> 
> 
> If you would have put the status on  “Fix review needed” the monkey would have found this…
> 
> The reason is that there was a code critic clean done of Nautilus where the critic tools found that firstColumn was just assigned and never
> read. Therefore it was possible to just remove it (and secondColumn).
> 
> This change was done after you did your Slice… therefore your code was right when it was done but out-dated in the meantime.
> 
> (it’s easy to fix *and* it was catcher by the tests… so nothing bad happened)
> 
> 	Marcus





More information about the Pharo-dev mailing list