[Pharo-dev] Fwd: Patches for Pharo packages you are maintaining

Stéphane Ducasse stephane.ducasse at inria.fr
Sun Nov 24 04:31:33 EST 2013


I will sycn the package and update the configuration.
I added monty to the XMLReader and XMLWriter PharoExtras packages.


Begin forwarded message:

> From: "monty" <monty.os at engineer.com>
> Subject: Re: Patches for Pharo packages you are maintaining
> Date: November 24, 2013 3:17:01 AM GMT+01:00
> To: "Stéphane Ducasse" <stephane.ducasse at inria.fr>
> 
> I created a Smalltalkhub account and uploaded the latest versions of my packages there: http://smalltalkhub.com/#!/~monty/XMLPackages
> 
> I was able to use the existing parsing infrastructure to build a tolerant HTML parser that produces a DOM tree. I am not sure if this should be standard or packaged separately. The relevant classes are in XML-Parser-HTML, if Damien (or whoever) wants to extract them.
> 
> I also added support for standlone="yes" declarations and made the path resolution more robust.
> 
> XMLParser now fully supports all the features of the XML 1.0 and namespaces 1.0 specs.

This is a great news

>  
>> ----- Original Message -----
>> From: Stéphane Ducasse
>> Sent: 11/21/13 03:19 PM
>> To: monty
>> Subject: Re: Patches for Pharo packages you are maintaining
>>  
>> > I don't have a Smalltalkhub account 
>> 
>> you should get one because it is cool and good. 
>> You should published there because when you publish the code it is explicit that this is under MIT. 
>> 
>> > and haven't signed any documents, but all my contributions have been derivative and should be automatically licensed under MIT (or whatever the original licenses of the packages are). 
>> 
>> MIT. 
>> It is important also for Pharo to have more contributors so if you can sign the license agreement I can like that archive it. :). 
>> 
>> Setf 
>> 
>> > 
>> > ----- Original Message ----- 
>> > From: Stéphane Ducasse 
>> > Sent: 11/21/13 06:17 AM 
>> > To: monty 
>> > Subject: Re: Patches for Pharo packages you are maintaining 
>> > ***excellent *** 
>> > 
>> > do you have an account on smalltalkhub so that I can give you access to it? 
>> > Did you sign the license agreement that you can find on the web? 
>> > 
>> > Stef 
>> > 
>> > 
>> > On Nov 21, 2013, at 3:14 AM, "monty" <monty.os at engineer.com> wrote: 
>> > 
>> >> Prof. Stef, I have produced updates to the XML-Parser, XML-Parser-Testing, and XML-Writer-Core packages you are maintaining. 
>> > 
>> > I'm not maintaining it, just making sure that we can load them. 
>> > 
>> >> These updates add validation against internal and external DTDs, proper replacement of general and parameter entites, customizable resolution of external parsed entities using Zinc and FileSystem, awareness of notations and unparsed entities, preservation of the internal DTD subset by the DOM parser (so printing a parsed doc with a DTD will produce approximately what was input), line numbers reporting in error messages, and better well-formed and validity constraints. 
>> >> 
>> >> I had to largely rewrite the tokenizer to make everything work, but I followed the spec closely, and it is about the same speed as long as there is no DTD to validate against. 
>> >> 
>> >> One problem is that while the tests I added and the existing tests all pass, for some reason helper messages in some test classes starting with "should" (in the style of should:raise:) are being interpreted as tests and run by TestRuner, even though they don't begin with "test" and take arguments! This is possibly a bug in TestRunner. 
>> > 
>> > Indeed this looks strange, 
>> > 
>> >> Another problem is that there are so many deprecated methods cluttering up classes, some of which have been deprecated for years! It is confusing and hard to see which methods to use just by browsing the protocols. I would really suggest using this code to get rid of the XML-Parser methods that have been deprecated for at least a year: 
>> > 
>> > Yes :) 
>> > 
>> > 
>> >> 
>> >> expiry := 1 year. 
>> >> (SystemNavigation default allClassesInPackageNamed: 'XML-Parser') 
>> >> do: [:class | 
>> >> class selectors do: [:selector | | compiledMethod timeStamp | 
>> >> compiledMethod := class compiledMethodAt: selector. 
>> >> timeStamp := compiledMethod timeStamp copyAfter: Character space. 
>> >> (compiledMethod isDeprecated 
>> >> and: [(DateAndTime now - (DateAndTime fromString: timeStamp)) > expiry]) 
>> >> ifTrue: [class removeSelector: selector]]]. 
>> >> 
>> >> I ran and checked it myself and it doesn't break anything. Running the above with XML-Writer-Core might not be a bad idea either. 
>> >> 
>> >> I also updated BitmapCharacterSet to use less memory. 
>> > 
>> > excellent 
>> > With metacello we will just create a new version/baseline and people relying on XML can choose when they want to migrate. 
>> > 
>> >> <XML-Writer-Core-monty.5.mcz><XML-Tests-Parser-monty.27.mcz><XML-Parser-monty.173.mcz><Collections-BitmapCharacterSet-Anonymous.6.mcz><Collections-BitmapCharacterSet-Anonymous.6.mcz>
>  

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.pharo.org/pipermail/pharo-dev_lists.pharo.org/attachments/20131124/a8ad758c/attachment-0002.html>


More information about the Pharo-dev mailing list