[Pharo-project] #anyChanges still needed?
Mariano Martinez Peck
marianopeck at gmail.com
Sat Jun 16 15:52:16 EDT 2012
On Sat, Jun 16, 2012 at 9:19 PM, Guillermo Polito <guillermopolito at gmail.com
> I do not care to write extra stuff into the changes file. My hd is large
> enough to handle some extra kilobytes...
Usually, people do not add this kind of stuff just because. There is a
reason behind. This method looks from 2004 (by Adrian Lienchard), and I
don't think they have problems with the HDD either at that time. So I would
like to be sure which is the reason.
> On Sat, Jun 16, 2012 at 9:14 PM, Mariano Martinez Peck <
> marianopeck at gmail.com> wrote:
>> Hi guys. ChangeSet does at some point:
>> anEvent itemKind = SystemChangeNotifier classKind ifTrue: [
>> anEvent isModified
>> ifTrue: [anEvent anyChanges ifTrue: [self changeClass: anEvent item from: anEvent oldItem]].
>> So...I don't understand the #anyChanges. We received an event saying that a class was modified, but it may not have any changes? if true, why was the event sent?
>> Ok...let's say that there could be several reasons that a class was modified but only some of them make sense to change set. I can imagine people wanted to avoid writing stuff to .changes that didn't actullay represente a change?
>> If this is the case, then #anyChanges looks like a bad name for me.
>> Now, do we still need this mesage? can there be ClassModified events without changes?
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Pharo-dev